GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Small arithmetic simplification by canni · Pull Request #5 · eapache/queue

Conversation

@canni

@canni canni commented Jun 4, 2015

Copy link
Copy Markdown
Contributor

IMO this reads nicer, and it's easier to understand :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@canni
Simplify arithmetic so it's easier to understand
334cc1b
@eapache

eapache commented Jun 4, 2015

Copy link
Copy Markdown
Owner

I don't disagree stylistically, but these changes do add about 5% to the benchmark times on my machine, which isn't ideal.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@canni

canni commented Jun 4, 2015

Copy link
Copy Markdown
Contributor Author

That is strange, but looks like it's second commit causes slowdown, first actually gives ~5% speedup
Try again with only first of two commits

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@eapache

eapache commented Jun 6, 2015

Copy link
Copy Markdown
Owner

Yup, first commit on its own seems to give a (marginal) speed-up. I think that makes sense; len(foo) looks like a function call but I believe it reduces to just a variable access, so storing it in a variable explicitly just makes more work for the compiler.

Push the branch back to just the first commit and I'll merge this.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@canni

canni commented Jun 6, 2015

Copy link
Copy Markdown
Contributor Author

@eapache done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

eapache added a commit that referenced this pull request Jun 6, 2015
@eapache
Merge pull request #5 from canni/master
ded5959
Small arithmetic simplification
@eapache
eapache merged commit ded5959 into eapache:master Jun 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@canni @eapache
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.