GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Development kw asyncfx wrap by sampeson · Pull Request #55 · eficode/JavaFXLibrary

Conversation

@sampeson

@sampeson sampeson commented Nov 2, 2020

Copy link
Copy Markdown
Contributor

rewrite to use asyncfx thread for testfx and javafx work

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
sampeson added 21 commits September 24, 2020 10:56
@sampeson
wrap runKeyword to asyncFx so that JavaFX operations are done FX thread
808086d
@sampeson
Merge branch 'development' into development_kw_asyncfx_wrap
4fa3b45
@sampeson
more asyncfx fixes, went through whole code base
cb6b84d
@sampeson
new wrapping to asyncfx thread
bdbe02e
@sampeson
additional rewrite to have all needed kw's wrapped in FX thread, outp…
743028e
…ut and error handling improvements
@sampeson
handle null object properlty, timeout to be generic kw timeout, handl…
12cf740
…e separately wait until kws, kw output improvements
@sampeson
fix hover related kw's
901ecc0
@sampeson
waitUntilExists and waitUntilDoesNotExist improvements
cade3b3
@sampeson
wait until keywords to have overall timeout value, improved printout
6f73c91
@sampeson
fix text prefix to check for quotation marks
3efb7a0
@sampeson
fix text prefix to have support for apostrophe (') also
08ad7b9
@sampeson
cleanup
cea7c8c
@sampeson
fix verifiers hoverable kw's, add test
bb61985
@sampeson
fix push many times kw
04a2e97
@sampeson
fix osx tests
c70767d
@sampeson
screenshots to asyncfx thread also in kw failure, fix hover kw's once…
2ea2f8b
… more
@sampeson
fix osx part and go throught documentation
6044db4
@sampeson
fix osx part and go throught documentation
d3e49a3
@sampeson
Merge branch 'development_kw_asyncfx_wrap' of github.com:eficode/Java…
ec2458b
…FXLibrary into development_kw_asyncfx_wrap
@sampeson
fix RunOnFailure to not store screenshot as mapObject to save memory
d1e5b52
@sampeson
remove comments
f404748
@sampeson
sampeson merged commit 65d4ad9 into development Nov 2, 2020
sampeson added a commit that referenced this pull request Nov 11, 2020
@sampeson @soisetu @psaikkonen
0.7.1 changes (#58)
629d976
* Experimental java agent support

JavaFXLibrary can now be attached to process as java agent.

* Fix docker-compose up

Building the docker demo failed because of missing package versions for
the newer Ubuntu image. Base image of the demo is now fixed to bionic
tag since Ubuntu updates have broken the build earlier as well.
Related Launchpad ticket:
https://bugs.launchpad.net/ubuntu/+source/openjfx/+bug/1799946

* Updated documentation (java agent)

* Add possibility to configure different directory for log.html in Set Screenshotdir, fixes #17

* java agent documentation fix

* Set Classpath failure as warnings and add failIfNotFound argument

* Use asyncFx for helperfunctions methods, remove waitForFxEvents usage, failure printout improvements

* remove deprecated keywords and methods (enhancement #11)

* Set empty string args as nulls, add message for IllegalArgumentException (#53)

looks good to me

* Development kw asyncfx wrap (#55)

* wrap runKeyword to asyncFx so that JavaFX operations are done FX thread

* more asyncfx fixes, went through whole code base

* new wrapping to asyncfx thread

* additional rewrite to have all needed kw's wrapped in FX thread, output and error handling improvements

* handle null object properlty, timeout to be generic kw timeout, handle separately wait until kws, kw output improvements

* fix hover related kw's

* waitUntilExists and waitUntilDoesNotExist improvements

* wait until keywords to have overall timeout value, improved printout

* fix text prefix to check for quotation marks

* fix text prefix to have support for apostrophe (') also

* cleanup

* fix verifiers hoverable kw's, add test

* fix push many times kw

* fix osx tests

* screenshots to asyncfx thread also in kw failure, fix hover kw's once more

* fix osx part and go throught documentation

* fix osx part and go throught documentation

* fix RunOnFailure to not store screenshot as mapObject to save memory

* remove comments

* fix moveTo keyword to use asyncFx thread, fixes #57

* fix scroll keywords to do one tick at time from main thread, fix related tests

* fix moveTo in osx also

Co-authored-by: Turo Soisenniemi <[email protected]>
Co-authored-by: Pasi Saikkonen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@sampeson
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.