GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Display image name on download buttons and improve the buttons' formatting by WasabiFan · Pull Request #340 · ev3dev/ev3dev.github.io

Conversation

@WasabiFan

@WasabiFan WasabiFan commented Feb 11, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This does three things:

  • Re-writes the release logic to be much less ugly
  • Adds a "refresh" button which re-loads the download data, bypassing the 20-minute cache
  • Adds a tooltip which shows the release name

I'd recommend viewing the two commits individually.

Here's a screenshot, because I can't publish at the moment:

image

Fixes #338

This should be merged as a rebase; do not squash this PR.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
WasabiFan added 2 commits February 10, 2017 19:03
@WasabiFan
Clean up releases script and add reload button
94cc060
@WasabiFan
Add tooltip with release name to download buttons
488f593
@WasabiFan
WasabiFan requested a review from dlech February 11, 2017 03:26
@dlech

dlech commented Feb 11, 2017

Copy link
Copy Markdown
Member

Adds a "refresh" button which re-loads the download data, bypassing the 20-minute cache

This seems a very odd feature for an otherwise static website. Let's explore other possibilities. For example, could we get away with removing the cache? GitHub's rate limit is 60 requests per hour, so I have a hard time imagining that someone would hit this limit. Or we could setup a relay server as suggested here.

Adds a tooltip which shows the release name

When you opened issue #340, I was envisioning having the file name on the button itself. Something like this (except with better alignment and a more narrow font for the file name):

example button

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@WasabiFan

WasabiFan commented Feb 11, 2017

Copy link
Copy Markdown
Member Author

For example, could we get away with removing the cache?

I don't think we can remove it entirely, but I think it would be fine to remove it or dramatically lower the timeout for the downloads page specifically. I'd like to avoid setting up our own infrastructure unless absolutely necessary.

Something like this (except with better alignment and a more narrow font for the file name):

I tried that, but I couldn't figure out how to make that happen within an a tag while keeping our HTML valid.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@dlech

dlech commented Feb 11, 2017

Copy link
Copy Markdown
Member

I'd like to avoid setting up our own infrastructure unless absolutely necessary.

I would rather do this than a reload button.

I tried that, but I couldn't figure out how to make that happen within an a tag while keeping our HTML valid.

This says in HTML 5, you can put anything you like inside of an <a> tag and if you still want HTML 4 validity, you can style inline elements to look work like block elements.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

WasabiFan added 2 commits March 11, 2017 00:29
@WasabiFan
Remove "refresh" button and use better download formatting
954499a
@WasabiFan
Merge branch 'master' of https://github.com/ev3dev/ev3dev.github.io i…
5e257a8
…nto enhance-downloads-page
@WasabiFan

WasabiFan commented Mar 11, 2017

Copy link
Copy Markdown
Member Author

I've taken the time to come back to this PR and get it finished up. I removed the "refresh" button in favor of a decreased cache time and reformatted the download buttons to work well with an inlined file name. Here's how it looks (sorry for the huge screenshot 😉):

image

I can't persuade our publish script to function properly right now so we'll have to settle for the screenshot.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

dlech
dlech requested changes Mar 11, 2017
View reviewed changes

@dlech dlech left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the white background of the size badge makes the size look too "important". How about using a different shade of orange so that it is less prominent?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@WasabiFan

WasabiFan commented Mar 13, 2017

Copy link
Copy Markdown
Member Author

I was able to find a tweak of that design which is a bit less bold:

image

Personally, I think the darker color is distracting in its own right as it departs from the design we use on the rest of the site.

Playing around in Illustrator, I came up with something I like, however it'd be a bit of work to build it in CSS:

download button mock-up

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@WasabiFan

WasabiFan commented Mar 14, 2017

Copy link
Copy Markdown
Member Author

I figured out how to do that multipart button, if we want it: http://www.bootply.com/v2c4s4X2Xe

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@dlech

dlech commented Mar 14, 2017

Copy link
Copy Markdown
Member

bootply link is not working for me

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@WasabiFan

WasabiFan commented Mar 15, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Haha, looks like I broke Bootply... they're completely down right now 😁

That mock-up is just a technical demo of the alignment; the styling isn't polished by any means.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@dlech

dlech commented Mar 15, 2017

Copy link
Copy Markdown
Member

Hmm... the bootply demo interacts as if it is two separate buttons. The mouseover affects the top and bottom halves separately. That doesn't make for a very good UX.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@WasabiFan

WasabiFan commented Mar 15, 2017

Copy link
Copy Markdown
Member Author

That's just some styling work that I didn't bother with for demonstration purposes; my goal was to make sure that I could handle the alignment of the containers, because mouseover effects are known to work. If I actually implement this control I'll need to style the button accordingly..

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@dlech

dlech commented Mar 15, 2017

Copy link
Copy Markdown
Member

I like it if you can make it work.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

WasabiFan added 2 commits March 24, 2017 18:38
@WasabiFan
Merge remote-tracking branch 'upstream/master' into enhance-downloads…
703792e
…-page
@WasabiFan
Use two-part buttons for download links
4a25eb0
@WasabiFan

WasabiFan commented Mar 25, 2017

Copy link
Copy Markdown
Member Author

I have the basis of this done. I next need to get my styles working for dynamically-chosen button sizes so that the smaller ones for RasPi and the Beagles are handled correctly. Currently, the ones in the guide are misaligned and the ones on the downloads page are overlapping images in undesirable ways.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@WasabiFan
Fix download button alignment and normalize text
9b49b3f
@WasabiFan

WasabiFan commented Mar 27, 2017

Copy link
Copy Markdown
Member Author

I made those final changes. The pages are live here:

  • http://wasabifan.github.io/ev3dev.github.io/download/
  • http://wasabifan.github.io/ev3dev.github.io/docs/getting-started/#step-1-download-the-latest-ev3dev-image-file
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@WasabiFan WasabiFan changed the title Enhance downloads page Display image name on download buttons and improve the buttons' formatting Mar 27, 2017
@WasabiFan

WasabiFan commented Mar 27, 2017

Copy link
Copy Markdown
Member Author

Also, I normalized the text of the buttons so that each is the same across the two pages on which it is used. The only discrepancy is between the EV3's buttons on the two pages, where one is prefixed by "Download for" to make the intent of the buttons clear.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@dlech

dlech commented Mar 29, 2017

Copy link
Copy Markdown
Member

One thing I want to do now that we are starting to have stretch images is make the download buttons say "Download ev3dev-jessie for LEGO MINDSTORMS EV3".

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@dlech

dlech commented Mar 29, 2017

Copy link
Copy Markdown
Member

I just had a look at the previews and "ev3dev-jessie" is in the file name, so that might be good enough.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@dlech

dlech commented Mar 29, 2017

Copy link
Copy Markdown
Member

By themselves, the buttons look great, but in the context of the page, I think the gray makes them too busy and makes them look a bit out of place. It is especially bad on the getting started page with the alerts above and below.

selection_014

What if we just keep everything orange? Then the buttons won't be so tall either.

image

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@WasabiFan

WasabiFan commented Mar 30, 2017

Copy link
Copy Markdown
Member Author

Wasn't the original issue that the white badge was too distracting on the plain orange buttons?

For comparison, here's a CSS-ed screenshot of roughly what the normal button would look like with the new layout:

image

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@dlech

dlech commented Mar 30, 2017

Copy link
Copy Markdown
Member

I could do without the badge regardless of the background color. Stylizing the file size with italics or something else would be just fine with me.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@dlech
dlech force-pushed the master branch from a126dfd to 536a64c Compare June 14, 2018 18:33

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dlech dlech dlech requested changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@WasabiFan @dlech
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.