Description

kushalkolar

opened on Mar 6, 2024

Issue body actions

#382 brought in one regression, we can no longer directly pass a controller instance, this is useful for synchronizing across plots so we should bring it back. For now users can manually assign controller instances for subplots after creating a GridPlot.

Activity

1. kushalkolar commented on Mar 6, 2024

   

   kushalkolar

   on Mar 6, 2024

   MemberAuthor

   More actions

   @clewis7 What do you think of this solution, we allow a controllers kwarg which can be an iterable of controller instances. If supplied, then controller_ids and controller_types are ignored. This is useful for manually defining the controllers of every subplot.

   My only concern is whether this is too many controller related kwargs 😂
2. clewis7 commented on Mar 8, 2024

   

   clewis7

   on Mar 8, 2024

   Member

   More actions

   I agree, having this functionality is important. I think maybe it would get confusing to have another controllers kwarg if there is already controller_ids and controller_types, but perhaps we would just need good documentation for users.

   I do agree that directly passing controllers would supersede the other kwargs.
3. kushalkolar

   self-assigned this

   on Mar 27, 2024
4. kushalkolar

   closed this as completedin #477on Apr 7, 2024

Issue actions