GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gridplot controllers kwarg is back, other improvements to gp by kushalkolar · Pull Request #477 · fastplotlib/fastplotlib

Conversation

@kushalkolar

@kushalkolar kushalkolar commented Apr 7, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

closes #425

  • controllers kwarg to Gridplot to manually pass pygfx.Controller instance(s), all other controller kwargs are ignored if this is passed
  • add @cameras and @controllers properties to Gridplot
  • tests the various cameras and controllers kwargs, and changing cameras and controllers after gridplot creation

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
kushalkolar added 4 commits April 7, 2024 05:24
@kushalkolar
gridplot controllers kwarg is back, other improvements to gp
72d2040
@kushalkolar
gridplot manipulation tests
9f4e8f7
@kushalkolar
black
93a503f
@kushalkolar
done wtih gp tests
a43e5fe
@kushalkolar
kushalkolar marked this pull request as ready for review April 7, 2024 09:57
@kushalkolar
kushalkolar requested a review from clewis7 as a code owner April 7, 2024 09:57
kushalkolar added 3 commits April 7, 2024 06:10
@kushalkolar
move non example tests to new tests dir
af64f8c
@kushalkolar
force offscreen canvas
81240ea
@kushalkolar
force offscreen canvas with env var for now
b57243f
@kushalkolar
kushalkolar merged commit 418a73b into main Apr 7, 2024
@kushalkolar
kushalkolar deleted the gp-controllers-kwarg branch April 7, 2024 10:45
kushalkolar
kushalkolar commented Apr 7, 2024
View reviewed changes
Comment thread fastplotlib/layouts/_gridplot.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
kushalkolar
kushalkolar commented Apr 7, 2024
View reviewed changes
Comment thread .github/workflows/ci.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
kushalkolar
kushalkolar commented Apr 7, 2024
View reviewed changes
Comment thread fastplotlib/layouts/_gridplot.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
kushalkolar
kushalkolar commented Apr 7, 2024
View reviewed changes
Comment thread fastplotlib/layouts/_gridplot.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
kushalkolar
kushalkolar commented Apr 7, 2024
View reviewed changes
Comment thread fastplotlib/layouts/_gridplot.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
kushalkolar
kushalkolar commented Apr 7, 2024
View reviewed changes
Comment thread tests/test_gridplot.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
clewis7
clewis7 reviewed Apr 9, 2024
View reviewed changes
Comment thread fastplotlib/layouts/_gridplot.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread fastplotlib/layouts/_gridplot.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread fastplotlib/layouts/_gridplot.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clewis7 clewis7 clewis7 left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Directly pass Controller instances to GridPlot

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@kushalkolar @clewis7
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.