GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fpl tests by clewis7 · Pull Request #158 · fastplotlib/fastplotlib

Conversation

@clewis7

@clewis7 clewis7 commented Mar 31, 2023

Copy link
Copy Markdown
Member

refactored so there are no large binary files

did reorg for names

#152

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Caitlin Lewis added 3 commits March 31, 2023 09:31
Caitlin Lewis
refactor tests, no binary files
a51f1cd
Caitlin Lewis
test updates, passing locally
981e3d0
Caitlin Lewis
more tests, all passing locally
b99748c
kushalkolar
kushalkolar requested changes Apr 4, 2023
View reviewed changes
Comment thread examples/gridplot/gridplot_cmap.py

@kushalkolar kushalkolar Apr 4, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we can just keep it to make sure accessing graphics within a gridplot works etc.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread examples/imagewidget/iw_simple.py
data = np.load("../data/random.npy")

iw.show()

@kushalkolar kushalkolar Apr 4, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you test before and after setting timepoint?

set timepoint using the slider as well as @current_index

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@clewis7 clewis7 Apr 5, 2023

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to think some more about testing image widget, somehow need renderer and canvas to be offscreen as in the other examples

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread examples/imagewidget/iw_simple.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread examples/imagewidget/iw_simple.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread examples/scatter/scatter.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread examples/line/present.py
Comment on lines +21 to +23
sine = np.load("../data/sine.npy")
cosine = np.load("../data/cosine.npy")
sinc = np.load("../data/sinc.npy")

@kushalkolar kushalkolar Apr 4, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just make these, don't save them since it's not randomly generated

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@clewis7 clewis7 Apr 4, 2023

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when I didn't save them was when I kept getting errors locally about the data changing...idk what the precision is like when you call np.sin() or np.cos() on a linspace but I think this is what was causing the problem before and that is why I saved them

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@kushalkolar kushalkolar Apr 4, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what if you force float32 when making the linspace?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@clewis7 clewis7 Apr 5, 2023

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will try

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread examples/line/line.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread examples/line/dataslice.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread examples/line/colorslice.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread examples/line/present.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@kushalkolar

kushalkolar commented Apr 4, 2023

Copy link
Copy Markdown
Member

it's not working just through pytest because:

  1. you need an __init__.py in examples/tests
  2. You need relative import for testutils, from .testutils import instead of from testutils import
  3. you need relative paths to data files, for example:
data_path = Path(__file__).parent.parent.joinpath("data", "random.npy")
data = np.load(data_path)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kushalkolar

kushalkolar commented Apr 4, 2023

Copy link
Copy Markdown
Member

Seems like zenodo is still the best place to store these, ah well. The file will be small at least so download time should be very fast.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@clewis7 clewis7 closed this Apr 19, 2023
@kushalkolar

kushalkolar commented Apr 20, 2023

Copy link
Copy Markdown
Member

superseeded by #179
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kushalkolar
kushalkolar deleted the tests branch June 17, 2023 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kushalkolar kushalkolar kushalkolar requested changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@clewis7 @kushalkolar
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.