GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — restarted tests, now work from the command line by clewis7 · Pull Request #179 · fastplotlib/fastplotlib

Conversation

clewis7 commented Apr 19, 2023 •

edited by kushalkolar

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

closes #152

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Caitlin Lewis added 3 commits

April 19, 2023 17:13


          restarted tests, now work from the command line

dd5bc2e


          more tests

97f6f9e


          more tests, still working on iw

kushalkolar mentioned this pull request

Apr 20, 2023

fpl tests #158

Closed

kushalkolar requested changes

Apr 20, 2023

View reviewed changes

Comment thread

.gitignore Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

examples/image/cmap.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

examples/gridplot/gridplot.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

examples/line/colorslice.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

examples/line/dataslice.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

examples/scatter/scatter.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Caitlin Lewis added 2 commits

April 20, 2023 09:25


          ipywidget can only be tested w/ nbmake

4fc8d57


          updated tests

2c9a998

clewis7 commented Apr 20, 2023 •

edited by kushalkolar

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member Author

Graphics
- Image
  - 2D 512x512 rand image which is pre-saved with cmaps
    - changing cmap
  - 2D RGB array, imageio example images
  - changing vmin vmax
- Line
  - sine, cosine, sinc from examples
    - slicing colors, data
    - present followed by auto_scale()
    - fancy indexing, waiting on support numpy fancy indexing for colors and data features #177 merge
- Scatter
  - present
  - dataslice
  - colorslice
  - cmap
- GridPlot
  - simple example constructing gridplot
- upload screenshot test images and diffs if tests failed: see https://github.com/pygfx/pygfx/blob/main/.github/workflows/ci.yml#L132 and https://github.com/actions/upload-artifact
- make sure nbmake runs notebooks in CI pipeline
python 3.9, 3.10, 3.11

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          support numpy fancy indexing for colors and data features (#177)

0ff0d42

kushalkolar requested changes

Apr 28, 2023

View reviewed changes

Comment thread

examples/gridplot/gridplot.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

examples/image/cmap.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

kushalkolar requested changes

Apr 28, 2023

View reviewed changes

Comment thread

examples/image/simple.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

examples/image/vminvmax.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

examples/scatter/scatter_colorslice.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

examples/scatter/scatter_dataslice.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

examples/scatter/scatter_present.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

examples/scatter/scatter_colorslice.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

examples/scatter/scatter_dataslice.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

examples/scatter/scatter_present.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

kushalkolar and others added 2 commits

May 9, 2023 11:58


          type annotation fix for older python versions

5c34539


          adding fancy indexing implemented in #177

4823fec

clewis7 commented May 11, 2023

Copy link

Copy Markdown

Member Author

added the fancy indexing as mentioned in comments, but I left it commented out for now bc my branch is so far behind master...sent you slack ab it

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Caitlin Lewis and others added 14 commits

May 11, 2023 17:37


          requested changes

b2350f3


          adding diff storage for CI pipeline usage

eef74ef


          use readthedocs.yaml for doc build (#189)

9f41382


          tests changes, ready to start CI pipeline

e8c8ac5


          allow for screenshots to be regenerated via os.environ key

78cb8c7


          CI build

43f39ba


          linux-build passes, still working on examples passing

00fd184


          progress on CI pipeline, still need to figure out test build

243e0b6


          still failing test build, what I have for now

4f74c30


          kwargs for Plot and GridPlot to set canvas star size (#194)

9236ff1


          Update ci.yml

f047452

use pygfx before pylinalg refactor


          Update ci.yml

sed to remove pygfx from setup.py


          Update ci.yml

59d33ab

imageio


          Delete requirements_rtd.txt

b244c53

kushalkolar commented May 18, 2023

Copy link

Copy Markdown

Member

We kinda don't need the "just build" test.

Can you make a matrix for the test examples for python versions: https://github.com/pygfx/pygfx/blob/main/.github/workflows/ci.yml#L67-L76

and update the checklist

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          Update ci.yml

d2b4005

testing upload screens

clewis7 commented Jun 6, 2023

Copy link

Copy Markdown

Member Author

yay! CI pipeline...I think

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Caitlin Lewis and others added 26 commits

June 14, 2023 13:13


          track *.png files using Git LFS

b18b1c5


          yml for regenerating screenshots, updating CI yml to not regenerate

42c5221


          update .gitignore and regen screenshots yml

de62e04


          hopefully works

90a0e01


          add screenshots

5c5569d


          remove screenshots from git

035d2d0


          add screenshots, yet again

8ee72f5


          setup options

0950aab


          remove type annotation

81b520a


          change workflow to use setup optiosn

4ac8cc5


          add pyav to setup for tests

a9ee400


          add scikit-image

cbaaf98


          opencv instead of pyav

493b2f5


          add libpng-dev

5edf061


          try pillow, better work ffs

f731b09

bah

494b5af


          add git-lfs to apt install for github actions

5a1c339


          add interactive again

35f5e88


          install git lfs before checkout repo

4bed70a


          add git lfs fetch pull

a8e545f


          diffs

f2202c1


          diffs path

cba928c


          update examples for canvas size and autoscale

80249a7


          remove gpu screenshots


          add screenshot ground truth files from github actions generated scree…

00ed1e0

…nshots


          remove interactive session stuff

6276b28

kushalkolar merged commit a08e84c into master

Jun 14, 2023

kushalkolar commented Jun 14, 2023

Copy link

Copy Markdown

Member

amazing job :D @clewis7

clewis7 reacted with heart emoji

All reactions

❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

kushalkolar deleted the fpl-tests branch

June 17, 2023 06:21

Reviewers

kushalkolar

kushalkolar requested changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

tests

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

clewis7 commented Apr 19, 2023 • edited by kushalkolar Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

clewis7 commented Apr 20, 2023 • edited by kushalkolar Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

clewis7 commented May 11, 2023

Uh oh!

kushalkolar commented May 18, 2023

Uh oh!

clewis7 commented Jun 6, 2023

Uh oh!

kushalkolar commented Jun 14, 2023

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

clewis7 commented Apr 19, 2023 •

edited by kushalkolar

Loading

Uh oh!

There was an error while loading. Please reload this page.

clewis7 commented Apr 20, 2023 •

edited by kushalkolar

Loading

Uh oh!

There was an error while loading. Please reload this page.