GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Sync Subplots by Name by ArjunPutcha · Pull Request #267 · fastplotlib/fastplotlib

Conversation

ArjunPutcha commented Jun 29, 2023

Copy link

Copy Markdown

Collaborator

Currently only done upon initialization. Will work on making this property mutable post-initialization soon.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

ArjunPutcha added 4 commits

June 29, 2023 06:16


          sync subplots by name upon initialization; added example in gridplot_…

c78bcc0

…simple.ipynb


          clear output in nb

a64b841


          small changes. check for self.names and controllers before checking i…

f70da8c

…f controllers has list of strings


          used itertools to remove nested for loop. also modified second if sta…

ff7edfc

…tement to only check if the first element is a str: converting to array should make all elements the same type, inefficient to check all indices

ArjunPutcha linked an issue

Jun 29, 2023

that may be closed by this pull request

sync subsets of controllers in GridPlot using subplot names #218

Closed

kushalkolar requested a review from clewis7

June 29, 2023 19:17

kushalkolar reviewed

Jun 29, 2023

View reviewed changes

Comment thread

examples/notebooks/gridplot_simple.ipynb Resolved

Uh oh!

There was an error while loading. Please reload this page.

ArjunPutcha marked this pull request as draft

June 29, 2023 19:21

clewis7 requested changes

Jun 29, 2023

View reviewed changes

Comment thread

fastplotlib/layouts/_gridplot.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

fastplotlib/layouts/_gridplot.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

fastplotlib/layouts/_gridplot.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

fastplotlib/layouts/_gridplot.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

kushalkolar requested changes

Jun 30, 2023

View reviewed changes

Comment thread

examples/notebooks/gridplot_simple.ipynb Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

fastplotlib/layouts/_gridplot.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

fastplotlib/layouts/_gridplot.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

fastplotlib/layouts/_gridplot.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

fastplotlib/layouts/_gridplot.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

fastplotlib/layouts/_gridplot.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

fastplotlib/layouts/_gridplot.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

fastplotlib/layouts/_gridplot.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

fastplotlib/layouts/_gridplot.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

fastplotlib/layouts/_gridplot.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

ArjunPutcha added 2 commits

July 3, 2023 06:17


          spacing fix

3fce3da


          names is now a default kwarg with value None. Controllers must have s…

5f62258

…ame number of elements as gridplot shape.

ArjunPutcha marked this pull request as ready for review

July 5, 2023 19:30

ArjunPutcha marked this pull request as draft

July 5, 2023 19:30

ArjunPutcha requested review from clewis7 and kushalkolar

July 5, 2023 19:30


          fixed raise ValueError statement. Added comments

96b8247

clewis7 reviewed

Jul 6, 2023

View reviewed changes

clewis7 left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM, maybe just add some code comments here and there so later we know what is happening

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

fastplotlib/layouts/_gridplot.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

kushalkolar mentioned this pull request

Jul 7, 2023

More controllers #280

Closed

kushalkolar commented Jul 7, 2023

Copy link

Copy Markdown

Member

Now that #280 exists, we're going to need to figure out how to consolidate this 😄

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ArjunPutcha commented Jul 7, 2023

Copy link

Copy Markdown

Collaborator Author

Anything you want me to do on my end? Or will you handle it?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

kushalkolar commented Jul 7, 2023 via email

Copy link

Copy Markdown

Member

We'll have to brainstorm a bit, probably at scipy sprint?

…

On Fri, Jul 7, 2023, 10:06 Arjun Putcha ***@***.***> wrote: Anything you want me to do on my end? Or will you handle it? — Reply to this email directly, view it on GitHub <#267 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACHXXRAQVDV4VH6FYJ75OXLXPAJXDANCNFSM6AAAAAAZYZWKGU> . You are receiving this because you commented.Message ID: ***@***.***>

ArjunPutcha reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

kushalkolar mentioned this pull request

Sep 21, 2023

Roadmap Fall 2023 #130

Closed

16 of 17 tasks

kushalkolar mentioned this pull request

Nov 26, 2023

cameras and controllers refactor #382

Merged

kushalkolar commented Nov 26, 2023

Copy link

Copy Markdown

Member

superseeded by #382

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

kushalkolar closed this

Nov 26, 2023

kushalkolar deleted the sync_subplots_name branch

December 10, 2023 05:15

Reviewers

clewis7

clewis7 requested changes

kushalkolar

Awaiting requested review from kushalkolar

kushalkolar is a code owner

+1 more reviewer

ivoflipse

ivoflipse left review comments

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

sync subsets of controllers in GridPlot using subplot names

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.