GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — More controllers by kushalkolar · Pull Request #280 · fastplotlib/fastplotlib

Conversation

@kushalkolar

@kushalkolar kushalkolar commented Jul 7, 2023

Copy link
Copy Markdown
Member
  • adds the new controllers from pygfx:
    • panzoom
    • fly (new)
    • orbit
    • trackball (new)

works properly in simple Plot, needs more thought for GridPlot, especially considering #267

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
kushalkolar added 2 commits July 6, 2023 23:38
@kushalkolar
add more controllers
668cce9
@kushalkolar
new controller options work, nothing broken
ee777c1
@kushalkolar kushalkolar mentioned this pull request Jul 7, 2023
Sync Subplots by Name #267
Closed
@clewis7
clewis7 self-requested a review August 3, 2023 17:47
@clewis7

clewis7 commented Sep 11, 2023

Copy link
Copy Markdown
Member

I know we definitely said to default to a camera based on data dims is not given, so FlyController for 3d and Panzoom for 2d

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ArjunPutcha

ArjunPutcha commented Sep 11, 2023

Copy link
Copy Markdown
Collaborator

Controller_ID - defines controller for each subplot
number of elements must be <= number of elements in grid shape
elements in the same row belong to same controller
elements not listed are by default assigned a unique controller

Controller_type - defines type of controller for each subplot
defined upon initialization, must be same shape as grid_shape.
If not defined, default is 'panzoom' for '2d', and 'flycontroller' for '3d'
Cannot be 'partially' defined. Either define the entire array, or none.

This is what I recall

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@kushalkolar kushalkolar mentioned this pull request Sep 21, 2023
Roadmap Fall 2023 #130
Closed
16 of 17 tasks
@kushalkolar kushalkolar mentioned this pull request Nov 26, 2023
cameras and controllers refactor #382
Merged
@kushalkolar

kushalkolar commented Nov 26, 2023

Copy link
Copy Markdown
Member Author

superseeded by #382

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@kushalkolar kushalkolar closed this Nov 26, 2023
@kushalkolar
kushalkolar deleted the more-controllers branch December 10, 2023 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clewis7 clewis7 Awaiting requested review from clewis7 clewis7 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@kushalkolar @clewis7 @ArjunPutcha
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.