GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Lazy import av by almarklein · Pull Request #432 · fastplotlib/fastplotlib

Conversation

@almarklein

@almarklein almarklein commented Mar 13, 2024

Copy link
Copy Markdown
Collaborator

After #431 I did a review of all imports. I found 2 small interesting cases, which are addressed in this PR:

  • One absolute import of a fastplotlib module.
  • The optional dependency av can easily be lazy-imported (shaving nearly 0.1 off the import time on my machine).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@almarklein
Lazy import av
be4bbc8
kushalkolar
kushalkolar reviewed Mar 13, 2024
View reviewed changes
Comment thread fastplotlib/layouts/_frame/_toolbar.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread fastplotlib/layouts/_record_mixin.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@almarklein
almarklein marked this pull request as ready for review March 14, 2024 08:28
@kushalkolar
kushalkolar merged commit fe74179 into fastplotlib:main Mar 14, 2024
@almarklein
almarklein deleted the av branch March 15, 2024 08:04
@kushalkolar kushalkolar mentioned this pull request Apr 9, 2024
gridplot controllers kwarg is back, other improvements to gp #477
Merged
3 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kushalkolar kushalkolar kushalkolar left review comments
+1 more reviewer
@EricThomson EricThomson EricThomson left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@almarklein @EricThomson @kushalkolar
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.