GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add black to setup in optional feature set for tests by EricThomson · Pull Request #436 · fastplotlib/fastplotlib

Conversation

@EricThomson

@EricThomson EricThomson commented Mar 18, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Closes #435.

Also changes .gitignore, adding VS Code config file.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
EricThomson added 2 commits March 17, 2024 20:29
@EricThomson
ignore vscode config dir
ae72be9
@EricThomson
added black to optional tests install
c60f247
@EricThomson
EricThomson marked this pull request as ready for review March 18, 2024 04:07
@kushalkolar

kushalkolar commented Mar 18, 2024 via email

Copy link
Copy Markdown
Member
Might also be time to add a GitHub action to check for black
…
On Mon, Mar 18, 2024, 00:06 Eric Thomson ***@***.***> wrote: Addresses #435 <#435>. Also changes .gitignore, adding VS Code config file. ------------------------------ You can view, comment on, or merge this pull request online at: #436 Commit Summary - ae72be9 <ae72be9> ignore vscode config dir - c60f247 <c60f247> added black to optional tests install File Changes (2 files <https://github.com/fastplotlib/fastplotlib/pull/436/files>) - *M* .gitignore <https://github.com/fastplotlib/fastplotlib/pull/436/files#diff-bc37d034bad564583790a46f19d807abfe519c5671395fd494d8cce506c42947> (3) - *M* setup.py <https://github.com/fastplotlib/fastplotlib/pull/436/files#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7> (1) Patch Links: - https://github.com/fastplotlib/fastplotlib/pull/436.patch - https://github.com/fastplotlib/fastplotlib/pull/436.diff — Reply to this email directly, view it on GitHub <#436>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACHXXRCW4STSJ44ZPRLQQD3YYZR6DAVCNFSM6AAAAABE22QLQKVHI2DSMVQWIX3LMV43ASLTON2WKOZSGE4TCMJYGM2DSNA> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
almarklein reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@EricThomson
added black linting to ci
3c8f0cd
kushalkolar
kushalkolar requested changes Mar 18, 2024
View reviewed changes
Comment thread .github/workflows/ci.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
EricThomson added 4 commits March 18, 2024 15:05
@EricThomson
fix syntax in black linter ci.yml
8029fa2
@EricThomson
add black.yml to workflows
62dc185
@EricThomson
transition from node16 to node20
400fcbd
@EricThomson
add jupyter to black workflow
0521842
@EricThomson

EricThomson commented Mar 19, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

At point now where not sure if black.yml is ok and finding problems in code, or it is still bad.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kushalkolar

kushalkolar commented Mar 19, 2024

Copy link
Copy Markdown
Member

ok so we need to black our nbs too 😆
EricThomson reacted with laugh emoji
All reactions
  • 😄 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
kushalkolar
kushalkolar requested changes Mar 20, 2024
View reviewed changes

@kushalkolar kushalkolar left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one last thing and should be good to go! :D

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread .github/workflows/black.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
@EricThomson
direct linter to source
ea4292a
kushalkolar
kushalkolar approved these changes Mar 20, 2024
View reviewed changes
@kushalkolar
kushalkolar merged commit 576ccbf into fastplotlib:main Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kushalkolar kushalkolar kushalkolar approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Should black be in setup.py optional deps for tests?

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@EricThomson @kushalkolar
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.