GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — update for changes in pygfx@main by clewis7 · Pull Request #443 · fastplotlib/fastplotlib

Conversation

@clewis7

@clewis7 clewis7 commented Mar 21, 2024

Copy link
Copy Markdown
Member

Should update to most recent changes in pygfx

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@clewis7
update points material kwarg
13472ec
@clewis7
clewis7 marked this pull request as ready for review March 21, 2024 16:55
@clewis7

clewis7 commented Mar 21, 2024

Copy link
Copy Markdown
Member Author

@kushalkolar do we need to update screenshots as well?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Caitlin Lewis
update scatter examples & screenshots
f67f524
@almarklein

almarklein commented Mar 22, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

do we need to update screenshots as well?

To provide some context: we improved the points shader to consolidated the API, add support to express sizes in world/model space, and improve the shader code, making it more similar to the line shader. As part of that, the points are a tiny bit bigger, to counter for the edge we need to do anti-aliasing, so that aa and no-aa points look equally big.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
clewis7 added 3 commits March 22, 2024 20:54
@clewis7
update screenshots
fb49553
@clewis7
update screenshots
d82cce5
@clewis7
I am so silly
8d2d345
@kushalkolar
kushalkolar merged commit fb8aedc into main Mar 23, 2024
@kushalkolar
kushalkolar deleted the pygfx-update branch March 23, 2024 01:17
clewis7 added a commit that referenced this pull request Mar 23, 2024
@clewis7
update for changes in pygfx@main (#443)
ff9b7db 
* update points material kwarg

* update scatter examples & screenshots
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@clewis7 @almarklein @kushalkolar
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.