GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — update contributing guide by clewis7 · Pull Request #580 · fastplotlib/fastplotlib

Conversation

@clewis7

@clewis7 clewis7 commented Aug 5, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Start to update the contributing guide

  • more detailed instructions on contributing
  • move specific information about fpl API to developer notes section in the docs
    • graphics
    • graphic features
    • layouts

will wait to add developer notes for other parts of the API later when they are more stable

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
clewis7 added 6 commits August 5, 2024 16:32
@clewis7
update contributing guide
21dcd4a
@clewis7
start developer notes
72b523f
@clewis7
more contributing updates
9c55b9d
@clewis7
start to make developer notes
bbdbfe0
@clewis7
reorganize some
e0b9ed5
@clewis7
dev notes
68f1da8
@clewis7
clewis7 marked this pull request as ready for review September 17, 2024 16:26
@clewis7
clewis7 requested a review from kushalkolar as a code owner September 17, 2024 16:26
@clewis7
Merge branch 'main' into update_contrib
886e8ee
kushalkolar
kushalkolar requested changes Sep 17, 2024
View reviewed changes
Comment thread CONTRIBUTING.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread CONTRIBUTING.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread CONTRIBUTING.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread CONTRIBUTING.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread CONTRIBUTING.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread CONTRIBUTING.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread CONTRIBUTING.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread CONTRIBUTING.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread CONTRIBUTING.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread CONTRIBUTING.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

@clewis7
requested changes
62f5dd1
@clewis7
clewis7 marked this pull request as draft September 27, 2024 18:51
@clewis7
add layouts, fix toctree issue
c617635
kushalkolar
kushalkolar requested changes Sep 29, 2024
View reviewed changes

@kushalkolar kushalkolar left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few very minor things and then good to go! 🥳

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread docs/source/developer_notes/graphics.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread docs/source/developer_notes/graphics.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread docs/source/developer_notes/graphics.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread docs/source/developer_notes/graphics.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread docs/source/developer_notes/graphics.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread docs/source/developer_notes/layouts.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread docs/source/developer_notes/layouts.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread docs/source/developer_notes/layouts.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread docs/source/developer_notes/layouts.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

@kushalkolar
kushalkolar marked this pull request as ready for review September 29, 2024 03:00
@kushalkolar

kushalkolar commented Oct 7, 2024

Copy link
Copy Markdown
Member

@clewis7 after addressing these and once #639 is in main we can rebase this onto main. And then what do you think about add a few base classes like Graphic, FeatureEvent, BufferManager etc to the API docs since that's useful for devs.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@clewis7 clewis7 mentioned this pull request Oct 24, 2024
update contrib guide, add developer notes #667
Merged
@clewis7

clewis7 commented Oct 24, 2024

Copy link
Copy Markdown
Member Author

superseded by #667

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@clewis7 clewis7 closed this Oct 24, 2024
@clewis7
clewis7 deleted the update_contrib branch October 24, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kushalkolar kushalkolar kushalkolar requested changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@clewis7 @kushalkolar
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.