GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — update contrib guide, add developer notes by clewis7 · Pull Request #667 · fastplotlib/fastplotlib

Conversation

@clewis7

@clewis7 clewis7 commented Oct 24, 2024

Copy link
Copy Markdown
Member

supersedes #580

Because something wonky happened with the iris dataset and all of the changes with imgui, it was easier to just open a new PR for this

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@clewis7
new pr for contrib guide
18f65de
@clewis7 clewis7 mentioned this pull request Oct 24, 2024
update contributing guide #580
Closed
5 tasks done
@clewis7
clewis7 marked this pull request as ready for review October 24, 2024 15:29
@clewis7
clewis7 requested a review from kushalkolar as a code owner October 24, 2024 15:29
@clewis7
fix warning
1fcc8ea
@github-actions

github-actions Bot commented Oct 24, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

📚 Docs preview built and uploaded! https://www.fastplotlib.org/ver/contrib-guide
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kushalkolar

kushalkolar commented Oct 24, 2024

Copy link
Copy Markdown
Member

Some formatting issues and also add the developer docs as a separate dir, like user guide, and have a toc page with the graphics and plotarea in the toctree
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
clewis7 added 2 commits October 24, 2024 16:26
@clewis7
fix formatting issues
dceb0c5
@clewis7
reformat
168533d
kushalkolar
kushalkolar requested changes Oct 25, 2024
View reviewed changes
Comment thread docs/source/developer_notes/graphics.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
clewis7
clewis7 commented Oct 25, 2024
View reviewed changes
Comment thread docs/source/developer_notes/graphics.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@clewis7
Update docs/source/developer_notes/graphics.rst
c0c1240
kushalkolar
kushalkolar requested changes Oct 25, 2024
View reviewed changes
Comment thread CONTRIBUTING.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread CONTRIBUTING.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
clewis7
clewis7 commented Oct 25, 2024
View reviewed changes
Comment thread CONTRIBUTING.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
clewis7
clewis7 commented Oct 25, 2024
View reviewed changes
Comment thread CONTRIBUTING.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@clewis7
Apply suggestions from code review
e1fe63b
kushalkolar
kushalkolar approved these changes Oct 25, 2024
View reviewed changes
@clewis7
clewis7 merged commit 7a0e40f into main Oct 25, 2024
@clewis7
clewis7 deleted the contrib-guide branch October 25, 2024 21:28
FlynnOConnell pushed a commit to FlynnOConnell/fastplotlib that referenced this pull request Jan 7, 2025
@clewis7 @FlynnOConnell
update contrib guide, add developer notes (fastplotlib#667)
8fbb940 
* new pr for contrib guide

* fix warning

* fix formatting issues

* reformat

* Update docs/source/developer_notes/graphics.rst

* Apply suggestions from code review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kushalkolar kushalkolar kushalkolar approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@clewis7 @kushalkolar
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.