GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — remove ipywidget code from selectors and cleanup docstrings by kushalkolar · Pull Request #644 · fastplotlib/fastplotlib

Conversation

@kushalkolar

@kushalkolar kushalkolar commented Oct 8, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

since we've not switched to imgui we shouldn't have any GUI specific code in the core library, this really cleans up the selectors 😄

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@kushalkolar
kushalkolar marked this pull request as ready for review October 8, 2024 15:22
@kushalkolar
kushalkolar requested a review from clewis7 as a code owner October 8, 2024 15:22
@kushalkolar

kushalkolar commented Oct 8, 2024

Copy link
Copy Markdown
Member Author

Forgot to regen API docs, I really need to use precommit
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
kushalkolar added 4 commits October 16, 2024 23:20
@kushalkolar
remove ipywidget code from linear selector and cleanup docstrings
888f0e8
@kushalkolar
remove ipywidget code from LinearRegionSelector, cleanup docstrings
01d2be6
@kushalkolar
remove a method
9e416fb
@kushalkolar
update API docs
4660257
@kushalkolar
kushalkolar force-pushed the remove-ipywidget-code branch from 33fad93 to 4660257 Compare October 17, 2024 03:22
@github-actions

github-actions Bot commented Oct 17, 2024

Copy link
Copy Markdown

📚 Docs preview built and uploaded! https://www.fastplotlib.org/ver/remove-ipywidget-code
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kushalkolar

kushalkolar commented Oct 17, 2024

Copy link
Copy Markdown
Member Author

@clewis7 gtg after review, I removed ipywidget code within the selectors but I also cleaned up the docstrings, there were some remnants stating "slider" from over a year ago.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
clewis7
clewis7 approved these changes Oct 17, 2024
View reviewed changes

@clewis7 clewis7 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I don't know if you want to do this in this PR or a different PR but we had talked about making fill_color, vertex_color, and edge_color properties (re: issue with kevin's viz when changing the selector colors and then events set them back to original)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@kushalkolar

kushalkolar commented Oct 17, 2024

Copy link
Copy Markdown
Member Author

Let's do that separately
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@clewis7
clewis7 merged commit eb4b3f8 into main Oct 18, 2024
@kushalkolar
kushalkolar deleted the remove-ipywidget-code branch October 18, 2024 12:34
FlynnOConnell pushed a commit to FlynnOConnell/fastplotlib that referenced this pull request Jan 7, 2025
@kushalkolar @FlynnOConnell
remove ipywidget code from selectors and cleanup docstrings (fastplot…
b8ae851 
…lib#644)

* remove ipywidget code from linear selector and cleanup docstrings

* remove ipywidget code from LinearRegionSelector, cleanup docstrings

* remove a method

* update API docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clewis7 clewis7 clewis7 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@kushalkolar @clewis7
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.