GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — updates related to upstream changes by kushalkolar · Pull Request #687 · fastplotlib/fastplotlib

Conversation

@kushalkolar

@kushalkolar kushalkolar commented Dec 25, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This PR catches up with a number of upstream changes:

  • use imageio[ffmpeg] instead of pyav #686
  • fix typo in the requested limit name of the wgpu device #679
  • uses Introduce TextureMap pygfx/pygfx#889
  • We no longer need to filter events from imgui render areas because of Prevent UI events from propagating beyond imgui pygfx/wgpu-py#569
  • migrate to rendercanvas
  • closes Optional package imgui-bundle is now mandatory #677 , ImageWidget is imported only if imgui is installed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
kushalkolar and others added 2 commits December 24, 2024 23:35
@kushalkolar
use imageio[ffmpeg] instead of pyav (#686)
5c12b36
@jcafhe @kushalkolar
fix typo in the requested limit name of the wgpu device (#679)
0937309 
* fix typo in the requested limit name of the wgpu device.

* fix test config.

* fix examples/test and docs

* fix max-texture-dimension-2d limit name and replace underscore by hyphen for the other limits.

* fix missing dependency (libxrandr) to compile GLFW during building wheel for imgui-bundle.

* update CI timeout

* update timeout in non-nb test job

---------

Co-authored-by: Kushal Kolar <[email protected]>
@kushalkolar
kushalkolar requested a review from clewis7 as a code owner December 25, 2024 04:38
@kushalkolar kushalkolar changed the title Extinguish fires updates related to upstream changes Dec 25, 2024
kushalkolar added 2 commits December 25, 2024 06:22
@kushalkolar
update to use pygfx.TextureMap
298b76e
@kushalkolar
forgot to set imageio[ffmpeg] for all extras
84192fc
@kushalkolar

kushalkolar commented Dec 25, 2024

Copy link
Copy Markdown
Member Author

doc failure is because the pygfx gallery scraper now checks for BaseRenderCanvas instead of WgpuCanvas. Anyways wgpu.gui is going to be dropped soon so we should update things to use rendercanvas instead.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kushalkolar
migrate to RenderCanvas, remove event_filter stuff for imgui since th…
df9b7fa 
…at was fixed in pygfx
kushalkolar
kushalkolar commented Dec 26, 2024
View reviewed changes
Comment thread fastplotlib/layouts/_figure.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
kushalkolar
kushalkolar commented Dec 26, 2024
View reviewed changes
Comment thread fastplotlib/layouts/_utils.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
kushalkolar added 6 commits December 26, 2024 04:12
@kushalkolar
remove very old irrelevant example
17a9233
@kushalkolar
fix docstring
15764c9
@kushalkolar
update examples to use fpl.loop.run()
dad91b9
@kushalkolar
update API docs
62e9097
@kushalkolar
black
82b0614
@kushalkolar
import ImageWidget only if imgui is installed
4daa293
@github-actions

github-actions Bot commented Dec 26, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

📚 Docs preview built and uploaded! https://www.fastplotlib.org/ver/extinguish-fires
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
kushalkolar added 2 commits December 26, 2024 05:02
@kushalkolar
enumerate_adapters() -> enumerate_adapters_sync()
c8e97ca
@kushalkolar
remove annoying warnings from cmap
5b2e3e8
@kushalkolar

kushalkolar commented Dec 26, 2024

Copy link
Copy Markdown
Member Author

I think the current failures in the nb tests might be due to changes in the latest jupyterlab
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kushalkolar

kushalkolar commented Dec 26, 2024

Copy link
Copy Markdown
Member Author

I figured it out, since the starting size of the jupyter canvas is (0, 0) we get blank screenshots until the second screenshot is requested. But then that second screenshot is not sized correctly so I think it's processing events or something. If pygfx/rendercanvas#50 is merged then this will be fixed.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kushalkolar kushalkolar mentioned this pull request Dec 26, 2024
WIP: Pygfx histogram pyapp-kit/ndv#76
Closed
7 tasks
kushalkolar added 2 commits January 2, 2025 12:40
@kushalkolar
remove more cmap warnings
a7216ea
@kushalkolar
black
705d94c
@kushalkolar

kushalkolar commented Jan 2, 2025

Copy link
Copy Markdown
Member Author

waiting for next release of rendercanvas with pygfx/rendercanvas#50 . Tests passing locally with latest rendercanvas on main.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kushalkolar

kushalkolar commented Jan 5, 2025

Copy link
Copy Markdown
Member Author

@clewis7 ready for review!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
clewis7
clewis7 approved these changes Jan 6, 2025
View reviewed changes

@clewis7 clewis7 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't tell just from looking at the diffs... What is the reason for the change from fpl.run() to fpl.loop.run()? Because we are using rendercanvas now?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread .github/workflows/ci.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
@clewis7
clewis7 merged commit 07053e7 into main Jan 6, 2025
@clewis7
clewis7 deleted the extinguish-fires branch January 6, 2025 14:06
FlynnOConnell pushed a commit to FlynnOConnell/fastplotlib that referenced this pull request Jan 7, 2025
@kushalkolar @jcafhe @FlynnOConnell
updates related to upstream changes (fastplotlib#687)
c537ae6 
* use imageio[ffmpeg] instead of pyav (fastplotlib#686)

* fix typo in the requested limit name of the wgpu device (fastplotlib#679)

* fix typo in the requested limit name of the wgpu device.

* fix test config.

* fix examples/test and docs

* fix max-texture-dimension-2d limit name and replace underscore by hyphen for the other limits.

* fix missing dependency (libxrandr) to compile GLFW during building wheel for imgui-bundle.

* update CI timeout

* update timeout in non-nb test job

---------

Co-authored-by: Kushal Kolar <[email protected]>

* update to use pygfx.TextureMap

* forgot to set imageio[ffmpeg] for all extras

* migrate to RenderCanvas, remove event_filter stuff for imgui since that was fixed in pygfx

* remove very old irrelevant example

* fix docstring

* update examples to use fpl.loop.run()

* update API docs

* black

* import ImageWidget only if imgui is installed

* enumerate_adapters() -> enumerate_adapters_sync()

* remove annoying warnings from cmap

* remove more cmap warnings

* black

---------

Co-authored-by: Jérémie Fache <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clewis7 clewis7 clewis7 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Optional package imgui-bundle is now mandatory

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@kushalkolar @clewis7 @jcafhe
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.