GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — update screenshot by kushalkolar · Pull Request #700 · fastplotlib/fastplotlib

Conversation

@kushalkolar

@kushalkolar kushalkolar commented Jan 21, 2025

Copy link
Copy Markdown
Member

my hunch is this is due to pygfx/pygfx#945

when set_data() is used, it wouldn't immediately update the camera related stuff which is why the axes don't appear on the initial draw after set_data(), as a user we don't notice it because that draw only lasts for a few milliseconds.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@kushalkolar
update screenshot
f5acbc7
@kushalkolar
kushalkolar requested a review from clewis7 as a code owner January 21, 2025 07:03
@kushalkolar

kushalkolar commented Jan 21, 2025

Copy link
Copy Markdown
Member Author

@clewis7 this should fix the current CI failure
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions

github-actions Bot commented Jan 21, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

📚 Docs preview built and uploaded! https://www.fastplotlib.org/ver/fix-screenshot
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kushalkolar
I am too restrictive lol
94a5d60
@kushalkolar

kushalkolar commented Jan 21, 2025

Copy link
Copy Markdown
Member Author

I also changed the CI timeout from 10 mins to 15, for whatever reason it took llvmpipe etc. 7 mins to install. Maybe something changed on github actions 🤷‍♂️ . Anyways jobs usually finish in 5 mins, maybe stuff gets cached so if it hits a new machine or something it takes longer.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kushalkolar kushalkolar mentioned this pull request Jan 21, 2025
Update ci step #701
Merged
@kushalkolar
fine 25 min timeout
c3898c2
@kushalkolar

kushalkolar commented Jan 21, 2025

Copy link
Copy Markdown
Member Author

idk what's taking so long with apt install on github actions lately, relaxed the timeout time to 25 mins 🤷‍♂️
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kushalkolar

kushalkolar commented Jan 21, 2025

Copy link
Copy Markdown
Member Author

wtf, so now all the jobs finished within 5mins?? Must be some caching things or apt servers were slow for some reason during those earlier runs
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
clewis7
clewis7 approved these changes Jan 21, 2025
View reviewed changes
@clewis7
clewis7 merged commit 959006e into main Jan 21, 2025
@clewis7
clewis7 deleted the fix-screenshot branch January 21, 2025 14:53
@kushalkolar kushalkolar mentioned this pull request Jan 25, 2025
add job that uses release version of pygfx #706
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clewis7 clewis7 clewis7 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@kushalkolar @clewis7
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.