GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — add job that uses release version of pygfx by kushalkolar · Pull Request #706 · fastplotlib/fastplotlib

Conversation

@kushalkolar

@kushalkolar kushalkolar commented Jan 25, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

closes #702

see this comment #706 (comment)

Instead of adding it to the matrix I just made a new identical job so we can use the branch protection rules instead of the more complicated check and message system linked in that issue

Will see if this works, I've set "Test Linux" (which uses pygfx@main) as a required status check that must pass for a PR to be merged and I wonder if that will cover the entire matrix for that job. "Test Linux pygfx release" is however not required to pass.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@kushalkolar
add job that uses release version of pygfx
50eb7ca
@kushalkolar
kushalkolar requested a review from clewis7 as a code owner January 25, 2025 01:42
@kushalkolar
Update ci.yml
c333576
@github-actions

github-actions Bot commented Jan 25, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

📚 Docs preview built and uploaded! https://www.fastplotlib.org/ver/test-pygfx-pypi

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@kushalkolar

kushalkolar commented Jan 25, 2025

Copy link
Copy Markdown
Member Author

ImageWidget.set_data() screenshot test is failing due to #700 , this isn't a release blocker.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@kushalkolar
too complicated, just add pygfx release/main to matrix
ff67eff
@kushalkolar

kushalkolar commented Jan 25, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

ok this was getting too complicated, let's just add pygfx-release/main to the matrix and during PRs we just manually look at the job statuses and determine if we want to merge or not based on any pygfx-release failures. This is only really necessary until pygfx stabilizes so we don't want to spend too much effort making a complicated thing that's only for this temporary phase of developement

@clewis7 what do you think?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@kushalkolar
other way around
a6a816f
@kushalkolar

kushalkolar commented Jan 25, 2025

Copy link
Copy Markdown
Member Author

@clewis7 ready for review!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@clewis7

clewis7 commented Jan 25, 2025

Copy link
Copy Markdown
Member

ok this was getting too complicated, let's just add pygfx-release/main to the matrix and during PRs we just manually look at the job statuses and determine if we want to merge or not based on any pygfx-release failures. This is only really necessary until pygfx stabilizes so we don't want to spend too much effort making a complicated thing that's only for this temporary phase of developement

@clewis7 what do you think?

But will having the CI badge as failing look bad? I feel like that's something I look at when I look at a repo 😳

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

clewis7
clewis7 approved these changes Jan 25, 2025
View reviewed changes
@kushalkolar

kushalkolar commented Jan 25, 2025

Copy link
Copy Markdown
Member Author

But will having the CI badge as failing look bad? I feel like that's something I look at when I look at a repo 😳

True, we can remove the CI badge for now?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@clewis7

clewis7 commented Jan 25, 2025

Copy link
Copy Markdown
Member

But will having the CI badge as failing look bad? I feel like that's something I look at when I look at a repo 😳

True, we can remove the CI badge for now?

But does that also look bad? I can't decide what the best optics are lol

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@kushalkolar

kushalkolar commented Jan 25, 2025

Copy link
Copy Markdown
Member Author

But will having the CI badge as failing look bad? I feel like that's something I look at when I look at a repo 😳

True, we can remove the CI badge for now?

But does that also look bad? I can't decide what the best optics are lol

pygfx seems like it'll stabilize over the coming months, it's fine for now I think.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@kushalkolar

kushalkolar commented Jan 25, 2025

Copy link
Copy Markdown
Member Author

was too complicated to figure out alternatives and not worth it for something temporary

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@clewis7
clewis7 merged commit 9ea662f into main Jan 25, 2025
@clewis7
clewis7 deleted the test-pygfx-pypi branch January 25, 2025 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clewis7 clewis7 clewis7 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Also test using latest pygfx on pypi

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@kushalkolar @clewis7
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.