GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — thinner lines for Linear and LinearRegion selectors, fully transparent thick outer lines as hitboxes by kushalkolar · Pull Request #904 · fastplotlib/fastplotlib

Conversation

@kushalkolar

@kushalkolar kushalkolar commented Sep 29, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

After the alpha refactor by @almarklein this is finally possible! I think this looks much better, the width of the outer transparent line is a kwarg hitbox_width

linear-2025-09-29_03.30.43.mp4
linear_region-2025-09-29_03.38.24.mp4

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
almarklein reacted with hooray emoji
All reactions
  • 🎉 1 reaction
@kushalkolar
thinner lines for Linear and LinearRegion selectors, fully transparen…
6929e6d 
…t thick outer line serves as a hitbox
@kushalkolar kushalkolar mentioned this pull request Sep 29, 2025
Picking small objects when the pointer is near instead of directly on the object pygfx/pygfx#1096
Open
@kushalkolar
kushalkolar requested a review from almarklein September 29, 2025 07:51
@kushalkolar
use default for hlut
98a5520
almarklein
almarklein reviewed Sep 29, 2025
View reviewed changes
Comment thread fastplotlib/graphics/selectors/_linear.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
almarklein
almarklein reviewed Sep 29, 2025
View reviewed changes
Comment thread fastplotlib/graphics/selectors/_base_selector.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
almarklein
almarklein reviewed Sep 29, 2025
View reviewed changes
Comment thread fastplotlib/graphics/selectors/_linear_region.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@kushalkolar

kushalkolar commented Sep 29, 2025

Copy link
Copy Markdown
Member Author

@almarklein do you think this is overall the right approach here after your alpha refactor?
almarklein reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
kushalkolar and others added 4 commits September 29, 2025 07:41
@kushalkolar @almarklein
Update fastplotlib/graphics/selectors/_base_selector.py
dcecf0a 
Co-authored-by: Almar Klein <[email protected]>
@kushalkolar
review comments
53b586a
@kushalkolar
Merge branch 'better-selector-handles' of https://github.com/fastplot…
d3f3d10 
…lib/fastplotlib into better-selector-handles
@kushalkolar
black
6db5ca2
@kushalkolar
kushalkolar marked this pull request as ready for review September 30, 2025 07:53
@kushalkolar
kushalkolar requested a review from clewis7 as a code owner September 30, 2025 07:53
This was referenced Oct 1, 2025
Allow use of add_*_selector methods in ScatterGraphic #883
Closed
add ImageVolumeGraphic #791
Merged
clewis7
clewis7 previously approved these changes Oct 3, 2025
View reviewed changes
@clewis7

clewis7 commented Oct 3, 2025

Copy link
Copy Markdown
Member

docs are failing? and some of the tests should be passing no?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
kushalkolar added 2 commits October 5, 2025 23:48
@kushalkolar
fix
d08a448
@kushalkolar
Merge branch 'main' into better-selector-handles
1bfa6d3
@kushalkolar
kushalkolar dismissed clewis7’s stale review via 1bfa6d3 October 6, 2025 03:52
@github-actions

github-actions Bot commented Oct 6, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

📚 Docs preview built and uploaded! https://www.fastplotlib.org/ver/better-selector-handles
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
kushalkolar added 2 commits October 6, 2025 00:28
@kushalkolar
replace screenshots
cccfc2c
@kushalkolar
update example docstrings
4c94dc4
@kushalkolar

kushalkolar commented Oct 6, 2025

Copy link
Copy Markdown
Member Author

all non-release tests passing
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kushalkolar kushalkolar mentioned this pull request Oct 9, 2025
Adjust for PyGfx's new ticks #910
Merged
@kushalkolar

kushalkolar commented Oct 10, 2025

Copy link
Copy Markdown
Member Author

Merge conflict in the lfs files O_O. I'm going to copy this over to a new PR before we discover novel ways to get git lfs smudge errors, @FlynnOConnell
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kushalkolar kushalkolar mentioned this pull request Oct 11, 2025
thinner selectors #914
Merged
@kushalkolar

kushalkolar commented Oct 11, 2025

Copy link
Copy Markdown
Member Author

superseeded by #914, I don't want to risk a git lfs error again with a merge conflict in an lfs pointer (how tf does that even happen?!? 😨 )
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kushalkolar kushalkolar closed this Oct 11, 2025
@kushalkolar
kushalkolar deleted the better-selector-handles branch October 14, 2025 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@almarklein almarklein almarklein left review comments
@clewis7 clewis7 clewis7 left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@kushalkolar @clewis7 @almarklein
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.