GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Adjust for PyGfx's new ticks by almarklein · Pull Request #910 · fastplotlib/fastplotlib

Conversation

@almarklein

@almarklein almarklein commented Oct 9, 2025

Copy link
Copy Markdown
Collaborator

A lot of screenshots in fpl will need to be updated because of this upstream change.

By changing tick_marker and tick_size, we can also get this, let me know what you prefer:

image

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@almarklein
Adjust for PyGfx's new ticks
de9441c
@almarklein
almarklein requested review from clewis7 and kushalkolar as code owners October 9, 2025 07:52
@github-actions

github-actions Bot commented Oct 9, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

📚 Docs preview built and uploaded! https://www.fastplotlib.org/ver/tickmarks
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
kushalkolar
kushalkolar reviewed Oct 9, 2025
View reviewed changes
Comment thread fastplotlib/graphics/_axes.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread fastplotlib/graphics/_axes.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@kushalkolar

kushalkolar commented Oct 9, 2025

Copy link
Copy Markdown
Member

Nice! I think keep the both sided ticks
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
almarklein added 3 commits October 9, 2025 23:21
@almarklein
put tick_mark in generic dict
4322cd8
@almarklein
new screenshots
ba3a5fb
@almarklein
bump pygfx
5dea376
kushalkolar
kushalkolar approved these changes Oct 9, 2025
View reviewed changes
@kushalkolar

kushalkolar commented Oct 9, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Let's merge this and then rebase #906 on main, and then update screenshots later? Because the selector line thickness has changed in #904 and has to be merged too which changes screenshots 😅 . Or create a temporary "dev" branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@almarklein

almarklein commented Oct 10, 2025

Copy link
Copy Markdown
Collaborator Author

Let's merge this and then rebase #906 on main, and then update screenshots later?

I mostly created this to update the screenshots due to the new PyGfx 😅, so that the new screenshots in #906 were only for the changes in that pr. But yeah, we should get things merged one way or another.

Regarding the screenshots, one thing I don't understand is that that in a screenshots-build like this one, there's two artifacts, which both contain all screenshots that are also in the repo (via LFS). Which one should I pick?

BTW: Is the imgui bump in Pygfx / wgpu a problem for FPL?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kushalkolar

kushalkolar commented Oct 10, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Regarding the screenshots, one thing I don't understand is that that in a screenshots-build like this one, there's two artifacts, which both contain all screenshots that are also in the repo (via LFS). Which one should I pick?

So one is supposed to have screenshots that have imgui elements (such as the toolbar), and the other is supposed to have screenshots without imgui elements (to make sure that everything still functions correctly without the optional imgui install). But now I realize that the imgui screenshots still get uploaded even in the non-imgui artifact because they exist in that dir. So in the screenshot regenerate action I should add a rm examples/screenshots before generating the screenshots.

BTW: Is the imgui bump in Pygfx / wgpu a problem for FPL?

Nope! I updated the fonts changes here: f1746be

And now in optional dependencies I let wgpu handle imgui version:

fastplotlib/pyproject.toml

Line 60 in 6a0d3b3

imgui = ["wgpu[imgui]"]

I wonder if it would make sense to do this for pygfx too?
almarklein reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kushalkolar
kushalkolar merged commit 75ff892 into main Oct 10, 2025
@kushalkolar
kushalkolar deleted the tickmarks branch October 10, 2025 23:31
@almarklein

almarklein commented Oct 11, 2025

Copy link
Copy Markdown
Collaborator Author

I wonder if it would make sense to do this for pygfx too?

PyGfx does not depend on imgui; only some examples do.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kushalkolar

kushalkolar commented Oct 11, 2025

Copy link
Copy Markdown
Member

I wonder if it would make sense to do this for pygfx too?

PyGfx does not depend on imgui; only some examples do.

It's an optional dependency:

https://github.com/pygfx/pygfx/blob/37cdd2664020c52380e44fc37c43129882b76f4d/pyproject.toml#L43

Might be better to let wgpu handle it?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@almarklein

almarklein commented Oct 11, 2025

Copy link
Copy Markdown
Collaborator Author

Ah, I see what you mean now. Yeah, would be nice to use wgpu[imgui] in pygfx/pyproject.toml too.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kushalkolar kushalkolar mentioned this pull request Oct 19, 2025
New screenshots :D #919
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kushalkolar kushalkolar kushalkolar approved these changes
@clewis7 clewis7 Awaiting requested review from clewis7 clewis7 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@almarklein @kushalkolar
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.