GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — mesh with graphic features by kushalkolar · Pull Request #954 · fastplotlib/fastplotlib

Conversation

kushalkolar commented Nov 29, 2025

Copy link

Copy Markdown

Member

@almarklein wanted to get your thoughts on this before I add it to #953

It adds to your implementation by adding properties and graphic features

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          mesh with gfeatures

af1bd57

kushalkolar requested a review from clewis7 as a code owner

November 29, 2025 22:31

kushalkolar marked this pull request as draft

November 29, 2025 22:31


          surface graphic works

084bed0

kushalkolar marked this pull request as ready for review

November 30, 2025 11:18

kushalkolar commented

Nov 30, 2025

View reviewed changes

Comment thread

fastplotlib/graphics/features/_mesh.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

fastplotlib/graphics/features/_mesh.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

fastplotlib/graphics/features/_mesh.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

kushalkolar commented Nov 30, 2025 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member Author

made some examples with animations too, including ones that change the data. Positions and indices are just recomputed. Not sure if there's a better way.

ripple-2025-11-30_06.24.34.mp4

got the earth to rotate on it's tilted axis 😄

earth-2025-11-30_06.25.07.mp4

ellipsoid-2025-11-30_07.10.03.mp4

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

kushalkolar commented

Nov 30, 2025

View reviewed changes

Comment thread

fastplotlib/graphics/features/_mesh.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

kushalkolar added 2 commits

November 30, 2025 23:43


          update, add PolygonGraphic, works

d4d36c6


          black

ad51df6

kushalkolar mentioned this pull request

Dec 1, 2025

Add support for mesh and surface #953

Merged

6 tasks done

kushalkolar added 6 commits

November 30, 2025 23:49


          for docs and test screenshots

db46af3


          black

3f66659


          polygon data updating works

3ee8c57


          update

f96aa31


          black

bde23b3


          more examples

2dd7524

kushalkolar commented Dec 1, 2025

Copy link

Copy Markdown

Member Author

was easy to add PolygonGraphic as a subclass of MeshGraphic 😄

poly_anim-2025-12-01_00.35.27.mp4

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

kushalkolar mentioned this pull request

Dec 1, 2025

Create a new buffer if necessary when setting an existing Graphic #869

Closed


          update add_graphic mixin

e8cfce2

kushalkolar commented

Dec 1, 2025

View reviewed changes

kushalkolar left a comment

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done with the additions and also added PolygonGraphic, let me know what you think :D

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

fastplotlib/graphics/features/_base.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

fastplotlib/graphics/mesh.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

fastplotlib/layouts/_graphic_methods_mixin.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

almarklein reviewed

Dec 1, 2025

View reviewed changes

Comment thread

fastplotlib/graphics/features/_mesh.py

Comment on lines +80 to +81

		if data.shape == (3,):
		pass

almarklein Dec 1, 2025

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

almarklein Dec 1, 2025

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a single triangle?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

kushalkolar Dec 2, 2025

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was also confused by this, I interpreted it from here in the polygon selector:

fastplotlib/fastplotlib/graphics/features/_selection_features.py

Lines 412 to 415 in 2a430f8

	if len(value) >= 3:
	indices = triangulate(value)
	else:
	indices = np.zeros((0, 3), np.int32)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

almarklein Dec 3, 2025

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but that shape is still (0, 3), not (3, ), right?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

almarklein reviewed

Dec 1, 2025

View reviewed changes

Comment thread

fastplotlib/graphics/features/_mesh.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

almarklein reviewed

Dec 1, 2025

View reviewed changes

Comment thread

fastplotlib/graphics/mesh.py

		_features = {
		"positions": VertexPositions,
		"indices": BufferManager,
		"mapcoords": (BufferManager, None),

almarklein Dec 1, 2025

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was the mapcoords feature removed intentionally? I can see it being useful.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

almarklein Dec 1, 2025

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I don't properly understand features vs normal properties.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

almarklein reviewed

Dec 1, 2025

View reviewed changes

Comment thread

fastplotlib/graphics/mesh.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

almarklein reviewed

Dec 1, 2025

View reviewed changes

Comment thread

fastplotlib/graphics/mesh.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

kushalkolar added 3 commits

December 1, 2025 21:16


          code review changes

999bbe5

fix

86b3976


          better polygon example

0fda38c

kushalkolar merged commit a5c7285 into mesh

Dec 2, 2025

almarklein deleted the mesh-with-gfeatures branch

December 3, 2025 10:01

kushalkolar added a commit that referenced this pull request

Dec 4, 2025


          Add support for mesh and surface (#953)

db49c62

* Add support for mesh and surface

* restore line example

* Implement image-surface example

* Fix 3D camera for mesh examples

* Just remove selector logic for now

* new examples in gallery

* mesh with graphic features (#954)

* mesh with gfeatures

* surface graphic works

* update, add PolygonGraphic, works

* black

* for docs and test screenshots

* black

* polygon data updating works

* update

* black

* more examples

* update add_graphic mixin

* code review changes

* fix

* better polygon example

* remove unused import

* update graphics mixin

* docs

* black

* don't need to set limit for docs gen

* add missing comma

* dont run terrain example

* new screenshots

* remove (i expect) unnecessary check

* lights as properties

* just use VertexPositions

* update PolyData

* I need to use precommit

* update api docs

---------

Co-authored-by: Kushal Kolar <[email protected]>

Reviewers

almarklein

almarklein left review comments

clewis7

Awaiting requested review from clewis7

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

kushalkolar commented Nov 29, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kushalkolar commented Nov 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

kushalkolar commented Dec 1, 2025

Uh oh!

kushalkolar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

almarklein Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

almarklein Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

kushalkolar Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

almarklein Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

almarklein Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

almarklein Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

kushalkolar commented Nov 30, 2025 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.