GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add TLS support to the Operator · Issue #4770 · feast-dev/feast

Add TLS support to the Operator #4770

New issue
Copy link
New issue
Copy link
Closed
#4796
Closed
Add TLS support to the Operator#4770
#4796
Copy link
Labels
kind/featureNew feature or requestNew feature or request

Description

@tchughesiv
tchughesiv
opened on Nov 19, 2024
Issue body actions

Is your feature request related to a problem? Please describe.
An Operator user should be able to configure feast with TLS.

Describe the solution you'd like
When configured, TLS will be enabled for that feast service. If the operator detects it's running in an OpenShift cluster, we enable TLS by default because we can leverage the built-in service serving certificate feature.

apiVersion: feast.dev/v1alpha1
kind: FeatureStore
metadata:
  name: example
  namespace: <namespace>
spec:
  feastProject: test
  services:
    <feast_service_type>: // e.g. offlineStore, onlineStore, registry 
      // add CRD validation that requires `secretRef` to be set if `disable` is false.
      tls: // optional ... enabled by default when deployed to an OpenShift cluster. if user leaves tls undefined, the operator assumes tls should be enabled and uses built-in service serving certificate feature.
        secretRef: // required if tls.disable is false
          name: <string> // required
        secretKeyNames: // optional
          tlsCrt: <string> // optional (defaults to tls.crt)
          tlsKey: <string> // optional (defaults to tls.key)
        verifyClient: <bool> // optional (defaults to false) currently only used with offline server
        disable: <bool> // optional (defaults to false) allows the user to disable tls without removing the TLS settings. one scenario in which this is beneficial would be in openshift, where we default to tls being enabled

Additional context
References for implementation -

https://github.com/feast-dev/feast/blob/master/docs/how-to-guides/starting-feast-servers-tls-mode.md

https://kubernetes.io/docs/tasks/tls/managing-tls-in-a-cluster/

https://docs.openshift.com/container-platform/4.17/security/certificates/service-serving-certificate.html

#4677

#4744

#4718

Activity

  1. tchughesiv
    added
    kind/featureNew feature or requestNew feature or request
    on Nov 19, 2024
  2. dmartinol
    closed this as completedin #4796on Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind/featureNew feature or requestNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      You are visitor 01402503 — GeezerVison does not store the pages you look up.
      Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.