GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — feat: Add TLS support to the Operator by tchughesiv · Pull Request #4796 · feast-dev/feast

Conversation

tchughesiv commented Nov 27, 2024 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

What this PR does / why we need it:

With this PR, an Operator user will be able to configure feast services with TLS. If the operator detects it's running in an OpenShift cluster, TLS is enabled by default through the use of the service serving certificates feature.

adds option to enable TLS on a per-service basis. k8s Secret required. TLS is not required across all services. the operator will configured them to work together on a per-service basis.
adds option to configure client TLS for remote registries. k8s ConfigMap required.
adds OpenShift cluster detection
when running in an OpenShift cluster, automatically configures TLS, for all services... unless disabled or overridden by the user
similarly, if a remote registry (in the same OpenShift cluster) is using auto-TLS, the operator will automatically configure client TLS... unless overridden by the user
changes OnlineStore liveness & readiness probes to httpGet type. checks /health endpoint
adds grpcurl initContainer to the online & offlineStore deployments, which will check the registry's grpc.health.v1.Health/Check endpoint before attempting to start those feast services.

Which issue(s) this PR fixes:

Fixes #4770

Misc

Example of an OpenShift deployment and TLS being automatically configured. In a k8s cluster, TLS would need to be manually configured in the FeatureStore.spec. Any required certs, keys, and k8s secrets/configmaps would also have to be created by the user -

apiVersion: feast.dev/v1alpha1
kind: FeatureStore
metadata:
  name: example
  namespace: default
spec:
  feastProject: my_project
  services:
    offlineStore: {}
    onlineStore: {}
status:
  applied:
    feastProject: my_project
    services:
      offlineStore:
        image: 'feastdev/feature-server:0.41.0'
        persistence:
          file:
            type: dask
        tls:
          secretKeyNames:
            tlsCrt: tls.crt
            tlsKey: tls.key
          secretRef:
            name: feast-example-registry-tls
      onlineStore:
        image: 'feastdev/feature-server:0.41.0'
        persistence:
          file:
            path: /tmp/online_store.db
        tls:
          secretKeyNames:
            tlsCrt: tls.crt
            tlsKey: tls.key
          secretRef:
            name: feast-example-registry-tls
      registry:
        local:
          image: 'feastdev/feature-server:0.41.0'
          persistence:
            file:
              path: /tmp/registry.db
          tls:
            secretKeyNames:
              tlsCrt: tls.crt
              tlsKey: tls.key
            secretRef:
              name: feast-example-registry-tls
  clientConfigMap: feast-example-client
  conditions:
    - lastTransitionTime: '2024-11-26T19:04:50Z'
      message: Offline Store installation complete
      reason: Ready
      status: 'True'
      type: OfflineStore
    - lastTransitionTime: '2024-11-25T21:43:28Z'
      message: Online Store installation complete
      reason: Ready
      status: 'True'
      type: OnlineStore
    - lastTransitionTime: '2024-11-25T19:59:23Z'
      message: Client installation complete
      reason: Ready
      status: 'True'
      type: Client
    - lastTransitionTime: '2024-11-26T19:04:50Z'
      message: FeatureStore installation complete
      reason: Ready
      status: 'True'
      type: FeatureStore
    - lastTransitionTime: '2024-11-25T22:26:19Z'
      message: Registry installation complete
      reason: Ready
      status: 'True'
      type: Registry
  feastVersion: 0.41.0
  phase: Ready
  serviceHostnames:
    offlineStore: 'feast-example-offline.default.svc.cluster.local:443'
    onlineStore: 'feast-example-online.default.svc.cluster.local:443'
    registry: 'feast-example-registry.default.svc.cluster.local:443'

Example of a remote registry reference -

apiVersion: feast.dev/v1alpha1
kind: FeatureStore
metadata:
  name: example
  namespace: default
spec:
  feastProject: my_project
  services:
    offlineStore: {}
    onlineStore: {}
    registry:
      remote:
        feastRef:
          name: central
          namespace: test
status:
  applied:
    feastProject: my_project
    services:
      offlineStore:
        image: 'feastdev/feature-server:0.41.0'
        persistence:
          file:
            type: dask
        tls:
          secretKeyNames:
            tlsCrt: tls.crt
            tlsKey: tls.key
          secretRef:
            name: feast-example-online-tls
      onlineStore:
        image: 'feastdev/feature-server:0.41.0'
        persistence:
          file:
            path: /tmp/online_store.db
        tls:
          secretKeyNames:
            tlsCrt: tls.crt
            tlsKey: tls.key
          secretRef:
            name: feast-example-online-tls
      registry:
        remote:
          feastRef:
            name: central
            namespace: test
          tls:
            certName: service-ca.crt
            configMapRef:
              name: feast-example-client-ca
  clientConfigMap: feast-example-client
  conditions:
    - lastTransitionTime: '2024-11-27T15:47:57Z'
      message: Offline Store installation complete
      reason: Ready
      status: 'True'
      type: OfflineStore
    - lastTransitionTime: '2024-11-25T21:43:28Z'
      message: Online Store installation complete
      reason: Ready
      status: 'True'
      type: OnlineStore
    - lastTransitionTime: '2024-11-25T19:59:23Z'
      message: Client installation complete
      reason: Ready
      status: 'True'
      type: Client
    - lastTransitionTime: '2024-11-27T15:53:42Z'
      message: FeatureStore installation complete
      reason: Ready
      status: 'True'
      type: FeatureStore
  feastVersion: 0.41.0
  phase: Ready
  serviceHostnames:
    offlineStore: 'feast-example-offline.default.svc.cluster.local:443'
    onlineStore: 'feast-example-online.default.svc.cluster.local:443'
    registry: 'feast-central-registry.test.svc.cluster.local:443'

Which results in the following client configMap & feature_store.yaml -

kind: ConfigMap
apiVersion: v1
metadata:
  name: feast-example-client
  namespace: default
  labels:
    feast.dev/name: example
    feast.dev/service-type: client
  ownerReferences:
    - apiVersion: feast.dev/v1alpha1
      kind: FeatureStore
      name: example
      uid: e4f030dc-23b1-45bc-ba86-6ef66c491701
      controller: true
      blockOwnerDeletion: true
data:
  feature_store.yaml: |
    project: my_project
    provider: local
    offline_store:
        host: feast-example-offline.default.svc.cluster.local
        type: remote
        port: 443
        scheme: https
        cert: /tls/offline/tls.crt
    online_store:
        path: https://feast-example-online.default.svc.cluster.local:443
        type: remote
        cert: /tls/online/tls.crt
    registry:
        path: feast-central-registry.test.svc.cluster.local:443
        registry_type: remote
        cert: /tls/registry/service-ca.crt
    auth:
        type: no_auth
    entity_key_serialization_version: 3

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

tchughesiv force-pushed the operator-tls branch 3 times, most recently from 6ffa5ec to 84909fc Compare

November 27, 2024 19:18

tchughesiv marked this pull request as ready for review

November 27, 2024 19:19

tchughesiv requested a review from a team as a code owner

November 27, 2024 19:19

tchughesiv force-pushed the operator-tls branch 4 times, most recently from b2f5292 to b72cdac Compare

November 27, 2024 23:41

dmartinol reviewed

Nov 28, 2024

View reviewed changes

dmartinol left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

infra/feast-operator/api/v1alpha1/featurestore_types.go

		type OfflineTlsConfigs struct {
		TlsConfigs `json:",inline"`
		// verify the client TLS certificate.
		VerifyClient *bool `json:"verifyClient,omitempty"`

dmartinol Nov 28, 2024

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why for offline store we need a different TLS config?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

tchughesiv Nov 28, 2024 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

offline offers that additional TLS related flag for some reason, whereas the others don't.

feast/sdk/python/feast/cli.py

Line 1136 in e198b17

"--verify_client",

that said, its not mentioned in the docs, so maybe its unnecessary? i guess i just felt like we should offer the user all the options. it's certainly added a layer of complexity to the code.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

tchughesiv Nov 28, 2024

Copy link

Copy Markdown

Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lokeshrangineni thoughts?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

dmartinol reacted with thumbs up emoji

All reactions

👍 1 reaction

lokeshrangineni Dec 1, 2024

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding verify_client flag - flight server is very strict with the client validation when we pass the TLS self signed certificates which made it difficult for the integration tests so I had to add this flag for the integration tests. By default verify_client flag is enabled and in the production environment it is supposed to be enabled as well. for the integration tests i marked verify_client as false. I will add about this flag to the documentation as well.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

dmartinol Dec 2, 2024

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add the verify_client options to all the servers @lokeshrangineni ?
this way we can keep a consistent CR definition and offer the same set of security functions to all of them

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

infra/feast-operator/api/v1alpha1/featurestore_types.go Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

infra/feast-operator/internal/controller/services/services.go Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

infra/feast-operator/internal/controller/services/services.go Resolved

Uh oh!

There was an error while loading. Please reload this page.

tchughesiv commented Dec 1, 2024

Copy link

Copy Markdown

Contributor Author

i think this needs the ok-to-test label

lokeshrangineni reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

lokeshrangineni added the ok-to-test label

Dec 1, 2024

tchughesiv added 2 commits

December 1, 2024 12:32


          add tls support to the operator

727883c

Signed-off-by: Tommy Hughes <[email protected]>


          operator tls review fix: if statement

274eb6a

Signed-off-by: Tommy Hughes <[email protected]>

tchughesiv force-pushed the operator-tls branch 3 times, most recently from e344b31 to 146c6fb Compare

December 1, 2024 19:20


          rebase fixes

648f519

Signed-off-by: Tommy Hughes <[email protected]>

tchughesiv force-pushed the operator-tls branch 5 times, most recently from 759ed2f to 3c70419 Compare

December 1, 2024 20:57


          authz rbac fixes

d4c3229

Signed-off-by: Tommy Hughes <[email protected]>

tchughesiv force-pushed the operator-tls branch from 3c70419 to d4c3229 Compare

December 1, 2024 21:22

dmartinol enabled auto-merge (squash)

December 2, 2024 18:25

dmartinol approved these changes

Dec 2, 2024

View reviewed changes

dmartinol merged commit a617a6c into feast-dev:master

Dec 2, 2024

tmihalac pushed a commit to tmihalac/feast that referenced this pull request

Dec 3, 2024


          feat: Add TLS support to the Operator (feast-dev#4796)

a1bc04b

* add tls support to the operator

Signed-off-by: Tommy Hughes <[email protected]>

* operator tls review fix: if statement

Signed-off-by: Tommy Hughes <[email protected]>

* rebase fixes

Signed-off-by: Tommy Hughes <[email protected]>

* authz rbac fixes

Signed-off-by: Tommy Hughes <[email protected]>

---------

Signed-off-by: Tommy Hughes <[email protected]>
Signed-off-by: Theodor Mihalache <[email protected]>

tmihalac pushed a commit to tmihalac/feast that referenced this pull request

Dec 4, 2024


          feat: Add TLS support to the Operator (feast-dev#4796)

89842fa

* add tls support to the operator

Signed-off-by: Tommy Hughes <[email protected]>

* operator tls review fix: if statement

Signed-off-by: Tommy Hughes <[email protected]>

* rebase fixes

Signed-off-by: Tommy Hughes <[email protected]>

* authz rbac fixes

Signed-off-by: Tommy Hughes <[email protected]>

---------

Signed-off-by: Tommy Hughes <[email protected]>
Signed-off-by: Theodor Mihalache <[email protected]>

lokeshrangineni pushed a commit to lokeshrangineni/feast that referenced this pull request

Dec 5, 2024


          feat: Add TLS support to the Operator (feast-dev#4796)

4f42695

* add tls support to the operator

Signed-off-by: Tommy Hughes <[email protected]>

* operator tls review fix: if statement

Signed-off-by: Tommy Hughes <[email protected]>

* rebase fixes

Signed-off-by: Tommy Hughes <[email protected]>

* authz rbac fixes

Signed-off-by: Tommy Hughes <[email protected]>

---------

Signed-off-by: Tommy Hughes <[email protected]>

franciscojavierarceo pushed a commit that referenced this pull request

Dec 5, 2024


          chore(release): release 0.42.0

aac334a

# [0.42.0](v0.41.0...v0.42.0) (2024-12-05)

### Bug Fixes

* Add adapters for sqlite datetime conversion ([#4797](#4797)) ([e198b17](e198b17))
* Added grpcio extras to default feature-server image ([#4737](#4737)) ([e9cd373](e9cd373))
* Changing node version in release ([7089918](7089918))
* Feast create empty online table when FeatureView attribute online=False ([#4666](#4666)) ([237c453](237c453))
* Fix db store types in Operator CRD ([#4798](#4798)) ([f09339e](f09339e))
* Fix the config issue for postgres ([#4776](#4776)) ([a36f7e5](a36f7e5))
* Fixed example materialize-incremental and improved explanation ([#4734](#4734)) ([ca8a7ab](ca8a7ab))
* Fixed SparkSource docstrings so it wouldn't used inhereted class docstrings ([#4722](#4722)) ([32e6aa1](32e6aa1))
* Fixing PGVector integration tests ([#4778](#4778)) ([88a0320](88a0320))
* Incorrect type passed to assert_permissions in materialize endpoints ([#4727](#4727)) ([b72c2da](b72c2da))
* Issue of DataSource subclasses using parent abstract class docstrings ([#4730](#4730)) ([b24acd5](b24acd5))
* Operator envVar positioning & tls.SecretRef.Name ([#4806](#4806)) ([1115d96](1115d96))
* Populates project created_time correctly according to created ti… ([#4686](#4686)) ([a61b93c](a61b93c))
* Reduce feast-server container image size & fix dev image build ([#4781](#4781)) ([ccc9aea](ccc9aea))
* Removed version func from feature_store.py ([#4748](#4748)) ([f902bb9](f902bb9))
* Support registry instantiation for read-only users ([#4719](#4719)) ([ca3d3c8](ca3d3c8))
* Syntax Error in BigQuery While Retrieving Columns that Start wit… ([#4713](#4713)) ([60fbc62](60fbc62))
* Update release version in a pertinent Operator file ([#4708](#4708)) ([764a8a6](764a8a6))

### Features

* Add api contract to fastapi docs ([#4721](#4721)) ([1a165c7](1a165c7))
* Add Couchbase as an online store ([#4637](#4637)) ([824859b](824859b))
* Add Operator support for spec.feastProject & status.applied fields ([#4656](#4656)) ([430ac53](430ac53))
* Add services functionality to Operator ([#4723](#4723)) ([d1d80c0](d1d80c0))
* Add TLS support to the Operator ([#4796](#4796)) ([a617a6c](a617a6c))
* Added feast Go operator db stores support ([#4771](#4771)) ([3302363](3302363))
* Added support for setting env vars in feast services in feast controller  ([#4739](#4739)) ([84b24b5](84b24b5))
* Adding docs outlining native Python transformations on singletons ([#4741](#4741)) ([0150278](0150278))
* Adding first feast operator e2e test. ([#4791](#4791)) ([8339f8d](8339f8d))
* Adding github action to run the operator end-to-end tests. ([#4762](#4762)) ([d8ccb00](d8ccb00))
* Adding ssl support for registry server. ([#4718](#4718)) ([ccf7a55](ccf7a55))
* Adding SSL support for the React UI server and feast UI command. ([#4736](#4736)) ([4a89252](4a89252))
* Adding support for native Python transformations on a single dictionary  ([#4724](#4724)) ([9bbc1c6](9bbc1c6))
* Adding TLS support for offline server. ([#4744](#4744)) ([5d8d03f](5d8d03f))
* Building the feast image ([#4775](#4775)) ([6635dde](6635dde))
* File persistence definition and implementation ([#4742](#4742)) ([3bad4a1](3bad4a1))
* Object store persistence in operator ([#4758](#4758)) ([0ae86da](0ae86da))
* OIDC authorization in Feast Operator ([#4801](#4801)) ([eb111d6](eb111d6))
* Operator will create k8s serviceaccount for each feast service ([#4767](#4767)) ([cde5760](cde5760))
* Printing more verbose logs when we start the offline server  ([#4660](#4660)) ([9d8d3d8](9d8d3d8))
* PVC configuration and impl ([#4750](#4750)) ([785a190](785a190))
* Qdrant vectorstore support ([#4689](#4689)) ([86573d2](86573d2))
* RBAC Authorization in Feast Operator ([#4786](#4786)) ([0ef5acc](0ef5acc))
* Support for nested timestamp fields in Spark Offline store ([#4740](#4740)) ([d4d94f8](d4d94f8))
* Update the go feature server from Expedia code repo. ([#4665](#4665)) ([6406625](6406625))
* Updated feast Go operator db stores ([#4809](#4809)) ([2c5a6b5](2c5a6b5))
* Updated sample secret following review ([#4811](#4811)) ([dc9f825](dc9f825))

dharmisha pushed a commit to nishantgaurav-dev/feast that referenced this pull request

Jan 15, 2025


          feat: Add TLS support to the Operator (feast-dev#4796)

be5882b

* add tls support to the operator

Signed-off-by: Tommy Hughes <[email protected]>

* operator tls review fix: if statement

Signed-off-by: Tommy Hughes <[email protected]>

* rebase fixes

Signed-off-by: Tommy Hughes <[email protected]>

* authz rbac fixes

Signed-off-by: Tommy Hughes <[email protected]>

---------

Signed-off-by: Tommy Hughes <[email protected]>

dharmisha pushed a commit to nishantgaurav-dev/feast that referenced this pull request

Jan 15, 2025


          chore(release): release 0.42.0

6c64b8f

* Add adapters for sqlite datetime conversion ([feast-dev#4797](feast-dev#4797)) ([e198b17](feast-dev@e198b17))
* Added grpcio extras to default feature-server image ([feast-dev#4737](feast-dev#4737)) ([e9cd373](feast-dev@e9cd373))
* Changing node version in release ([7089918](feast-dev@7089918))
* Feast create empty online table when FeatureView attribute online=False ([feast-dev#4666](feast-dev#4666)) ([237c453](feast-dev@237c453))
* Fix db store types in Operator CRD ([feast-dev#4798](feast-dev#4798)) ([f09339e](feast-dev@f09339e))
* Fix the config issue for postgres ([feast-dev#4776](feast-dev#4776)) ([a36f7e5](feast-dev@a36f7e5))
* Fixed example materialize-incremental and improved explanation ([feast-dev#4734](feast-dev#4734)) ([ca8a7ab](feast-dev@ca8a7ab))
* Fixed SparkSource docstrings so it wouldn't used inhereted class docstrings ([feast-dev#4722](feast-dev#4722)) ([32e6aa1](feast-dev@32e6aa1))
* Fixing PGVector integration tests ([feast-dev#4778](feast-dev#4778)) ([88a0320](feast-dev@88a0320))
* Incorrect type passed to assert_permissions in materialize endpoints ([feast-dev#4727](feast-dev#4727)) ([b72c2da](feast-dev@b72c2da))
* Issue of DataSource subclasses using parent abstract class docstrings ([feast-dev#4730](feast-dev#4730)) ([b24acd5](feast-dev@b24acd5))
* Operator envVar positioning & tls.SecretRef.Name ([feast-dev#4806](feast-dev#4806)) ([1115d96](feast-dev@1115d96))
* Populates project created_time correctly according to created ti… ([feast-dev#4686](feast-dev#4686)) ([a61b93c](feast-dev@a61b93c))
* Reduce feast-server container image size & fix dev image build ([feast-dev#4781](feast-dev#4781)) ([ccc9aea](feast-dev@ccc9aea))
* Removed version func from feature_store.py ([feast-dev#4748](feast-dev#4748)) ([f902bb9](feast-dev@f902bb9))
* Support registry instantiation for read-only users ([feast-dev#4719](feast-dev#4719)) ([ca3d3c8](feast-dev@ca3d3c8))
* Syntax Error in BigQuery While Retrieving Columns that Start wit… ([feast-dev#4713](feast-dev#4713)) ([60fbc62](feast-dev@60fbc62))
* Update release version in a pertinent Operator file ([feast-dev#4708](feast-dev#4708)) ([764a8a6](feast-dev@764a8a6))

* Add api contract to fastapi docs ([feast-dev#4721](feast-dev#4721)) ([1a165c7](feast-dev@1a165c7))
* Add Couchbase as an online store ([feast-dev#4637](feast-dev#4637)) ([824859b](feast-dev@824859b))
* Add Operator support for spec.feastProject & status.applied fields ([feast-dev#4656](feast-dev#4656)) ([430ac53](feast-dev@430ac53))
* Add services functionality to Operator ([feast-dev#4723](feast-dev#4723)) ([d1d80c0](feast-dev@d1d80c0))
* Add TLS support to the Operator ([feast-dev#4796](feast-dev#4796)) ([a617a6c](feast-dev@a617a6c))
* Added feast Go operator db stores support ([feast-dev#4771](feast-dev#4771)) ([3302363](feast-dev@3302363))
* Added support for setting env vars in feast services in feast controller  ([feast-dev#4739](feast-dev#4739)) ([84b24b5](feast-dev@84b24b5))
* Adding docs outlining native Python transformations on singletons ([feast-dev#4741](feast-dev#4741)) ([0150278](feast-dev@0150278))
* Adding first feast operator e2e test. ([feast-dev#4791](feast-dev#4791)) ([8339f8d](feast-dev@8339f8d))
* Adding github action to run the operator end-to-end tests. ([feast-dev#4762](feast-dev#4762)) ([d8ccb00](feast-dev@d8ccb00))
* Adding ssl support for registry server. ([feast-dev#4718](feast-dev#4718)) ([ccf7a55](feast-dev@ccf7a55))
* Adding SSL support for the React UI server and feast UI command. ([feast-dev#4736](feast-dev#4736)) ([4a89252](feast-dev@4a89252))
* Adding support for native Python transformations on a single dictionary  ([feast-dev#4724](feast-dev#4724)) ([9bbc1c6](feast-dev@9bbc1c6))
* Adding TLS support for offline server. ([feast-dev#4744](feast-dev#4744)) ([5d8d03f](feast-dev@5d8d03f))
* Building the feast image ([feast-dev#4775](feast-dev#4775)) ([6635dde](feast-dev@6635dde))
* File persistence definition and implementation ([feast-dev#4742](feast-dev#4742)) ([3bad4a1](feast-dev@3bad4a1))
* Object store persistence in operator ([feast-dev#4758](feast-dev#4758)) ([0ae86da](feast-dev@0ae86da))
* OIDC authorization in Feast Operator ([feast-dev#4801](feast-dev#4801)) ([eb111d6](feast-dev@eb111d6))
* Operator will create k8s serviceaccount for each feast service ([feast-dev#4767](feast-dev#4767)) ([cde5760](feast-dev@cde5760))
* Printing more verbose logs when we start the offline server  ([feast-dev#4660](feast-dev#4660)) ([9d8d3d8](feast-dev@9d8d3d8))
* PVC configuration and impl ([feast-dev#4750](feast-dev#4750)) ([785a190](feast-dev@785a190))
* Qdrant vectorstore support ([feast-dev#4689](feast-dev#4689)) ([86573d2](feast-dev@86573d2))
* RBAC Authorization in Feast Operator ([feast-dev#4786](feast-dev#4786)) ([0ef5acc](feast-dev@0ef5acc))
* Support for nested timestamp fields in Spark Offline store ([feast-dev#4740](feast-dev#4740)) ([d4d94f8](feast-dev@d4d94f8))
* Update the go feature server from Expedia code repo. ([feast-dev#4665](feast-dev#4665)) ([6406625](feast-dev@6406625))
* Updated feast Go operator db stores ([feast-dev#4809](feast-dev#4809)) ([2c5a6b5](feast-dev@2c5a6b5))
* Updated sample secret following review ([feast-dev#4811](feast-dev#4811)) ([dc9f825](feast-dev@dc9f825))

Reviewers

lokeshrangineni

lokeshrangineni left review comments

dmartinol

dmartinol approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add TLS support to the Operator

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

tchughesiv commented Nov 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What this PR does / why we need it:

Which issue(s) this PR fixes:

Misc

Uh oh!

dmartinol left a comment

Choose a reason for hiding this comment

Uh oh!

dmartinol Nov 28, 2024

Choose a reason for hiding this comment

Uh oh!

tchughesiv Nov 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tchughesiv Nov 28, 2024

Choose a reason for hiding this comment

Uh oh!

lokeshrangineni Dec 1, 2024

Choose a reason for hiding this comment

Uh oh!

dmartinol Dec 2, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tchughesiv commented Dec 1, 2024

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

tchughesiv commented Nov 27, 2024 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

tchughesiv Nov 28, 2024 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.