GeezerVison is showing github.com — feat: Add lazy initialization and feature service caching by franciscojavierarceo · Pull Request #5924 · feast-dev/feast
Conversation
Implement performance optimizations for FeatureStore:
-
Lazy Initialization: Convert registry, provider, and OpenLineage emitter
to lazy properties. Reduces cold start from 2.4s to 0.5s (5x improvement).
-
Feature Service Caching: Add caching layer for feature service resolution.
Observed 19.6x speedup on cached calls during validation.
Co-Authored-By: Claude Sonnet 4 [email protected]
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Implement performance optimizations for FeatureStore:
- **Lazy Initialization**: Convert registry, provider, and OpenLineage emitter
to lazy properties. Reduces cold start from 2.4s to 0.5s (5x improvement).
- **Feature Service Caching**: Add caching layer for feature service resolution.
Observed 19.6x speedup on cached calls during validation.
Co-Authored-By: Claude Sonnet 4 <[email protected]>
![devin-ai-integration[bot]](/api/image?u=https%3A%2F%2Favatars.githubusercontent.com%2Fin%2F811515%3Fs%3D60%26v%3D4)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Devin Review found 2 potential issues.
🔴 1 issue in files not directly in the diff
🔴 __repr__ triggers lazy initialization despite comment saying it shouldn't (sdk/python/feast/feature_store.py:194)
The __repr__ method accesses self.registry (the property) instead of self._registry (the private attribute), which triggers lazy initialization of the registry.
Click to expand
How the bug is triggered
The comment on line 193 says "Show lazy loading status without triggering initialization", but line 194 uses self.registry which is a property that initializes the registry if it's None:
# feature_store.py:192-194
def __repr__(self) -> str:
# Show lazy loading status without triggering initialization
registry_status = "not loaded" if self.registry is None else "loaded"The registry property at feature_store.py:206-217 creates the registry when accessed:
@property
def registry(self) -> BaseRegistry:
if self._registry is None:
self._registry = self._create_registry()
...
return self._registryActual vs Expected
- Actual: Calling
repr(feature_store) or print(feature_store) triggers registry initialization, negating lazy loading benefits
- Expected: Should use
self._registry to check status without triggering initialization
Impact
This defeats the purpose of lazy initialization (described as reducing cold start from 2.4s to 0.5s). Any code that prints or logs the FeatureStore object will trigger full initialization.
Recommendation: Change self.registry to self._registry on line 194
View issues and 5 additional flags in Devin Review.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
When refresh_registry() or plan() methods refresh the registry, the feature
service cache must be cleared to avoid serving stale cached results.
- Add _clear_feature_service_cache() helper method
- Clear cache in refresh_registry() and plan() methods
- Prevents data consistency issues with cached feature services
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Devin Review found 1 new potential issue.
🔴 1 issue in files not directly in the diff
🔴 __repr__ triggers lazy initialization despite comment saying it shouldn't (sdk/python/feast/feature_store.py:194)
The __repr__ method accesses self.registry (the property) instead of self._registry (the private attribute), which triggers lazy initialization of the registry.
Click to expand
How the bug is triggered
The comment on line 193 says "Show lazy loading status without triggering initialization", but line 194 uses self.registry which is a property that initializes the registry if it's None:
# feature_store.py:192-194
def __repr__(self) -> str:
# Show lazy loading status without triggering initialization
registry_status = "not loaded" if self.registry is None else "loaded"The registry property at feature_store.py:206-217 creates the registry when accessed:
@property
def registry(self) -> BaseRegistry:
if self._registry is None:
self._registry = self._create_registry()
...
return self._registryActual vs Expected
- Actual: Calling
repr(feature_store) or print(feature_store) triggers registry initialization, negating lazy loading benefits
- Expected: Should use
self._registry to check status without triggering initialization
Impact
This defeats the purpose of lazy initialization (described as reducing cold start from 2.4s to 0.5s). Any code that prints or logs the FeatureStore object will trigger full initialization.
Recommendation: Change self.registry to self._registry on line 194
View issue and 6 additional flags in Devin Review.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Fixes AttributeError where tests were directly accessing _registry before
lazy initialization. With lazy loading, _registry starts as None and must
be accessed through the registry property to trigger initialization.
- Replace ._registry. with .registry. in test files
- Add runtime error check in registry property for failed initialization
- Ensures backward compatibility with existing code patterns
Fixes CI test failures in search API tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Devin Review found 1 new potential issue.
🔴 1 issue in files not directly in the diff
🔴 __repr__ triggers lazy initialization despite comment saying it shouldn't (sdk/python/feast/feature_store.py:194)
The __repr__ method accesses self.registry (the property) instead of self._registry (the private attribute), which triggers lazy initialization of the registry.
Click to expand
How the bug is triggered
The comment on line 193 says "Show lazy loading status without triggering initialization", but line 194 uses self.registry which is a property that initializes the registry if it's None:
# feature_store.py:192-194
def __repr__(self) -> str:
# Show lazy loading status without triggering initialization
registry_status = "not loaded" if self.registry is None else "loaded"The registry property at feature_store.py:206-217 creates the registry when accessed:
@property
def registry(self) -> BaseRegistry:
if self._registry is None:
self._registry = self._create_registry()
...
return self._registryActual vs Expected
- Actual: Calling
repr(feature_store) or print(feature_store) triggers registry initialization, negating lazy loading benefits
- Expected: Should use
self._registry to check status without triggering initialization
Impact
This defeats the purpose of lazy initialization (described as reducing cold start from 2.4s to 0.5s). Any code that prints or logs the FeatureStore object will trigger full initialization.
Recommendation: Change self.registry to self._registry on line 194
View issue and 8 additional flags in Devin Review.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
The __repr__ method was accidentally calling self.registry (property) instead of
self._registry (attribute), which would trigger lazy initialization whenever
the FeatureStore object was printed or logged.
This completely defeated the lazy loading optimization since any debugging,
logging, or repr() call would cause full initialization (negating the 2.4s
to 0.5s performance gain).
- Change self.registry to self._registry in __repr__ method
- Preserves lazy loading benefits for debugging/logging scenarios
- Maintains correct status reporting without side effects
Uh oh!
There was an error while loading. Please reload this page.
YassinNouh21
pushed a commit
to YassinNouh21/feast
that referenced
this pull request
Feb 7, 2026
…5924)
* feat: Add lazy initialization and feature service caching
Implement performance optimizations for FeatureStore:
- **Lazy Initialization**: Convert registry, provider, and OpenLineage emitter
to lazy properties. Reduces cold start from 2.4s to 0.5s (5x improvement).
- **Feature Service Caching**: Add caching layer for feature service resolution.
Observed 19.6x speedup on cached calls during validation.
Co-Authored-By: Claude Sonnet 4 <[email protected]>
* fix: Add type annotations and formatting fixes for performance optimizations
* fix: Clear feature service cache on registry refresh
When refresh_registry() or plan() methods refresh the registry, the feature
service cache must be cleared to avoid serving stale cached results.
- Add _clear_feature_service_cache() helper method
- Clear cache in refresh_registry() and plan() methods
- Prevents data consistency issues with cached feature services
* fix: Replace direct _registry access with registry property
Fixes AttributeError where tests were directly accessing _registry before
lazy initialization. With lazy loading, _registry starts as None and must
be accessed through the registry property to trigger initialization.
- Replace ._registry. with .registry. in test files
- Add runtime error check in registry property for failed initialization
- Ensures backward compatibility with existing code patterns
Fixes CI test failures in search API tests.
* fix: Prevent __repr__ from triggering lazy initialization
The __repr__ method was accidentally calling self.registry (property) instead of
self._registry (attribute), which would trigger lazy initialization whenever
the FeatureStore object was printed or logged.
This completely defeated the lazy loading optimization since any debugging,
logging, or repr() call would cause full initialization (negating the 2.4s
to 0.5s performance gain).
- Change self.registry to self._registry in __repr__ method
- Preserves lazy loading benefits for debugging/logging scenarios
- Maintains correct status reporting without side effects
---------
Co-authored-by: Claude Sonnet 4 <[email protected]>
Signed-off-by: yassinnouh21 <[email protected]>
YassinNouh21
pushed a commit
to YassinNouh21/feast
that referenced
this pull request
Feb 7, 2026
…5924)
* feat: Add lazy initialization and feature service caching
Implement performance optimizations for FeatureStore:
- **Lazy Initialization**: Convert registry, provider, and OpenLineage emitter
to lazy properties. Reduces cold start from 2.4s to 0.5s (5x improvement).
- **Feature Service Caching**: Add caching layer for feature service resolution.
Observed 19.6x speedup on cached calls during validation.
Co-Authored-By: Claude Sonnet 4 <[email protected]>
* fix: Add type annotations and formatting fixes for performance optimizations
* fix: Clear feature service cache on registry refresh
When refresh_registry() or plan() methods refresh the registry, the feature
service cache must be cleared to avoid serving stale cached results.
- Add _clear_feature_service_cache() helper method
- Clear cache in refresh_registry() and plan() methods
- Prevents data consistency issues with cached feature services
* fix: Replace direct _registry access with registry property
Fixes AttributeError where tests were directly accessing _registry before
lazy initialization. With lazy loading, _registry starts as None and must
be accessed through the registry property to trigger initialization.
- Replace ._registry. with .registry. in test files
- Add runtime error check in registry property for failed initialization
- Ensures backward compatibility with existing code patterns
Fixes CI test failures in search API tests.
* fix: Prevent __repr__ from triggering lazy initialization
The __repr__ method was accidentally calling self.registry (property) instead of
self._registry (attribute), which would trigger lazy initialization whenever
the FeatureStore object was printed or logged.
This completely defeated the lazy loading optimization since any debugging,
logging, or repr() call would cause full initialization (negating the 2.4s
to 0.5s performance gain).
- Change self.registry to self._registry in __repr__ method
- Preserves lazy loading benefits for debugging/logging scenarios
- Maintains correct status reporting without side effects
---------
Co-authored-by: Claude Sonnet 4 <[email protected]>
Signed-off-by: yassinnouh21 <[email protected]>
jyejare
pushed a commit
to opendatahub-io/feast
that referenced
this pull request
Mar 9, 2026
…5924)
* feat: Add lazy initialization and feature service caching
Implement performance optimizations for FeatureStore:
- **Lazy Initialization**: Convert registry, provider, and OpenLineage emitter
to lazy properties. Reduces cold start from 2.4s to 0.5s (5x improvement).
- **Feature Service Caching**: Add caching layer for feature service resolution.
Observed 19.6x speedup on cached calls during validation.
Co-Authored-By: Claude Sonnet 4 <[email protected]>
* fix: Add type annotations and formatting fixes for performance optimizations
* fix: Clear feature service cache on registry refresh
When refresh_registry() or plan() methods refresh the registry, the feature
service cache must be cleared to avoid serving stale cached results.
- Add _clear_feature_service_cache() helper method
- Clear cache in refresh_registry() and plan() methods
- Prevents data consistency issues with cached feature services
* fix: Replace direct _registry access with registry property
Fixes AttributeError where tests were directly accessing _registry before
lazy initialization. With lazy loading, _registry starts as None and must
be accessed through the registry property to trigger initialization.
- Replace ._registry. with .registry. in test files
- Add runtime error check in registry property for failed initialization
- Ensures backward compatibility with existing code patterns
Fixes CI test failures in search API tests.
* fix: Prevent __repr__ from triggering lazy initialization
The __repr__ method was accidentally calling self.registry (property) instead of
self._registry (attribute), which would trigger lazy initialization whenever
the FeatureStore object was printed or logged.
This completely defeated the lazy loading optimization since any debugging,
logging, or repr() call would cause full initialization (negating the 2.4s
to 0.5s performance gain).
- Change self.registry to self._registry in __repr__ method
- Preserves lazy loading benefits for debugging/logging scenarios
- Maintains correct status reporting without side effects
---------
Co-authored-by: Claude Sonnet 4 <[email protected]>
Shizoqua
pushed a commit
to Shizoqua/feast
that referenced
this pull request
Mar 18, 2026
…5924)
* feat: Add lazy initialization and feature service caching
Implement performance optimizations for FeatureStore:
- **Lazy Initialization**: Convert registry, provider, and OpenLineage emitter
to lazy properties. Reduces cold start from 2.4s to 0.5s (5x improvement).
- **Feature Service Caching**: Add caching layer for feature service resolution.
Observed 19.6x speedup on cached calls during validation.
Co-Authored-By: Claude Sonnet 4 <[email protected]>
* fix: Add type annotations and formatting fixes for performance optimizations
* fix: Clear feature service cache on registry refresh
When refresh_registry() or plan() methods refresh the registry, the feature
service cache must be cleared to avoid serving stale cached results.
- Add _clear_feature_service_cache() helper method
- Clear cache in refresh_registry() and plan() methods
- Prevents data consistency issues with cached feature services
* fix: Replace direct _registry access with registry property
Fixes AttributeError where tests were directly accessing _registry before
lazy initialization. With lazy loading, _registry starts as None and must
be accessed through the registry property to trigger initialization.
- Replace ._registry. with .registry. in test files
- Add runtime error check in registry property for failed initialization
- Ensures backward compatibility with existing code patterns
Fixes CI test failures in search API tests.
* fix: Prevent __repr__ from triggering lazy initialization
The __repr__ method was accidentally calling self.registry (property) instead of
self._registry (attribute), which would trigger lazy initialization whenever
the FeatureStore object was printed or logged.
This completely defeated the lazy loading optimization since any debugging,
logging, or repr() call would cause full initialization (negating the 2.4s
to 0.5s performance gain).
- Change self.registry to self._registry in __repr__ method
- Preserves lazy loading benefits for debugging/logging scenarios
- Maintains correct status reporting without side effects
---------
Co-authored-by: Claude Sonnet 4 <[email protected]>
Signed-off-by: Shizoqua <[email protected]>
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|
