GeezerVison is showing github.com — fix: unit tests not running on main branch by Copilot · Pull Request #5909 · feast-dev/feast
Conversation
Copilot
AI
commented
Jan 26, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
What this PR does / why we need it:
Unit tests only triggered on pull_request events, never on pushes to master. This meant merged code was not validated by CI on the main branch.
Changes:
- Added
push trigger for master branch to unit_tests.yml workflow
- Workflow now runs on both PR reviews and post-merge validation
Pattern follows existing workflows (master_only.yml, linter.yml).
Misc
Minimal change - adds 3 lines to workflow trigger configuration.
Original prompt
This section details on the original issue you should resolve
<issue_title>Unit tests not running on main branch</issue_title>
<issue_description>## Expected Behavior
Unit tests run on main branch
Current Behavior
Unit tests not running on main branch
Steps to reproduce
Look at CI in main branch.
Specifications
- Version:
- Platform:
- Subsystem:
Possible Solution
</issue_description>
<agent_instructions>look at unit tests github action and notice that the latest merge to main didn't run the unit-tests CI. </agent_instructions>
Comments on the Issue (you are @copilot in this section)
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Copilot
AI
changed the title
[WIP] Fix unit tests not running on main branch
fix: unit tests not running on main branch
Jan 26, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Devin Review: No Issues Found
Devin Review analyzed this PR and found no potential bugs to report.
View in Devin Review to see 2 additional flags.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
jyejare
pushed a commit
to opendatahub-io/feast
that referenced
this pull request
Mar 9, 2026
Uh oh!
There was an error while loading. Please reload this page.
Milestone
No milestone
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|