GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — docs: Update intro documentation page by adchia · Pull Request #2982 · feast-dev/feast

Conversation

@adchia

@adchia adchia commented Jul 28, 2022

Copy link
Copy Markdown
Collaborator

What this PR does / why we need it:
This updates the intro Feast documentation page to clarify on:

  • What Feast is
  • What Feast doesn't fully do
  • Who Feast is built for
  • Example use cases

Which issue(s) this PR fixes:

Fixes #

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@feast-ci-bot feast-ci-bot added approved size/M labels Jul 28, 2022
@adchia
adchia force-pushed the gitbook_test branch from 4e1b601 to 5a9c7f8 Compare July 28, 2022 21:19
@adchia adchia changed the title docs: update intro documentation page docs: Update intro documentation page Jul 28, 2022
@codecov-commenter

codecov-commenter commented Jul 28, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

Merging #2982 (4d8b2f3) into master (2680f7b) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2982      +/-   ##
==========================================
- Coverage   77.82%   77.78%   -0.05%     
==========================================
  Files         192      192              
  Lines       16427    16427              
==========================================
- Hits        12784    12777       -7     
- Misses       3643     3650       +7
Flag Coverage Δ
integrationtests 67.87% <ø> (-0.15%) ⬇️
unittests 59.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/tests/utils/basic_read_write_test.py 93.54% <0.00%> (-6.46%) ⬇️
.../integration/online_store/test_online_retrieval.py 96.84% <0.00%> (-3.16%) ⬇️
sdk/python/feast/infra/online_stores/datastore.py 87.96% <0.00%> (-1.39%) ⬇️
...east/infra/materialization/lambda/lambda_engine.py 93.75% <0.00%> (+1.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2680f7b...4d8b2f3. Read the comment docs.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
kevjumba
kevjumba approved these changes Jul 29, 2022
View reviewed changes
Comment thread README.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
achals
achals approved these changes Jul 29, 2022
View reviewed changes

@achals achals left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@feast-ci-bot feast-ci-bot assigned achals Jul 29, 2022
@feast-ci-bot feast-ci-bot added the lgtm label Jul 29, 2022
@feast-ci-bot

feast-ci-bot commented Jul 29, 2022

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, adchia, kevjumba

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [achals,adchia,kevjumba]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
adchia added 3 commits July 29, 2022 17:13
@adchia
GitBook: [#3] docs: update intro documentation page
7a54227 
Signed-off-by: Danny Chiao <[email protected]>
@adchia
update main README blurb
c236447 
Signed-off-by: Danny Chiao <[email protected]>
@adchia
address comments
4d8b2f3 
Signed-off-by: Danny Chiao <[email protected]>
@adchia
adchia force-pushed the gitbook_test branch from 779c5a8 to 4d8b2f3 Compare July 29, 2022 21:15
@feast-ci-bot feast-ci-bot removed the lgtm label Jul 29, 2022
@kevjumba

kevjumba commented Jul 29, 2022

Copy link
Copy Markdown
Collaborator

/lgtm
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@feast-ci-bot feast-ci-bot assigned kevjumba Jul 29, 2022
@feast-ci-bot feast-ci-bot added the lgtm label Jul 29, 2022
@feast-ci-bot
feast-ci-bot merged commit 61a194c into feast-dev:master Jul 29, 2022
adchia added a commit that referenced this pull request Aug 1, 2022
@adchia
docs: Update intro documentation page (#2982)
39cd44e 
* GitBook: [#3] docs: update intro documentation page

Signed-off-by: Danny Chiao <[email protected]>

* update main README blurb

Signed-off-by: Danny Chiao <[email protected]>

* address comments

Signed-off-by: Danny Chiao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@achals achals achals approved these changes
@kevjumba kevjumba kevjumba approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@achals achals

@kevjumba kevjumba

Labels

approved lgtm size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@adchia @codecov-commenter @feast-ci-bot @kevjumba @achals
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.