GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — chore: Add `value_type` parameter back to entities by felixwang9817 · Pull Request #3161 · feast-dev/feast

Conversation

@felixwang9817

@felixwang9817 felixwang9817 commented Aug 31, 2022

Copy link
Copy Markdown
Collaborator

Signed-off-by: Felix Wang [email protected]

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@feast-ci-bot feast-ci-bot added approved size/L labels Aug 31, 2022
@codecov-commenter

codecov-commenter commented Aug 31, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

Base: 67.10% // Head: 76.18% // Increases project coverage by +9.07% 🎉

Coverage data is based on head (7b759e3) compared to base (857876b).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3161      +/-   ##
==========================================
+ Coverage   67.10%   76.18%   +9.07%     
==========================================
  Files         175      211      +36     
  Lines       15903    17889    +1986     
==========================================
+ Hits        10672    13629    +2957     
+ Misses       5231     4260     -971
Flag Coverage Δ
integrationtests 66.86% <33.33%> (-0.25%) ⬇️
unittests 58.36% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/inference.py 86.36% <ø> (+2.27%) ⬆️
sdk/python/feast/entity.py 91.04% <100.00%> (+7.46%) ⬆️
sdk/python/feast/feature_view.py 96.87% <100.00%> (+0.20%) ⬆️
...thon/tests/unit/infra/test_inference_unit_tests.py 100.00% <100.00%> (+85.79%) ⬆️
sdk/python/tests/unit/test_feature_views.py 98.83% <100.00%> (+72.58%) ⬆️
...on/feast/infra/materialization/snowflake_engine.py 92.13% <0.00%> (-0.46%) ⬇️
...tion/feature_repos/universal/online_store/hbase.py 50.00% <0.00%> (ø)
...line_stores/contrib/athena_offline_store/athena.py 38.50% <0.00%> (ø)
...ffline_stores/contrib/athena_repo_configuration.py 100.00% <0.00%> (ø)
..._stores/contrib/postgres_offline_store/postgres.py 34.14% <0.00%> (ø)
... and 104 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@felixwang9817
felixwang9817 force-pushed the add_entity_type branch from 0098d89 to 76ef264 Compare August 31, 2022 20:19
@felixwang9817
Add value_type parameter back to entities
7b759e3 
Signed-off-by: Felix Wang <[email protected]>
@felixwang9817
felixwang9817 force-pushed the add_entity_type branch from 76ef264 to 7b759e3 Compare August 31, 2022 20:19
achals
achals approved these changes Sep 1, 2022
View reviewed changes
@feast-ci-bot

feast-ci-bot commented Sep 1, 2022

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [achals,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@achals

achals commented Sep 1, 2022

Copy link
Copy Markdown
Member

/ok-to-test
/lgtm
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@feast-ci-bot feast-ci-bot assigned achals Sep 1, 2022
@feast-ci-bot feast-ci-bot added lgtm ok-to-test labels Sep 1, 2022
@feast-ci-bot
feast-ci-bot merged commit 1b09719 into feast-dev:master Sep 1, 2022
adchia pushed a commit that referenced this pull request Sep 3, 2022
@felixwang9817 @adchia
chore: Add value_type parameter back to entities (#3161)
a3d0ae5 
Add `value_type` parameter back to entities

Signed-off-by: Felix Wang <[email protected]>

Signed-off-by: Felix Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@achals achals achals approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@achals achals

Labels

approved lgtm ok-to-test size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@felixwang9817 @codecov-commenter @feast-ci-bot @achals
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.