GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — fix: Fix numpy version specification by acmarco · Pull Request #3241 · feast-dev/feast

Conversation

acmarco commented Sep 21, 2022

Copy link

Copy Markdown

What this PR does / why we need it:

The install script for version 0.22 creates conflicts with other packages over the version of numpy. It looks like the version specification is wrong as it is unusual to see redundant constraints like what is there now (i.e: <1.22 and also <2).

Which issue(s) this PR fixes:

Fixes #

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

feast-ci-bot added the size/XS label

Sep 21, 2022

achals commented Sep 21, 2022

Copy link

Copy Markdown

Member

🤦🏽 Thanks for the catch @acmarco . Do you mind signing your commit?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

codecov-commenter commented Sep 21, 2022

Copy link

Copy Markdown

Codecov Report

Base: 58.21% // Head: 58.21% // No change to project coverage 👍

Coverage data is based on head (92f2c06) compared to base (99e5d25).
Patch has no changes to coverable lines.

Additional details and impacted files

@@              Coverage Diff              @@
##           v0.22-branch    #3241   +/-   ##
=============================================
  Coverage         58.21%   58.21%           
=============================================
  Files               177      177           
  Lines             15775    15775           
=============================================
  Hits               9183     9183           
  Misses             6592     6592

Flag	Coverage Δ
unittests	`58.21% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
setup.py	`0.00% <ø> (ø)`

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

acmarco commented Sep 21, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Author

🤦🏽 Thanks for the catch @acmarco . Do you mind signing your commit?

My commit is signed (i.e: "This commit was signed with the committer’s verified signature. ") ... but maybe you mean another type of signature? Sorry if I am misunderstanding, @achals

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

felixwang9817 commented Sep 22, 2022

Copy link

Copy Markdown

Collaborator

hey @acmarco, thanks for the PR! here's what we mean by signing your commits

also, is there a particular reason you're using Feast 0.22 instead of Feast 0.24?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

felixwang9817 self-assigned this

Sep 22, 2022


          fix: Fix numpy version specification

73b33da

Signed-off-by: Marco Gagliano <[email protected]>

acmarco force-pushed the fix-numpy-version-spec branch from 92f2c06 to 73b33da Compare

September 22, 2022 01:55

acmarco commented Sep 22, 2022

Copy link

Copy Markdown

Author

hey @acmarco, thanks for the PR! here's what we mean by signing your commits

also, is there a particular reason you're using Feast 0.22 instead of Feast 0.24?

Ah! OK. Sorry for the confusion. signed off.

The reason we are stuck on 0.22 is not Feast related, but that we install feast in same python env as other packages that require older versions of numpy and pandas. Upgrading other packages or re-jigging our envs would unblock upgrading Feast, but is a bit complicated right now. Definitely on our roadmap to upgrade Feast and the other packages we use.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

felixwang9817 commented Sep 22, 2022

Copy link

Copy Markdown

Collaborator

@acmarco got it, that makes sense. I'll approve this PR and cut a patch release (0.22.5) once it's in!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

felixwang9817 approved these changes

Sep 22, 2022

View reviewed changes

felixwang9817 left a comment

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

feast-ci-bot added the lgtm label

Sep 22, 2022

feast-ci-bot commented Sep 22, 2022

Copy link

Copy Markdown

Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: acmarco, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

feast-ci-bot added the approved label

Sep 22, 2022

achals merged commit 298bdde into feast-dev:v0.22-branch

Oct 12, 2022

acmarco commented Oct 27, 2022

Copy link

Copy Markdown

Author

I'll approve this PR and cut a patch release (0.22.5) once it's in!

thanks for taking the time to address this PR. I was just wondering when the 0.22.5 patch might become available. thanks!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

adchia commented Oct 28, 2022

Copy link

Copy Markdown

Collaborator

Let me cherrypick this right now and release!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

adchia pushed a commit that referenced this pull request

Oct 28, 2022


          chore(release): release 0.22.5

31009b5

## [0.22.5](v0.22.4...v0.22.5) (2022-10-28)

### Bug Fixes

* Fix numpy version specification ([#3241](#3241)) ([298bdde](298bdde))

adchia commented Oct 29, 2022

Copy link

Copy Markdown

Collaborator

Actually this PR doesn't make sense for specifically 0.22. We dropped Python 3.7 support in 0.23 (numpy 1.22 also drops this), so this results in a failed release.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

acmarco commented Nov 2, 2022

Copy link

Copy Markdown

Author

Actually this PR doesn't make sense for specifically 0.22. We dropped Python 3.7 support in 0.23 (numpy 1.22 also drops this), so this results in a failed release.

Sorry, i don't follow, but I just want to confirm that a it will not be possible to publish a 0.22.5 patch release with the changes from this PR. If not, is there any easy way to remedy that on my end? If there is no way, I'll consider this matter closed.

thanks

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

adchia commented Nov 4, 2022

Copy link

Copy Markdown

Collaborator

Yeah it will not be feasible. It's feasible to cherry-pick this into any minor release afterwards (i.e. 0.23+)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Reviewers

felixwang9817

felixwang9817 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

felixwang9817

Labels

approved lgtm size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

acmarco commented Sep 21, 2022

Uh oh!

achals commented Sep 21, 2022

Uh oh!

codecov-commenter commented Sep 21, 2022

Codecov Report

Uh oh!

acmarco commented Sep 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

felixwang9817 commented Sep 22, 2022

Uh oh!

acmarco commented Sep 22, 2022

Uh oh!

felixwang9817 commented Sep 22, 2022

Uh oh!

felixwang9817 left a comment

Choose a reason for hiding this comment

Uh oh!

feast-ci-bot commented Sep 22, 2022

Uh oh!

acmarco commented Oct 27, 2022

Uh oh!

adchia commented Oct 28, 2022

Uh oh!

adchia commented Oct 29, 2022

Uh oh!

acmarco commented Nov 2, 2022

Uh oh!

adchia commented Nov 4, 2022

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

acmarco commented Sep 21, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.