GeezerVison

Original file line number	Diff line number	Diff line change
Expand Up		@@ -402,7 +402,12 @@ def _python_value_to_proto_value(
		valid_scalar_types,
		) = PYTHON_SCALAR_VALUE_TYPE_TO_PROTO_VALUE[feast_value_type]
		if valid_scalar_types:
		assert type(sample) in valid_scalar_types
		if sample == 0 or sample == 0.0:
Comment thread Outdated felixwang9817 Dec 19, 2022 Copy link Copy Markdown Collaborator There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. nit: would you mind adding a comment indicating why this special case is necessary? Sorry, something went wrong. Uh oh! There was an error while loading. Please reload this page. All reactions kysersozelee Dec 19, 2022 Copy link Copy Markdown Contributor Author There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. e0c952f Left the comment. Let me know if it is not inappropriate! Sorry, something went wrong. Uh oh! There was an error while loading. Please reload this page. All reactions felixwang9817 Dec 19, 2022 Copy link Copy Markdown Collaborator There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. @kysersozelee hm I think this comment is still not super clear to me - it would be great if you could add why type validation cannot be performed with only one type (if I understand correctly from #3400, the issue is because you might e.g. have an int value in a float column) Sorry, something went wrong. Uh oh! There was an error while loading. Please reload this page. kysersozelee reacted with thumbs up emoji All reactions 👍 1 reaction kysersozelee Dec 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page. Copy link Copy Markdown Contributor Author There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. @felixwang9817 Left the two comments. Let me know if it is inappropriate! # Numpy convert 0 to int. However, in the feature view definition, the type of column may be a float. # So, if value is 0, type validation must pass if scalar_types are either int or float. Sorry, something went wrong. Uh oh! There was an error while loading. Please reload this page. All reactions felixwang9817 Dec 19, 2022 Copy link Copy Markdown Collaborator There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. thanks @kysersozelee! Sorry, something went wrong. Uh oh! There was an error while loading. Please reload this page. All reactions
		# Numpy convert 0 to int. However, in the feature view definition, the type of column may be a float.
		# So, if value is 0, type validation must pass if scalar_types are either int or float.
		assert type(sample) in [np.int64, int, np.float64, float]
		else:
		assert type(sample) in valid_scalar_types
		if feast_value_type == ValueType.BOOL:
		# ProtoValue does not support conversion of np.bool_ so we need to convert it to support np.bool_.
		return [
Expand Down

Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

fix: Assertion condition when value is 0 #3401

Uh oh!

fix: Assertion condition when value is 0 #3401

Uh oh!

Uh oh!

Diff view

Diff view

There are no files selected for viewing

felixwang9817 Dec 19, 2022

Choose a reason for hiding this comment

Uh oh!

kysersozelee Dec 19, 2022

Choose a reason for hiding this comment

Uh oh!

felixwang9817 Dec 19, 2022

Choose a reason for hiding this comment

Uh oh!

kysersozelee Dec 19, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

felixwang9817 Dec 19, 2022

Choose a reason for hiding this comment

Uh oh!

GeezerVison

fix: Assertion condition when value is 0 #3401

Uh oh!

fix: Assertion condition when value is 0 #3401

Uh oh!

Uh oh!

Diff view

Diff view

There are no files selected for viewing

felixwang9817 Dec 19, 2022

Choose a reason for hiding this comment

Uh oh!

kysersozelee Dec 19, 2022

Choose a reason for hiding this comment

Uh oh!

felixwang9817 Dec 19, 2022

Choose a reason for hiding this comment

Uh oh!

kysersozelee Dec 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

felixwang9817 Dec 19, 2022

Choose a reason for hiding this comment

Uh oh!

kysersozelee Dec 19, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.