GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — fix: Updating the batch field so that you can query create and event date. by franciscojavierarceo · Pull Request #3411 · feast-dev/feast

fix: Updating the batch field so that you can query create and event date. #3411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

feast-ci-bot merged 4 commits into feast-dev:master from franciscojavierarceo:query-created-date

Jan 5, 2023

Uh oh!

There was an error while loading. Please reload this page.

Merged

fix: Updating the batch field so that you can query create and event date. #3411

Changes from 1 commit

Commits

Show all changes

4 commits

Select commit Hold shift + click to select a range

cd9dc81

fix: Assertion condition when value is 0 (#3401)

kysersozelee Dec 20, 2022

a7ce3b7

updating the batch field so that if you want return the created date …

franciscojavierarceo Dec 23, 2022

5ea5165

linted

franciscojavierarceo Dec 23, 2022

9eba3ea

adding change to also support querying the event_timestamp

franciscojavierarceo Dec 27, 2022

File filter

Filter by extension .py (1) All 1 file type selected

Viewed files

Clear filters

Conversations

Failed to load comments.

Uh oh!

There was an error while loading. Please reload this page.

Jump to

Jump to file

Failed to load files.

Uh oh!

There was an error while loading. Please reload this page.

Diff view

Unified

Split

Hide whitespace

Diff view

Unified

Split

Hide whitespace

Previous commit

adding change to also support querying the event_timestamp

Signed-off-by: franciscojavierarceo <[email protected]>

Loading branch information

Uh oh!

There was an error while loading. Please reload this page.

franciscojavierarceo committed Jan 4, 2023

commit 9eba3eaa3defc03b24e0992115927bc31105bc73

There are no files selected for viewing

5 changes: 5 additions & 0 deletions 5 sdk/python/feast/infra/offline_stores/file.py

Show comments

View file

Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -599,6 +599,11 @@ def _normalize_timestamp(
		created_timestamp_column_type = df_to_join_types[created_timestamp_column]

		if not hasattr(timestamp_field_type, "tz") or timestamp_field_type.tz != pytz.UTC:
		# if you are querying for the event timestamp field, we have to deduplicate
Comment thread Outdated adchia Jan 3, 2023 Copy link Copy Markdown Collaborator There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. not fully sure i understand what these duplicate columns are coming from? Can you leave more comments on why? Sorry, something went wrong. Uh oh! There was an error while loading. Please reload this page. All reactions franciscojavierarceo Jan 3, 2023 Copy link Copy Markdown Member Author There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. yeah i'll update the PR but basically querying for `created` in `get_online_features` duplicates the `created_timestamp_column`. So I could go deeper and try to fix the duplication but I needed a quick fix on my side and it works correctly for us. Sorry, something went wrong. Uh oh! There was an error while loading. Please reload this page. All reactions franciscojavierarceo Jan 3, 2023 Copy link Copy Markdown Member Author There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. @adchia updated the comment 👍 Sorry, something went wrong. Uh oh! There was an error while loading. Please reload this page. All reactions
		if len(df_to_join[timestamp_field].shape) > 1:
		df_to_join, dups = _df_column_uniquify(df_to_join)
		df_to_join = df_to_join.drop(columns=dups)

		# Make sure all timestamp fields are tz-aware. We default tz-naive fields to UTC
		df_to_join[timestamp_field] = df_to_join[timestamp_field].apply(
		lambda x: x if x.tzinfo is not None else x.replace(tzinfo=pytz.utc),
Expand Down

Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

fix: Updating the batch field so that you can query create and event date. #3411

Uh oh!

fix: Updating the batch field so that you can query create and event date. #3411

Uh oh!

Uh oh!

Diff view

Diff view

Uh oh!

There are no files selected for viewing

adchia Jan 3, 2023

Choose a reason for hiding this comment

Uh oh!

franciscojavierarceo Jan 3, 2023

Choose a reason for hiding this comment

Uh oh!

franciscojavierarceo Jan 3, 2023

Choose a reason for hiding this comment

Uh oh!