GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat: Add support for arrays in snowflake by JohnLemmonMedely · Pull Request #3758 · feast-dev/feast

Conversation

@JohnLemmonMedely

@JohnLemmonMedely JohnLemmonMedely commented Sep 8, 2023

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:
Snowflake doesn't support type-checked arrays but support for arrays can still be added if developers can guarantee the type consistency themselves through the external data pipelines.

Which issue(s) this PR fixes:

Fixes #2280

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JohnLemmonMedely

JohnLemmonMedely commented Sep 8, 2023

Copy link
Copy Markdown
Contributor Author

@sfc-gh-madkins Here's my draft PR (tests and documentation still pending). I've confirmed it unblocks my specific use-case to support a List[String] and materializing it to a Redis Online store but I'll need to setup the tests to confirm the other paths in the code work.

I'd appreciate a sanity check on some of the choices I had to make before I invest more time in this.

  1. To cast the data correctly from pandas I just apply a json.loads(x) on the columns for any array type.
  2. I only added support for Arrays to limit scope--but I think the same setup can work for objects.
  3. In the function snowflake_type_to_feast_value_type I force array types to cast to Feast's String type. It looks like this function is used when inferring column types but that can't be done perfectly in this direction. So casting to a String seemed like the safest option.
  4. Do you know any place in the code I'm missing changes?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sfc-gh-madkins sfc-gh-madkins added the ok-to-test label Sep 8, 2023
srausser
srausser reviewed Sep 13, 2023
View reviewed changes
Comment thread sdk/python/feast/infra/offline_stores/snowflake.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
JohnLemmonMedely and others added 2 commits September 15, 2023 13:41
@JohnLemmonMedely
Adds support for arrays in snowflake
ffad7e9 
Signed-off-by: john.lemmon <[email protected]>
@JohnLemmonMedely @srausser
Use faster syntax
fb286f5 
Co-authored-by: Sam Rausser <[email protected]>
Signed-off-by: john.lemmon <[email protected]>
@JohnLemmonMedely
JohnLemmonMedely force-pushed the master branch from fe8c970 to fb286f5 Compare September 15, 2023 18:42
j1wonpark and others added 3 commits September 15, 2023 14:56
@j1wonpark @JohnLemmonMedely
feat: Apply cache to load proto registry for performance (feast-dev#3702
793a30f 
)

* fix: Remove unused parameter

Signed-off-by: Jiwon Park <[email protected]>

* feat: Apply cache to load proto registry for performance

Signed-off-by: Jiwon Park <[email protected]>

* fix: Fix update key when cache missed

Signed-off-by: phil-park <[email protected]>

---------

Signed-off-by: Jiwon Park <[email protected]>
Signed-off-by: phil-park <[email protected]>
@snowron @JohnLemmonMedely
feat: Add materialize and materialize-incremental rest endpoints (fea…
0d231aa 
…st-dev#3761)

* resolve feast-dev#3760

Signed-off-by: snowron <[email protected]>

* format feature_server.py

Signed-off-by: snowron <[email protected]>

---------

Signed-off-by: snowron <[email protected]>
@nickozilla @JohnLemmonMedely
feat: Add support for table_create_disposition in bigquery job for …
8338687 
…offline store (feast-dev#3762)

* Add bigquery table create disposition to offline store

Signed-off-by: Nick Zeolla <[email protected]>

* linting

Signed-off-by: Nick Zeolla <[email protected]>

---------

Signed-off-by: Nick Zeolla <[email protected]>
@JohnLemmonMedely JohnLemmonMedely mentioned this pull request Sep 18, 2023
feat: Add support for arrays in snowflake #3769
Merged
@JohnLemmonMedely

JohnLemmonMedely commented Sep 18, 2023

Copy link
Copy Markdown
Contributor Author

Closing in favor of #3769
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JohnLemmonMedely JohnLemmonMedely closed this Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sudohainguyen sudohainguyen Awaiting requested review from sudohainguyen sudohainguyen will be requested when the pull request is marked ready for review sudohainguyen is a code owner
1 more reviewer
@srausser srausser srausser left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Snowflake support does not include list features

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@JohnLemmonMedely @srausser @sfc-gh-madkins @j1wonpark @snowron @nickozilla
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.