GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — fix: UI project cannot handle fallback routes by snowron · Pull Request #3766 · feast-dev/feast

fix: UI project cannot handle fallback routes #3766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

adchia merged 2 commits into feast-dev:master from snowron:master

Oct 11, 2023

Uh oh!

There was an error while loading. Please reload this page.

Merged

fix: UI project cannot handle fallback routes #3766

Changes from all commits

Commits

Show all changes

2 commits

Select commit Hold shift + click to select a range

e36173c

fix: fallback route cannot navigate to react page

File filter

Filter by extension .py (1) All 1 file type selected

Viewed files

Clear filters

Conversations

Failed to load comments.

Uh oh!

There was an error while loading. Please reload this page.

Jump to

Jump to file

Failed to load files.

Uh oh!

There was an error while loading. Please reload this page.

Diff view

Unified

Split

Hide whitespace

Diff view

Unified

Split

Hide whitespace

There are no files selected for viewing

2 changes: 1 addition & 1 deletion 2 sdk/python/feast/ui_server.py

Show comments

View file

Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -77,7 +77,7 @@ def read_registry():
		# For all other paths (such as paths that would otherwise be handled by react router), pass to React
		@app.api_route("/p/{path_name:path}", methods=["GET"])
		def catch_all():
		filename = ui_dir + "index.html"
		filename = ui_dir.joinpath("index.html")

		with open(filename) as f:
		content = f.read()
Expand Down

Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.