GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Change error store to be part of configuration instead by zhilingc · Pull Request #39 · feast-dev/feast

Conversation

@zhilingc

@zhilingc zhilingc commented Jan 5, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

Fixes #27.

This change requires core to be deployed with the following additional configuration:

  • feast.jobs.errorsStoreType
  • feast.jobs.errorsStoreOptions

which define where (and how) to write the error logs of each ingestion job. These options are passed in as flags to the ingestion jar when a job is run. Internally to ingestion a storage spec is still used.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
zhilingc
Change error store to be part of configuration instead
60eb689
@zhilingc
zhilingc requested a review from tims January 5, 2019 01:45
@feast-ci-bot feast-ci-bot added the size/L label Jan 5, 2019
tims
tims suggested changes Jan 6, 2019
View reviewed changes
Comment thread ingestion/src/main/java/feast/storage/service/ErrorsStoreService.java Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread ingestion/src/main/java/feast/ingestion/boot/ImportJobModule.java Resolved

Uh oh!

There was an error while loading. Please reload this page.
@tims

tims commented Jan 6, 2019

Copy link
Copy Markdown
Contributor

We could change the [Error|Serving|Warehouse]Store classes to have factory in the name if that makes them make more sense. I just found it very verbose.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tims tims mentioned this pull request Jan 6, 2019
Toggle data stores using flags in feature specifications #38
Closed
zhilingc
Revert to provider providing list of error stores
def65b0
@zhilingc

zhilingc commented Jan 8, 2019

Copy link
Copy Markdown
Collaborator Author

/retest
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
zhilingc
Rebase with master
578003f
@zhilingc
zhilingc force-pushed the error-store-fix branch from 53f40fd to 578003f Compare January 8, 2019 07:46
@zhilingc

zhilingc commented Jan 8, 2019

Copy link
Copy Markdown
Collaborator Author

/retest
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@zhilingc

zhilingc commented Jan 8, 2019

Copy link
Copy Markdown
Collaborator Author

@tims
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
tims
tims reviewed Jan 9, 2019
View reviewed changes
Comment thread ingestion/src/main/java/feast/storage/service/ErrorsStoreService.java Outdated
public static List<ErrorsStore> getAll() {
return Lists.newArrayList(
Iterators.concat(manuallyRegistered.iterator(), serviceLoader.iterator()));
Iterators.concat(manuallyRegistered.iterator(), serviceLoader.iterator()));

@tims tims Jan 9, 2019

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is weird, are you using the google-java-format plugin or the imported googles styles xml?
https://github.com/google/styleguide/blob/gh-pages/intellij-java-google-style.xml

The imports don't get rearranged for me either.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@tims

tims commented Jan 9, 2019

Copy link
Copy Markdown
Contributor

Looks good except for formatting and import org, which need the google styles applied.
i.e: https://google.github.io/styleguide/javaguide.html#s3.3.3-import-ordering-and-spacing

If the google-java-format plugin neglects to org imports correctly. So instead, import the intellij styles.
https://github.com/google/styleguide/blob/gh-pages/intellij-java-google-style.xml
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tims

tims commented Jan 9, 2019

Copy link
Copy Markdown
Contributor

We should definitely merge this one before I merge this one before PR #52
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
tims
tims reviewed Jan 9, 2019
View reviewed changes
Comment thread ingestion/src/main/java/feast/ingestion/options/ImportJobOptions.java Resolved

Uh oh!

There was an error while loading. Please reload this page.
tims and others added 5 commits January 9, 2019 12:32
@tims
Merge branch 'master' into error-store-fix
7c916fc
@tims
merge master, reformat, align mocks stores to lowercase type
378ddcf
@zhilingc
Merge pull request #1 from tims/error-store-fix
3f6b2c7 
Error store fix
zhilingc
Remove extra parantheses
8578ba7
zhilingc
Format code to follow style
2b33f1f
@zhilingc

zhilingc commented Jan 9, 2019

Copy link
Copy Markdown
Collaborator Author

/assign pradithya
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@feast-ci-bot feast-ci-bot assigned pradithya Jan 9, 2019
zhilingc
Format code to follow style
7c07226
@tims

tims commented Jan 9, 2019

Copy link
Copy Markdown
Contributor

/approve
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@feast-ci-bot

feast-ci-bot commented Jan 9, 2019

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [tims]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@feast-ci-bot feast-ci-bot added the approved label Jan 9, 2019
@pradithya

pradithya commented Jan 9, 2019

Copy link
Copy Markdown
Collaborator

/lgtm
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@feast-ci-bot feast-ci-bot added the lgtm label Jan 9, 2019
@feast-ci-bot
feast-ci-bot merged commit 5ac4b9c into feast-dev:master Jan 9, 2019
@zhilingc
zhilingc deleted the error-store-fix branch January 14, 2019 09:42
Yanson pushed a commit to Yanson/feast that referenced this pull request Jul 29, 2020
@algattik
Databricks terraform module bugfix: removed workaround (feast-dev#39)
5b697f6 
Terraform provider issue databricks/terraform-provider-databricks#123 has been fixed, removing the workaround
dmartinol added a commit to dmartinol/feast that referenced this pull request Jul 10, 2024
@dmartinol
Merge pull request feast-dev#39 from dmartinol/feast-rbac-auth
847ae66 
Adding registry server (UT to be completed)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@tims tims tims requested changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@pradithya pradithya

Labels

approved lgtm size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@zhilingc @tims @feast-ci-bot @pradithya
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.