GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — fix: Move gRPC dependencies to an extra by cburroughs · Pull Request #3900 · feast-dev/feast

fix: Move gRPC dependencies to an extra #3900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

haoxu0 merged 1 commit into feast-dev:master from cburroughs:csb/grcpi-extras

Mar 6, 2024

Uh oh!

There was an error while loading. Please reload this page.

Merged

fix: Move gRPC dependencies to an extra #3900

Show file tree

Hide file tree

Changes from all commits

Commits

Show all changes

1 commit

Select commit

ef2d13c

fix: move gRPC dependencies to an extra

cburroughs Jan 24, 2024

File filter

Filter by extension .py (1) .sh (1) All 2 file types selected

Only manifest files

Viewed files

Clear filters

Conversations

Failed to load comments.

Uh oh!

There was an error while loading. Please reload this page.

Jump to

Jump to file

Failed to load files.

Uh oh!

There was an error while loading. Please reload this page.

Diff view

Unified

Split

Hide whitespace

Diff view

Unified

Split

Hide whitespace

There are no files selected for viewing

4 changes: 2 additions & 2 deletions 4 java/serving/src/test/resources/docker-compose/feast10/entrypoint.sh

Show comments

View file

Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -4,8 +4,8 @@ set -e

		# feast root directory is expected to be mounted (eg, by docker compose)
		cd /mnt/feast
		pip install -e '.[redis]'
		pip install -e '.[grpcio,redis]'

		cd /app
		python materialize.py
		feast serve_transformations --port 8080
		feast serve_transformations --port 8080

15 changes: 10 additions & 5 deletions 15 setup.py

Show comments

View file

Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -44,10 +44,6 @@
		"click>=7.0.0,<9.0.0",
		"colorama>=0.3.9,<1",
		"dill~=0.3.0",
		"grpcio>=1.56.2,<2",
		"grpcio-tools>=1.56.2,<2",
		"grpcio-reflection>=1.56.2,<2",
		"grpcio-health-checking>=1.56.2,<2",
		"mypy-protobuf==3.1",
		"Jinja2>=2,<4",
		"jsonschema",
Expand Down Expand Up		@@ -143,7 +139,14 @@

		IBIS_REQUIRED = [
		"ibis-framework",
		"ibis-substrait"
		"ibis-substrait",
		]

		GRPCIO_REQUIRED = [
		"grpcio>=1.56.2,<2",
		"grpcio-tools>=1.56.2,<2",
		"grpcio-reflection>=1.56.2,<2",
		"grpcio-health-checking>=1.56.2,<2",
		]

		CI_REQUIRED = (
Expand Down Expand Up		@@ -205,6 +208,7 @@
		+ ROCKSET_REQUIRED
		+ HAZELCAST_REQUIRED
		+ IBIS_REQUIRED
		+ GRPCIO_REQUIRED
		)


Expand Down Expand Up		@@ -371,6 +375,7 @@ def run(self):
		"docs": DOCS_REQUIRED,
		"cassandra": CASSANDRA_REQUIRED,
		"hazelcast": HAZELCAST_REQUIRED,
		"grpcio": GRPCIO_REQUIRED,
		"rockset": ROCKSET_REQUIRED,
		"ibis": IBIS_REQUIRED
		},
Expand Down

Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.