GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — chore: Loosen fsspec requirements to allow recent releases by cburroughs · Pull Request #3922 · feast-dev/feast

Conversation

@cburroughs

@cburroughs cburroughs commented Jan 31, 2024

Copy link
Copy Markdown
Contributor

(I'm not sure the project has a super consistent pattern for when to specify a maximum version, but was going for the smallest possible change.)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
cburroughs
cburroughs commented Jan 31, 2024
View reviewed changes
Comment thread setup.py
"minio==7.1.0",
"mock==2.0.0",
"moto",
"moto<5",

@cburroughs cburroughs Jan 31, 2024

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5 changed around the api and current tests do not pass without modification.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
tokoko reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

@tokoko tokoko Feb 3, 2024

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also stumbled into this, any idea why CI isn't failing as well?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@cburroughs cburroughs Feb 5, 2024

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect that some transitive dependency was previously holding it back.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@sudohainguyen sudohainguyen Feb 5, 2024

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moto v5 just released last week though, that's why CI succeeded

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@cburroughs
cburroughs force-pushed the csb/fsspec-loosen branch from 9f780a4 to 730e720 Compare January 31, 2024 21:18
@sudohainguyen

sudohainguyen commented Feb 1, 2024

Copy link
Copy Markdown
Collaborator

the last time we updated fsspec (from my commits), I got stuck when compiling by pyarrow deps.
But now we upgraded pyarrow successfully and It's fine to upgrade fsspec 🙌
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cburroughs
cburroughs force-pushed the csb/fsspec-loosen branch 2 times, most recently from 3ed7e10 to 2a71a61 Compare February 5, 2024 15:14
@sudohainguyen sudohainguyen added the ok-to-test label Feb 7, 2024
@cburroughs

cburroughs commented Feb 7, 2024

Copy link
Copy Markdown
Contributor Author

What does this PR need to move forward?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sudohainguyen

sudohainguyen commented Feb 8, 2024

Copy link
Copy Markdown
Collaborator

Just wanted to do integration tests since this issue is related to dependencies.

So closing this now? 🤔
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
cburroughs added 2 commits February 14, 2024 16:28
@cburroughs
chore: Loosen fsspec requirements to allow recent releases
d86c5df 
(I'm not sure the project has a super consistent pattern for when to
specify a maximum version, but was going for the smallest possible
change.)

Signed-off-by: Chris Burroughs <[email protected]>
@cburroughs
drop redundant fsspec now that this is in another extra
0397994 
Signed-off-by: Chris Burroughs <[email protected]>
@cburroughs
cburroughs force-pushed the csb/fsspec-loosen branch from 2a71a61 to 0786e44 Compare February 14, 2024 22:14
@cburroughs

cburroughs commented Feb 14, 2024

Copy link
Copy Markdown
Contributor Author

cc @franciscojavierarceo per dev call
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cburroughs
post rebase regen
d6e312f 
Signed-off-by: Chris Burroughs <[email protected]>
@cburroughs
cburroughs force-pushed the csb/fsspec-loosen branch from 0786e44 to d6e312f Compare February 14, 2024 22:15
franciscojavierarceo
franciscojavierarceo approved these changes Feb 14, 2024
View reviewed changes

@franciscojavierarceo franciscojavierarceo left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@franciscojavierarceo
franciscojavierarceo merged commit 5c9f592 into feast-dev:master Feb 14, 2024
tqtensor pushed a commit to tqtensor/feast that referenced this pull request Mar 11, 2024
@cburroughs @tqtensor
chore: Loosen fsspec requirements to allow recent releases (feast-dev…
8d11e9a 
…#3922)

* chore: Loosen fsspec requirements to allow recent releases

(I'm not sure the project has a super consistent pattern for when to
specify a maximum version, but was going for the smallest possible
change.)

Signed-off-by: Chris Burroughs <[email protected]>

* drop redundant fsspec now that this is in another extra

Signed-off-by: Chris Burroughs <[email protected]>

* post rebase regen

Signed-off-by: Chris Burroughs <[email protected]>

---------

Signed-off-by: Chris Burroughs <[email protected]>
cburroughs added a commit to cburroughs/feast that referenced this pull request Aug 28, 2024
@cburroughs
chore: Remove upper bound from fsspec requirement
0a7c836 
In feast-dev#3922 the fsspec requirement was loosened to allow what was then
more recent releases.  Since then Feast has further reduced the
number dependencies with upper bounds.  Instead of re-testing each
month (when fsspec usually releases) it would now be idiomatic only
specify a minimum bound.

The new minimum bound was chosen to match what was last locked in ci,
since that is what was tested and we can be less sure older versions
also work.

Signed-off-by: Chris Burroughs <[email protected]>
@cburroughs cburroughs mentioned this pull request Aug 28, 2024
chore: Remove upper bound from fsspec requirement #4461
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tokoko tokoko tokoko left review comments
@sudohainguyen sudohainguyen sudohainguyen left review comments
@franciscojavierarceo franciscojavierarceo franciscojavierarceo approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@cburroughs @sudohainguyen @franciscojavierarceo @tokoko
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.