GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — chore: Set upper bound for moto package by sudohainguyen · Pull Request #3937 · feast-dev/feast

Conversation

@sudohainguyen

@sudohainguyen sudohainguyen commented Feb 7, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

What this PR does / why we need it: moto package just recently released version 5.0.0 with some breaking changes, which potentially break our integration tests, so that the upper bound for the package is needed

Which issue(s) this PR fixes:

N/A

Note: no need to re-compile requirements files since moto is still <5

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sudohainguyen
chore: set upper bound for moto package
0948ae1 
Signed-off-by: Hai Nguyen <[email protected]>
@sudohainguyen sudohainguyen changed the title chore: set upper bound for moto package chore: Set upper bound for moto package Feb 7, 2024
@sudohainguyen sudohainguyen added the ok-to-test label Feb 7, 2024
@sudohainguyen
sudohainguyen requested a review from haoxu0 February 7, 2024 02:33
@haoxu0

haoxu0 commented Feb 7, 2024

Copy link
Copy Markdown
Collaborator

Lint failed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sudohainguyen

sudohainguyen commented Feb 7, 2024

Copy link
Copy Markdown
Collaborator Author

Lint failed

hmm I'm seeing all checks passed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@haoxu0

haoxu0 commented Feb 7, 2024

Copy link
Copy Markdown
Collaborator

Lint failed

hmm I'm seeing all checks passed

I'm seeing this one failed: https://github.com/feast-dev/feast/actions/runs/7809136271/job/21300448191#step:2:1,
Is it staled?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sudohainguyen

sudohainguyen commented Feb 7, 2024

Copy link
Copy Markdown
Collaborator Author

Lint failed

hmm I'm seeing all checks passed

I'm seeing this one failed: https://github.com/feast-dev/feast/actions/runs/7809136271/job/21300448191#step:2:1, Is it staled?

yeah it is staled, already fixed 😄
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
haoxu0
haoxu0 approved these changes Feb 7, 2024
View reviewed changes

@haoxu0 haoxu0 left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@haoxu0

haoxu0 commented Feb 7, 2024

Copy link
Copy Markdown
Collaborator

Lint failed

hmm I'm seeing all checks passed

I'm seeing this one failed: https://github.com/feast-dev/feast/actions/runs/7809136271/job/21300448191#step:2:1, Is it staled?

yeah it is staled, already fixed 😄

yeah staled on my phone lol
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@haoxu0
haoxu0 merged commit b4aed65 into feast-dev:master Feb 7, 2024
zseta pushed a commit to zseta/feast that referenced this pull request Feb 7, 2024
@sudohainguyen @zseta
chore: Set upper bound for moto package (feast-dev#3937)
c646d03 
chore: set upper bound for moto package

Signed-off-by: Hai Nguyen <[email protected]>
Signed-off-by: Attila Toth <[email protected]>
@sudohainguyen
sudohainguyen deleted the moto branch February 8, 2024 03:48
tqtensor pushed a commit to tqtensor/feast that referenced this pull request Mar 11, 2024
@sudohainguyen @tqtensor
chore: Set upper bound for moto package (feast-dev#3937)
f50c5ed 
chore: set upper bound for moto package

Signed-off-by: Hai Nguyen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@haoxu0 haoxu0 haoxu0 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@sudohainguyen @haoxu0
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.