GeezerVison is showing github.com — fix: Swap security label check on the PR title validation job to explicit permissions instead by jeremyary · Pull Request #3987 · feast-dev/feast
Conversation
jeremyary
commented
Mar 5, 2024
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
What this PR does / why we need it:
After recently adding security label checks to all pull_request_target actions that were missing it, I noticed title validation checkjs started being skipped due to the conditional paired with this trigger type. This PR takes the check logic back to the simple repo verify, but adds explicit read-only permissions matching the recommended install configuration.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
haoxu0
pushed a commit
that referenced
this pull request
Mar 9, 2024
…icit permissions instead (#3987)
revert security label check for PR title validation & add explicit read-only permission instead
Signed-off-by: Jeremy Ary <[email protected]>
haoxu0
added a commit
that referenced
this pull request
Mar 9, 2024
* fix: remove not use input parameter in spark source (#3980)
remove unused parameter when init sparksource
Signed-off-by: tanlocnguyen <[email protected]>
Co-authored-by: tanlocnguyen <[email protected]>
* fix: Added registryPath parameter documentation in WebUI reference (#3983)
* fix: Added registryPath parameter documentation
Added a note in Webui reference in regard to supported registryPath values
Related to #3974
Signed-off-by: Theodor Mihalache <[email protected]>
* fix: Added registryPath parameter documentation
Added a note in Webui reference in regard to supported registryPath values
Related to #3974
Signed-off-by: Theodor Mihalache <[email protected]>
---------
Signed-off-by: Theodor Mihalache <[email protected]>
* fix: Get container host addresses from testcontainers (#3946)
* fix: get container host addresses from testcontainers
Signed-off-by: tokoko <[email protected]>
* resolve trino container host with testcontainers
Signed-off-by: tokoko <[email protected]>
---------
Signed-off-by: tokoko <[email protected]>
* fix: Swap security label check on the PR title validation job to explicit permissions instead (#3987)
revert security label check for PR title validation & add explicit read-only permission instead
Signed-off-by: Jeremy Ary <[email protected]>
* feat: Add Entity df in format of a Spark Dataframe instead of just pd.DataFrame or string for SparkOfflineStore (#3988)
* remove unused parameter when init sparksource
Signed-off-by: tanlocnguyen <[email protected]>
* feat: add entity df to SparkOfflineStore when get_historical_features
Signed-off-by: tanlocnguyen <[email protected]>
* fix: lint error
Signed-off-by: tanlocnguyen <[email protected]>
---------
Signed-off-by: tanlocnguyen <[email protected]>
Co-authored-by: tanlocnguyen <[email protected]>
* feat: Dropping unit tests for Python 3.8 (#3989)
feat: dropping unit tests for Python 3.8
Update unit_tests.yml to no longer run for Python 3.8
Signed-off-by: franciscojavierarceo <[email protected]>
* fix: Move gRPC dependencies to an extra (#3900)
* chore: Bump ip from 1.1.5 to 1.1.9 in /ui (#3959)
* chore: Update readme spark.md (#3992)
update readme spark.md
Signed-off-by: tanlocnguyen <[email protected]>
Co-authored-by: tanlocnguyen <[email protected]>
* feat: Dropping Python 3.8 from local integration tests and integration tests (#3994)
* fix: Handle ComplexFeastType to None comparison (#3876)
Signed-off-by: Aliaksandr Sasnouskikh <[email protected]>
* feat: Add python client for remote registry server (#3941)
* add remote registry
Signed-off-by: tokoko <[email protected]>
* format and lint remote registry code
Signed-off-by: tokoko <[email protected]>
* add read-only registry exception
Signed-off-by: tokoko <[email protected]>
---------
Signed-off-by: tokoko <[email protected]>
---------
Signed-off-by: tanlocnguyen <[email protected]>
Signed-off-by: Theodor Mihalache <[email protected]>
Signed-off-by: tokoko <[email protected]>
Signed-off-by: Jeremy Ary <[email protected]>
Signed-off-by: franciscojavierarceo <[email protected]>
Signed-off-by: Aliaksandr Sasnouskikh <[email protected]>
Co-authored-by: locnt241 <[email protected]>
Co-authored-by: tanlocnguyen <[email protected]>
Co-authored-by: Theodor Mihalache <[email protected]>
Co-authored-by: Tornike Gurgenidze <[email protected]>
Co-authored-by: Jeremy Ary <[email protected]>
Co-authored-by: Francisco Javier Arceo <[email protected]>
Co-authored-by: cburroughs <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Alex Sasnouskikh <[email protected]>
tqtensor
pushed a commit
to tqtensor/feast
that referenced
this pull request
Mar 11, 2024
…icit permissions instead (feast-dev#3987)
revert security label check for PR title validation & add explicit read-only permission instead
Signed-off-by: Jeremy Ary <[email protected]>
Reviewers
haoxu0
haoxu0 approved these changes
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.