GeezerVison

Original file line number	Diff line number	Diff line change
Expand Up		@@ -752,7 +752,7 @@ def _non_empty_value(value: Any) -> bool:

		def spark_to_feast_value_type(spark_type_as_str: str) -> ValueType:
		# TODO not all spark types are convertible
		# Current non-convertible types: interval, map, struct, structfield, decimal, binary
		# Current non-convertible types: interval, map, struct, structfield, binary
		type_map: Dict[str, ValueType] = {
		"null": ValueType.UNKNOWN,
		"byte": ValueType.BYTES,
Expand All		@@ -762,6 +762,7 @@ def spark_to_feast_value_type(spark_type_as_str: str) -> ValueType:
		"bigint": ValueType.INT64,
		"long": ValueType.INT64,
		"double": ValueType.DOUBLE,
		"decimal": ValueType.DOUBLE,
		"float": ValueType.FLOAT,
		"boolean": ValueType.BOOL,
		"timestamp": ValueType.UNIX_TIMESTAMP,
Expand All		@@ -770,10 +771,15 @@ def spark_to_feast_value_type(spark_type_as_str: str) -> ValueType:
		"array<int>": ValueType.INT32_LIST,
		"array<bigint>": ValueType.INT64_LIST,
		"array<double>": ValueType.DOUBLE_LIST,
		"array<decimal>": ValueType.DOUBLE_LIST,
		"array<float>": ValueType.FLOAT_LIST,
		"array<boolean>": ValueType.BOOL_LIST,
		"array<timestamp>": ValueType.UNIX_TIMESTAMP_LIST,
		}
		if spark_type_as_str.startswith("decimal"):
		spark_type_as_str = "decimal"
		if spark_type_as_str.startswith("array<decimal"):
		spark_type_as_str = "array<decimal>"
		# TODO: Find better way of doing this.
		if not isinstance(spark_type_as_str, str) or spark_type_as_str not in type_map:
		return ValueType.NULL
Expand Down

Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.