GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — chore: Adjusting the file version validation for minor releases by franciscojavierarceo · Pull Request #4221 · feast-dev/feast

Conversation

@franciscojavierarceo

@franciscojavierarceo franciscojavierarceo commented May 23, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

What this PR does / why we need it:

This is changing the validation to ignore patch version changes. So the CI should trigger correctly for increments from 0.37.1 -> 0.38.0.

python infra/scripts/release/bump_file_versions.py 0.37.0 0.38.0
Updated 16 files with new version 0.38.0

Previously this failed as 0.37.1 wasn't recognized as a tag.

Which issue(s) this PR fixes:

Fixes

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@franciscojavierarceo
adjusting the validation for branch updates
f436d89 
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo franciscojavierarceo changed the title chore: adjusting the file version validation for minor releases chore: Adjusting the file version validation for minor releases May 23, 2024
@franciscojavierarceo
franciscojavierarceo requested review from haoxu0, jeremyary, shuchu, sudohainguyen and tokoko May 23, 2024 21:50
@sudohainguyen sudohainguyen added the ok-to-test label May 24, 2024
sudohainguyen
sudohainguyen approved these changes May 24, 2024
View reviewed changes

@sudohainguyen sudohainguyen left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 😄

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
tokoko
tokoko reviewed May 24, 2024
View reviewed changes

@tokoko tokoko left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Despite validation, this is still not going to work, as line 48 looks for the passed current_version to replace in files. I think much easier solution is to simply revert version bumps.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@franciscojavierarceo

franciscojavierarceo commented May 24, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Despite validation, this is still not going to work, as line 48 looks for the passed current_version to replace in files. I think much easier solution is to simply revert version bumps.

The version bumps are automatically generated through this code. Are you suggesting we do that for every patch release @tokoko?

Also, I'll fix line 48.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tokoko

tokoko commented May 24, 2024

Copy link
Copy Markdown
Collaborator

@franciscojavierarceo No, version bumps to 0.37.1 was automatic, but not on master, it was done on v-0.37-branch. We manually introduced those version bumps to master with a later PR (#4127) which was a mistake. I don't mind if we scrap validation from the scripts either, just pointing out that it's unnecessary if we simply revert some of the changes from that PR (version bumps specifically).
franciscojavierarceo reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@franciscojavierarceo

franciscojavierarceo commented May 24, 2024

Copy link
Copy Markdown
Member Author

We manually introduced those version bumps to master with a later PR (#4127) which was a mistake.

Got it! I missed this, my bad. Lack of sleep 🥲 .
tokoko reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@franciscojavierarceo
updated to get parsed version
054eaca 
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo franciscojavierarceo mentioned this pull request May 24, 2024
chore: Revert 371 bump #4227
Merged
@franciscojavierarceo

franciscojavierarceo commented May 24, 2024

Copy link
Copy Markdown
Member Author

@tokoko #4227
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@franciscojavierarceo
franciscojavierarceo merged commit fffc366 into master May 24, 2024
franciscojavierarceo added a commit that referenced this pull request May 27, 2024
@franciscojavierarceo
chore: Adjusting the file version validation for minor releases (#4221)
9f1b65f 
* adjusting the validation for branch updates

Signed-off-by: Francisco Javier Arceo <[email protected]>

* updated to get parsed version

Signed-off-by: Francisco Javier Arceo <[email protected]>

---------

Signed-off-by: Francisco Javier Arceo <[email protected]>
@tokoko
tokoko deleted the version-validation-patch branch July 16, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tokoko tokoko tokoko left review comments
@sudohainguyen sudohainguyen sudohainguyen approved these changes
@jeremyary jeremyary Awaiting requested review from jeremyary
@shuchu shuchu Awaiting requested review from shuchu
@haoxu0 haoxu0 Awaiting requested review from haoxu0

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@franciscojavierarceo @tokoko @sudohainguyen
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.