GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: Escape special characters in the Postgres password (#4394) by job-almekinders · Pull Request #4396 · feast-dev/feast

Conversation

@job-almekinders

@job-almekinders job-almekinders commented Aug 9, 2024

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

This PR cherry-picks a fix commit to properly parse special characters in Postgres passwords.

More information can be found in the original PR.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@job-almekinders
fix: Escape special characters in the Postgres password (feast-dev#4394)
03954da 
* Apply fix

Signed-off-by: Job Almekinders <[email protected]>

* Add special characters to postgres online store test

Signed-off-by: Job Almekinders <[email protected]>

* Fix linting error

Signed-off-by: Job Almekinders <[email protected]>

---------

Signed-off-by: Job Almekinders <[email protected]>
@tokoko tokoko added the ok-to-test label Aug 9, 2024
@job-almekinders

job-almekinders commented Aug 9, 2024

Copy link
Copy Markdown
Contributor Author

I don't understand why the java integration test is failing; is this an unrelated issue perhaps?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tokoko

tokoko commented Aug 9, 2024

Copy link
Copy Markdown
Collaborator

yeah, it's unrelated #4381. we can merge regardless
job-almekinders reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tokoko
tokoko merged commit b456984 into feast-dev:v0.40-branch Aug 9, 2024
franciscojavierarceo pushed a commit that referenced this pull request Aug 9, 2024
@feast-ci-bot
chore(release): release 0.40.1
00be7b0 
## [0.40.1](v0.40.0...v0.40.1) (2024-08-09)

### Bug Fixes

* Add feast-operator files to semantic-release script (v0.40-branch) ([#4383](#4383)) ([44f0e84](44f0e84))
* Escape special characters in the Postgres password ([#4394](#4394)) ([#4396](#4396)) ([b456984](b456984))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@job-almekinders @tokoko
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.