GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — chore: Migrate from setup.py to pyproject.toml by tokoko · Pull Request #4478 · feast-dev/feast

Conversation

@tokoko

@tokoko tokoko commented Sep 3, 2024

Copy link
Copy Markdown
Collaborator
  • Migrates most of setup.py configuration to pyproject.toml in line with PEP 518
  • Some misc changes to suppress linter issues in tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@tokoko
chore: migrate to pyproject.toml
1eccad3 
Signed-off-by: tokoko <[email protected]>
@tokoko tokoko added the ok-to-test label Sep 3, 2024
franciscojavierarceo
franciscojavierarceo reviewed Sep 3, 2024
View reviewed changes
Comment thread environment-setup.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@tokoko
fix: remove env setup reference from development guide
cea6be8 
Signed-off-by: tokoko <[email protected]>
franciscojavierarceo
franciscojavierarceo reviewed Sep 3, 2024
View reviewed changes
Comment thread setup.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@franciscojavierarceo

franciscojavierarceo commented Sep 3, 2024

Copy link
Copy Markdown
Member

It'd probably be ideal to have #4344 done before merging this, yeah?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
haoxu0
haoxu0 reviewed Sep 3, 2024
View reviewed changes
Comment thread pyproject.toml Resolved

Uh oh!

There was an error while loading. Please reload this page.
tokoko added 4 commits September 10, 2024 07:32
@tokoko
add cli import test with pixi
95c1f61 
Signed-off-by: tokoko <[email protected]>
@tokoko
fix pixi install in gh actions
50d370b 
Signed-off-by: tokoko <[email protected]>
@tokoko
fix pixi install in gh actions
c334e44 
Signed-off-by: tokoko <[email protected]>
@tokoko
remove duplicate virtualenv dependency
a46f9c3 
Signed-off-by: tokoko <[email protected]>
@redhatHameed

redhatHameed commented Sep 12, 2024

Copy link
Copy Markdown
Contributor

@tokoko clarification,I have one task on my to-do list related to this conversation-> #4380 (comment) do you think it's still valid after this PR change. Thanks
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tokoko

tokoko commented Sep 13, 2024

Copy link
Copy Markdown
Collaborator Author

@redhatHameed yup, that's still valid. this PR only changes where requirements are defined, nothing else.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tokoko tokoko mentioned this pull request Sep 18, 2024
Running feast version command throw error #4532
Closed
@stale

stale Bot commented Apr 26, 2025

Copy link
Copy Markdown

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@stale stale Bot added the wontfix This will not be worked on label Apr 26, 2025
@stale stale Bot closed this May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@franciscojavierarceo franciscojavierarceo franciscojavierarceo left review comments
@haoxu0 haoxu0 haoxu0 left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

ok-to-test wontfix This will not be worked on

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@tokoko @franciscojavierarceo @redhatHameed @haoxu0
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.