GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — chore: Updated tests to confirm behavior of inconsistent offline/online return values by franciscojavierarceo · Pull Request #4615 · feast-dev/feast

Conversation

@franciscojavierarceo

@franciscojavierarceo franciscojavierarceo commented Oct 10, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

What this PR does / why we need it:

This PR updates get_historical_features to return the requested set of features when ODFVs are called as get_online_features.

As outlined in #4479, get_historical_features returns more features than what is requested when an ODFV is requested.

This PR updates:

  1. The tests to verify that get_historical_features when calling an ODFV returns only the fields requested
  2. The tests to verify that an ODFV will result in an error when get_historical_features is called with an entity that does not have data to calculate an ODFV
  3. The code to properly return only the requested features in get_historical_features

Which issue(s) this PR fixes:

#4479

Misc

N/A

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@franciscojavierarceo franciscojavierarceo mentioned this pull request Oct 10, 2024
OnDemandFeatureViews with RequestSource returns different columns depending on online/offline feature retrieval. #4479
Closed
franciscojavierarceo added 2 commits October 10, 2024 16:48
@franciscojavierarceo
merged from rebase
4bcc343 
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
updated test
09dee27 
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
franciscojavierarceo force-pushed the odfv-request-source-bug branch from 9f0b585 to 09dee27 Compare October 10, 2024 20:49
franciscojavierarceo added 2 commits October 14, 2024 16:48
@franciscojavierarceo
updating test to confirm behavior
2baa645 
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
adding stored writes feature view back in
0aef65d 
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
franciscojavierarceo requested review from haoxu0, jeremyary and shuchu October 15, 2024 01:39
haoxu0
haoxu0 approved these changes Oct 15, 2024
View reviewed changes

@haoxu0 haoxu0 left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@franciscojavierarceo
franciscojavierarceo enabled auto-merge (squash) October 15, 2024 01:56
@franciscojavierarceo franciscojavierarceo added the ok-to-test label Oct 15, 2024
@franciscojavierarceo
franciscojavierarceo merged commit 95fe8c2 into master Oct 15, 2024
robhowley pushed a commit to robhowley/feast that referenced this pull request Oct 16, 2024
@franciscojavierarceo @robhowley
chore: Updated tests to confirm behavior of inconsistent offline/onli…
02c9d8e 
…ne return values (feast-dev#4615)
robhowley pushed a commit to robhowley/feast that referenced this pull request Oct 17, 2024
@franciscojavierarceo @robhowley
chore: Updated tests to confirm behavior of inconsistent offline/onli…
a71fa1f 
…ne return values (feast-dev#4615)

Signed-off-by: Rob Howley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@haoxu0 haoxu0 haoxu0 approved these changes
@shuchu shuchu Awaiting requested review from shuchu
@jeremyary jeremyary Awaiting requested review from jeremyary

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@franciscojavierarceo @haoxu0
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.