GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — feat: Adding github action to run the operator end-to-end tests. by lokeshrangineni · Pull Request #4762 · feast-dev/feast

feat: Adding github action to run the operator end-to-end tests. #4762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

franciscojavierarceo merged 1 commit into feast-dev:master from lokeshrangineni:feature/operator-action-e2e-test

Nov 15, 2024

Uh oh!

There was an error while loading. Please reload this page.

Merged

feat: Adding github action to run the operator end-to-end tests. #4762

Show file tree

Hide file tree

Changes from all commits

Commits

Show all changes

1 commit

Select commit

3638676

Adding github action to do the operator end-to-end testing. This acti…

lokeshrangineni Nov 15, 2024

File filter

Filter by extension .go (1) .yml (1) All 2 file types selected

Only manifest files

Viewed files

Clear filters

Conversations

Failed to load comments.

Uh oh!

There was an error while loading. Please reload this page.

Jump to

Jump to file

Failed to load files.

Uh oh!

There was an error while loading. Please reload this page.

Diff view

Unified

Split

Hide whitespace

Diff view

Unified

Split

Hide whitespace

There are no files selected for viewing

58 changes: 58 additions & 0 deletions 58 .github/workflows/operator-e2e-integration-tests.yml

Show comments

View file

Open in desktop

Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,58 @@
		# .github/workflows/operator-e2e-integration-tests.yml
		name: Operator e2e tests

		on:
		push:
		branches:
		- main
		pull_request:
		types:
		- opened
		- synchronize
		- labeled

		jobs:
		operator-e2e-tests:
		if:
		((github.event.action == 'labeled' && (github.event.label.name == 'approved' \|\| github.event.label.name == 'lgtm' \|\| github.event.label.name == 'ok-to-test')) \|\|
		(github.event.action != 'labeled' && (contains(github.event.pull_request.labels..name, 'ok-to-test') \|\| contains(github.event.pull_request.labels..name, 'approved') \|\| contains(github.event.pull_request.labels.*.name, 'lgtm')))) &&
		github.repository == 'feast-dev/feast'
		runs-on: ubuntu-latest

		services:
		kind:
		# Specify the Kubernetes version
Comment thread franciscojavierarceo Nov 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page. Copy link Copy Markdown Member There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. is this the Kind version or the Kubernetes version? Sorry, something went wrong. Uh oh! There was an error while loading. Please reload this page. All reactions lokeshrangineni Nov 15, 2024 Copy link Copy Markdown Contributor Author There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. kind version, my understanding is each kind image version is having associated k8 version. Sorry, something went wrong. Uh oh! There was an error while loading. Please reload this page. franciscojavierarceo reacted with thumbs up emoji All reactions 👍 1 reaction lokeshrangineni Nov 15, 2024 Copy link Copy Markdown Contributor Author There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. I have revalidated again, each kind image version is mapped to the same kubernetes version. Sorry, something went wrong. Uh oh! There was an error while loading. Please reload this page. All reactions
		image: kindest/node:v1.30.6

		env:
		KIND_CLUSTER: "operator-e2e-cluster"

		steps:
		- name: Checkout code
		uses: actions/checkout@v4

		- name: Set up Go
		uses: actions/setup-go@v5
		with:
		go-version: '1.21.0'

		- name: Create KIND cluster
		run: \|
		kind create cluster --name $KIND_CLUSTER --wait 5m

		- name: Set up kubernetes context
		run: \|
		kubectl config use-context kind-$KIND_CLUSTER
		echo "kind context is switched to cluster kind-$KIND_CLUSTER"

		- name: Run E2E tests
		run: \|
		# Run the e2e tests
		cd infra/feast-operator/
		make test-e2e

		- name: Clean up
		if: always()
		run: \|
		# Delete the KIND cluster after tests
		kind delete cluster --name kind-$KIND_CLUSTER

1 change: 1 addition & 0 deletions 1 infra/feast-operator/test/utils/utils.go

Show comments

View file

Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -109,6 +109,7 @@ func LoadImageToKindClusterWithName(name string) error {
		if v, ok := os.LookupEnv("KIND_CLUSTER"); ok {
		cluster = v
		}
		fmt.Println("cluster used in the test is -", cluster)
		kindOptions := []string{"load", "docker-image", name, "--name", cluster}
		cmd := exec.Command("kind", kindOptions...)
		_, err := Run(cmd)
Expand Down

Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

feat: Adding github action to run the operator end-to-end tests. #4762

Uh oh!

feat: Adding github action to run the operator end-to-end tests. #4762

Uh oh!

Uh oh!

Diff view

Diff view

There are no files selected for viewing

franciscojavierarceo Nov 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lokeshrangineni Nov 15, 2024

Choose a reason for hiding this comment

Uh oh!

lokeshrangineni Nov 15, 2024

Choose a reason for hiding this comment

Uh oh!

franciscojavierarceo Nov 15, 2024 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.