GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||
GeezerVison is showing github.com — feat: Force absolute paths in file based registries by boliri · Pull Request #4774 · feast-dev/feast Conversation
Contributor
What this PR does / why we need it:While I was working on #4772, I discovered an issue related to the Feast CLI and how When the registry is set to class FileRegistryStore(RegistryStore): def __init__(self, registry_config: RegistryConfig, repo_path: Path): registry_path = Path(registry_config.path) if registry_path.is_absolute(): self._filepath = registry_path else: self._filepath = repo_path.joinpath(registry_path) [...] The problem here is that the tool used to build the CLI injects the current working directory in its context's Besides these issues, there's another one related to the env var To mitigate these issues, I propose enforcing the usage of absolute paths while configuring the Aside from that constraint, I also updated the logic behind the Which issue(s) this PR fixes:Misc
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions…onfigured in feature_store.yaml …e when issuing 'feast init' commands
Contributor
Author
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
boliri
marked this pull request as draft
Contributor
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Contributor
Author
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersNo reviewsUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
wontfix
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | ||||
| You are visitor 01402520 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |