GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: Read project data from the 'projects' key while loading the registry state in the Feast UI by boliri · Pull Request #4772 · feast-dev/feast

Conversation

@boliri

@boliri boliri commented Nov 20, 2024

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

Starting from 0.41.x releases, the Feast UI is no longer able to load the project summary in the projects overview / landing page. The reason why this is happening is that, after some changes from #4475 got merged into master, the Registry class is unable to build and persist the project's metadata to the backend used as the registry through its method _prepare_registry_for_changes - this behavior has been observed in, at least, the file registry, but it might be applicable to others as well.

Since project's metadata is not generated, and the useLoadRegistry function from the UI is expecting those metadata to exist, the UI fails to render the Project Overview page and hints that the issue might be in the feature_store.yaml, which is not the case.

The purpose of this PR is pretty simple: make the UI extract the project information from the projects array instead of the projectMetadata object while it is refreshing the registry state. With this tiny fix in place, the UI renders components as usual.

Which issue(s) this PR fixes:

Fixes #4743

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@boliri
boliri requested a review from a team as a code owner November 20, 2024 12:32
@boliri
boliri force-pushed the fix/ui/read-project-data-from-projects-key-while-loading-registry-state branch from e4540d1 to 8bb1156 Compare November 20, 2024 12:47
@boliri

boliri commented Nov 20, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

I regenerated the registry.db file locally and, after running yarn test, the UI tests passed without issues. However, there's still something wrong in the GitHub Action for these tests as it cannot finish properly:

Error: src/FeastUISansProviders.test.tsx(58,5): error TS2533: Object is possibly 'null' or 'undefined'.
Error: src/queries/useLoadRegistry.ts(55,22): error TS2533: Object is possibly 'null' or 'undefined'.

This might be related to how the proto representation of the Registry is decoded in the UI tests, but I'm not 100% sure.

Thoughts?

EDIT: made some changes to the useLoadRegistry and UI tests are finally passing, but for some reason the job build-docker-image-java won't start 😕
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@boliri boliri mentioned this pull request Nov 20, 2024
feat: Force absolute paths in file based registries #4774
Closed
boliri added 3 commits November 21, 2024 10:54
@boliri
fix: Read project data from the 'projects' key while loading the regi…
98b02c0 
…stry state in the Feast UI

Signed-off-by: boliri <[email protected]>
@boliri
fix: regenerate registry file so that UI tests can parse the 'project…
c5d0dff 
…s' object

Signed-off-by: boliri <[email protected]>
@boliri
fix: Check for non-null and non-undefined spec of a project to mitiga…
c0f6f93 
…te errors in UI builds

Signed-off-by: boliri <[email protected]>
@boliri
boliri force-pushed the fix/ui/read-project-data-from-projects-key-while-loading-registry-state branch from 2c09fea to c0f6f93 Compare November 21, 2024 09:55
franciscojavierarceo
franciscojavierarceo approved these changes Dec 23, 2024
View reviewed changes
@franciscojavierarceo franciscojavierarceo added the ok-to-test label Dec 23, 2024
@boliri

boliri commented Jan 2, 2025

Copy link
Copy Markdown
Contributor Author

Just a reminder: seems like the Python integration tests job failed, might be related to an execution timeout.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@redhatHameed

redhatHameed commented Jan 21, 2025

Copy link
Copy Markdown
Contributor

@franciscojavierarceo can we merge this
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@redhatHameed redhatHameed mentioned this pull request Jan 21, 2025
feat: Operator add feast ui deployment #4930
Merged
redhatHameed
redhatHameed approved these changes Jan 21, 2025
View reviewed changes
@redhatHameed
redhatHameed merged commit cb81939 into feast-dev:master Jan 21, 2025
franciscojavierarceo pushed a commit that referenced this pull request Feb 4, 2025
@feast-ci-bot
chore(release): release 0.44.0
aa7224a 
# [0.44.0](v0.43.0...v0.44.0) (2025-02-04)

### Bug Fixes

* Adding periodic check to fix the sporadic failures of the operator e2e tests.  ([#4952](#4952)) ([1d086be](1d086be))
* Adding the feast-operator/bin to the .gitignore directory. Somehow it… ([#5005](#5005)) ([1a027ee](1a027ee))
* Changed Env Vars for e2e tests ([#4975](#4975)) ([fa0084f](fa0084f))
* Fix GitHub Actions to pass authentication ([#4963](#4963)) ([22b9138](22b9138)), closes [#4937](#4937) [#4939](#4939) [#4941](#4941) [#4940](#4940) [#4943](#4943) [#4944](#4944) [#4945](#4945) [#4946](#4946) [#4947](#4947) [#4948](#4948) [#4951](#4951) [#4954](#4954) [#4957](#4957) [#4958](#4958) [#4959](#4959) [#4960](#4960) [#4962](#4962)
* Fix showing selected navigation item in UI sidebar ([#4969](#4969)) ([8ac6a85](8ac6a85))
* Invalid column names in get_historical_features when there are field mappings on join keys ([#4886](#4886)) ([c9aca2d](c9aca2d))
* Read project data from the 'projects' key while loading the registry state in the Feast UI ([#4772](#4772)) ([cb81939](cb81939))
* Remove grpcurl dependency from Operator ([#4972](#4972)) ([439e0b9](439e0b9))
* Removed the dry-run flag to test and we will add it back later. ([#5007](#5007)) ([d112b52](d112b52))
* Render UI navigation items as links instead of buttons ([#4970](#4970)) ([1267703](1267703))
* Resolve Operator CRD bloat due to long field descriptions ([#4985](#4985)) ([7593bb3](7593bb3))
* Update manifest to add feature server image for odh ([#4973](#4973)) ([6a1c102](6a1c102))
* Updating release workflows to refer to yml instead of yaml ([#4935](#4935)) ([02b0a68](02b0a68))
* Use locally built feast-ui package in dev feature-server image ([#4998](#4998)) ([0145e55](0145e55))

### Features

* Added OWNERS file for OpenshiftCI ([#4991](#4991)) ([86a2ee8](86a2ee8))
* Adding Milvus demo to examples ([#4910](#4910)) ([2daf852](2daf852))
* Adding retrieve_online_documents endpoint ([#5002](#5002)) ([6607d3d](6607d3d))
* Adding support to return additional features from vector retrieval for Milvus db ([#4971](#4971)) ([6ce08d3](6ce08d3))
* Creating/updating the stable branch after the release. ([#5003](#5003)) ([e9b53cc](e9b53cc))
* Implementing online_read for MilvusOnlineStore ([#4996](#4996)) ([92dde13](92dde13))
* Improve exception message for unsupported Snowflake data types ([#4779](#4779)) ([5992364](5992364))
* Operator add feast ui deployment ([#4930](#4930)) ([b026d0c](b026d0c))
* Updating documents to highlight v2 api for Vector Similarity Se… ([#5000](#5000)) ([32b82a4](32b82a4))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@franciscojavierarceo franciscojavierarceo franciscojavierarceo approved these changes
@redhatHameed redhatHameed redhatHameed approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unable to load UI in 0.41.3

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@boliri @redhatHameed @franciscojavierarceo
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.