GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat: Feast Operator support log level configuration for services by redhatHameed · Pull Request #4808 · feast-dev/feast

feat: Feast Operator support log level configuration for services #4808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tchughesiv merged 7 commits into feast-dev:master from redhatHameed:log-level
Dec 5, 2024

Uh oh!

There was an error while loading. Please reload this page.
Merged

feat: Feast Operator support log level configuration for services #4808

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a7af314
fix: Feast Operator updated the kustomize version to v5.5.0
redhatHameed Dec 2, 2024
609e9a8
feat : Feast Operator support log level configuration for services
redhatHameed Dec 3, 2024
94acc49
Update infra/feast-operator/internal/controller/services/services.go
redhatHameed Dec 4, 2024
7ea29c5
Update infra/feast-operator/internal/controller/services/services.go
redhatHameed Dec 4, 2024
9fb5339
added unit test for loglevel
redhatHameed Dec 4, 2024
fa79e95
fix the loglevel command
redhatHameed Dec 5, 2024
fc4fc79
moved the logLevel under LocalRegistryConfig and updated testcase to …
redhatHameed Dec 5, 2024
File filter
Filter by extension
Clear filters
Conversations
Failed to load comments.
Loading

Uh oh!

There was an error while loading. Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading

Uh oh!

There was an error while loading. Please reload this page.
Diff view
Diff view

There are no files selected for viewing

12 changes: 12 additions & 0 deletions 12 infra/feast-operator/api/v1alpha1/featurestore_types.go
Show comments
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,10 @@ type OfflineStore struct {
ServiceConfigs `json:",inline"`
Persistence *OfflineStorePersistence `json:"persistence,omitempty"`
TLS *OfflineTlsConfigs `json:"tls,omitempty"`
// LogLevel sets the logging level for the offline store service
// Allowed values: "debug", "info", "warning", "error", "critical".
// +kubebuilder:validation:Enum=debug;info;warning;error;critical
LogLevel string `json:"logLevel,omitempty"`
}

// OfflineTlsConfigs configures server TLS for the offline feast service. in an openshift cluster, this is configured by default using service serving certificates.
Expand Down Expand Up @@ -130,6 +134,10 @@ type OnlineStore struct {
ServiceConfigs `json:",inline"`
Persistence *OnlineStorePersistence `json:"persistence,omitempty"`
TLS *TlsConfigs `json:"tls,omitempty"`
// LogLevel sets the logging level for the online store service
// Allowed values: "debug", "info", "warning", "error", "critical".
// +kubebuilder:validation:Enum=debug;info;warning;error;critical
LogLevel string `json:"logLevel,omitempty"`
}

// OnlineStorePersistence configures the persistence settings for the online store service
Expand Down Expand Up @@ -177,6 +185,10 @@ type LocalRegistryConfig struct {
ServiceConfigs `json:",inline"`
Persistence *RegistryPersistence `json:"persistence,omitempty"`
TLS *TlsConfigs `json:"tls,omitempty"`
// LogLevel sets the logging level for the registry service
// Allowed values: "debug", "info", "warning", "error", "critical".
// +kubebuilder:validation:Enum=debug;info;warning;error;critical
LogLevel string `json:"logLevel,omitempty"`
}

// RegistryPersistence configures the persistence settings for the registry service
Expand Down
66 changes: 66 additions & 0 deletions 66 infra/feast-operator/config/crd/bases/feast.dev_featurestores.yaml
Show comments
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,6 +227,17 @@ spec:
description: PullPolicy describes a policy for if/when to
pull a container image
type: string
logLevel:
description: |-
LogLevel sets the logging level for the offline store service
Allowed values: "debug", "info", "warning", "error", "critical".
enum:
- debug
- info
- warning
- error
- critical
type: string
persistence:
description: OfflineStorePersistence configures the persistence
settings for the offline store service
Expand Down Expand Up @@ -576,6 +587,17 @@ spec:
description: PullPolicy describes a policy for if/when to
pull a container image
type: string
logLevel:
description: |-
LogLevel sets the logging level for the online store service
Allowed values: "debug", "info", "warning", "error", "critical".
enum:
- debug
- info
- warning
- error
- critical
type: string
persistence:
description: OnlineStorePersistence configures the persistence
settings for the online store service
Expand Down Expand Up @@ -939,6 +961,17 @@ spec:
description: PullPolicy describes a policy for if/when
to pull a container image
type: string
logLevel:
description: |-
LogLevel sets the logging level for the registry service
Allowed values: "debug", "info", "warning", "error", "critical".
enum:
- debug
- info
- warning
- error
- critical
type: string
persistence:
description: RegistryPersistence configures the persistence
settings for the registry service
Expand Down Expand Up @@ -1429,6 +1462,17 @@ spec:
description: PullPolicy describes a policy for if/when
to pull a container image
type: string
logLevel:
description: |-
LogLevel sets the logging level for the offline store service
Allowed values: "debug", "info", "warning", "error", "critical".
enum:
- debug
- info
- warning
- error
- critical
type: string
persistence:
description: OfflineStorePersistence configures the persistence
settings for the offline store service
Expand Down Expand Up @@ -1784,6 +1828,17 @@ spec:
description: PullPolicy describes a policy for if/when
to pull a container image
type: string
logLevel:
description: |-
LogLevel sets the logging level for the online store service
Allowed values: "debug", "info", "warning", "error", "critical".
enum:
- debug
- info
- warning
- error
- critical
type: string
persistence:
description: OnlineStorePersistence configures the persistence
settings for the online store service
Expand Down Expand Up @@ -2155,6 +2210,17 @@ spec:
description: PullPolicy describes a policy for if/when
to pull a container image
type: string
logLevel:
description: |-
LogLevel sets the logging level for the registry service
Allowed values: "debug", "info", "warning", "error", "critical".
enum:
- debug
- info
- warning
- error
- critical
type: string
persistence:
description: RegistryPersistence configures the persistence
settings for the registry service
Expand Down
15 changes: 15 additions & 0 deletions 15 infra/feast-operator/config/samples/v1alpha1_featurestore_services_loglevel.yaml
Show comments
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
apiVersion: feast.dev/v1alpha1
kind: FeatureStore
metadata:
name: sample-services-loglevel
spec:
feastProject: my_project
services:
onlineStore:
logLevel: debug
offlineStore:
logLevel: debug
registry:
local:
logLevel: info

68 changes: 67 additions & 1 deletion 68 infra/feast-operator/dist/install.yaml
Show comments
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,17 @@ spec:
description: PullPolicy describes a policy for if/when to
pull a container image
type: string
logLevel:
description: |-
LogLevel sets the logging level for the offline store service
Allowed values: "debug", "info", "warning", "error", "critical".
enum:
- debug
- info
- warning
- error
- critical
type: string
persistence:
description: OfflineStorePersistence configures the persistence
settings for the offline store service
Expand Down Expand Up @@ -584,6 +595,17 @@ spec:
description: PullPolicy describes a policy for if/when to
pull a container image
type: string
logLevel:
description: |-
LogLevel sets the logging level for the online store service
Allowed values: "debug", "info", "warning", "error", "critical".
enum:
- debug
- info
- warning
- error
- critical
type: string
persistence:
description: OnlineStorePersistence configures the persistence
settings for the online store service
Expand Down Expand Up @@ -947,6 +969,17 @@ spec:
description: PullPolicy describes a policy for if/when
to pull a container image
type: string
logLevel:
description: |-
LogLevel sets the logging level for the registry service
Allowed values: "debug", "info", "warning", "error", "critical".
enum:
- debug
- info
- warning
- error
- critical
type: string
persistence:
description: RegistryPersistence configures the persistence
settings for the registry service
Expand Down Expand Up @@ -1437,6 +1470,17 @@ spec:
description: PullPolicy describes a policy for if/when
to pull a container image
type: string
logLevel:
description: |-
LogLevel sets the logging level for the offline store service
Allowed values: "debug", "info", "warning", "error", "critical".
enum:
- debug
- info
- warning
- error
- critical
type: string
persistence:
description: OfflineStorePersistence configures the persistence
settings for the offline store service
Expand Down Expand Up @@ -1792,6 +1836,17 @@ spec:
description: PullPolicy describes a policy for if/when
to pull a container image
type: string
logLevel:
description: |-
LogLevel sets the logging level for the online store service
Allowed values: "debug", "info", "warning", "error", "critical".
enum:
- debug
- info
- warning
- error
- critical
type: string
persistence:
description: OnlineStorePersistence configures the persistence
settings for the online store service
Expand Down Expand Up @@ -2163,6 +2218,17 @@ spec:
description: PullPolicy describes a policy for if/when
to pull a container image
type: string
logLevel:
description: |-
LogLevel sets the logging level for the registry service
Allowed values: "debug", "info", "warning", "error", "critical".
enum:
- debug
- info
- warning
- error
- critical
type: string
persistence:
description: RegistryPersistence configures the persistence
settings for the registry service
Expand Down Expand Up @@ -2894,7 +2960,7 @@ spec:
- --leader-elect
command:
- /manager
image: feastdev/feast-operator:0.41.0
image: feastdev/feast-operator:0.42.0
livenessProbe:
httpGet:
path: /healthz
Expand Down
Loading
Oops, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.