GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: Update manifest to add feature server image for odh by redhatHameed · Pull Request #4973 · feast-dev/feast

fix: Update manifest to add feature server image for odh #4973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
redhatHameed merged 2 commits into feast-dev:master from redhatHameed:add-env
Jan 28, 2025

Uh oh!

There was an error while loading. Please reload this page.
Merged

fix: Update manifest to add feature server image for odh #4973

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
02a1fc4
fix: update manifest to add feature server image for odh
redhatHameed Jan 27, 2025
b8a4559
Update infra/scripts/release/files_to_bump.txt
redhatHameed Jan 28, 2025
File filter
Filter by extension
Clear filters
Conversations
Failed to load comments.
Loading

Uh oh!

There was an error while loading. Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading

Uh oh!

There was an error while loading. Please reload this page.
Diff view
Diff view

There are no files selected for viewing

15 changes: 12 additions & 3 deletions 15 infra/feast-operator/config/overlays/odh/kustomization.yaml
Show comments
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ namespace: opendatahub


resources:
- ../../default
- ../../default


patches:
Expand All @@ -25,11 +25,20 @@ replacements:
kind: ConfigMap
name: feast-operator-parameters
version: v1
fieldPath: data.odh-feast-operator-controller-image
fieldPath: data.RELATED_IMAGE_FEAST_OPERATOR
targets:
- select:
kind: Deployment
name: controller-manager
fieldPaths:
- spec.template.spec.containers.[name=manager].image

- source:
kind: ConfigMap
name: feast-operator-parameters
fieldPath: data.RELATED_IMAGE_FEATURE_SERVER
targets:
- select:
kind: Deployment
name: controller-manager
fieldPaths:
- spec.template.spec.containers.[name=manager].env.[name=RELATED_IMAGE_FEATURE_SERVER].value
3 changes: 2 additions & 1 deletion 3 infra/feast-operator/config/overlays/odh/params.env
Show comments
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
odh-feast-operator-controller-image=docker.io/feastdev/feast-operator:0.43.0
RELATED_IMAGE_FEAST_OPERATOR=docker.io/feastdev/feast-operator:0.43.0
RELATED_IMAGE_FEATURE_SERVER=docker.io/feastdev/feature-server:0.43.0
2 changes: 1 addition & 1 deletion 2 infra/scripts/release/files_to_bump.txt
Show comments
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ infra/feast-helm-operator/Makefile 6
infra/feast-helm-operator/config/manager/kustomization.yaml 8
infra/feast-operator/Makefile 6
infra/feast-operator/config/manager/kustomization.yaml 8
infra/feast-operator/config/overlays/odh/params.env 1
infra/feast-operator/config/overlays/odh/params.env 1 2
infra/feast-operator/api/feastversion/version.go 20
java/pom.xml 38
ui/package.json 3
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.