GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: Identify s3/remote uri path correctly by ntkathole · Pull Request #5076 · feast-dev/feast

Conversation

@ntkathole

@ntkathole ntkathole commented Feb 20, 2025

Copy link
Copy Markdown
Member

What this PR does / why we need it:

This is the fix to correctly identify the file path as relative or absolute or remote path using urllib urlparse, which checks both scheme and netloc, ensuring it's a remote URI.

This seems the regression introduced in #4624

Input cases :

Input URI -> Recognized As -> Behavior

  • s3://bucket/data.parquet -> Remote -> Uses as-is
  • /absolute/path/file.parquet -> Local -> Resolves normally
  • relative/path/file.parquet -> Local -> Resolves against config.repo_path
  • C:/path/to/file.parquet (Windows) -> Local -> Resolves correctly

Which issue(s) this PR fixes:

Fixes #4873 #4753 #4993

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@ntkathole
ntkathole requested a review from a team as a code owner February 20, 2025 16:23
franciscojavierarceo
franciscojavierarceo reviewed Feb 20, 2025
View reviewed changes

@franciscojavierarceo franciscojavierarceo left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @ntkathole !!! Any chance you could add some unit tests so we can make sure this issue doesn't slip through going forward?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ntkathole reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@ntkathole
ntkathole force-pushed the fix_remote_uri branch 3 times, most recently from 2bc78f9 to ac389ab Compare February 22, 2025 09:07
@ntkathole

ntkathole commented Feb 24, 2025

Copy link
Copy Markdown
Member Author

add some unit tests so we can make sure this issue doesn't slip through going forward?

Done!

franciscojavierarceo reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@franciscojavierarceo franciscojavierarceo added the ok-to-test label Feb 24, 2025
franciscojavierarceo
franciscojavierarceo reviewed Feb 24, 2025
View reviewed changes
Comment thread sdk/python/feast/infra/offline_stores/file_source.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

franciscojavierarceo
franciscojavierarceo reviewed Feb 24, 2025
View reviewed changes
Comment thread sdk/python/tests/unit/infra/offline_stores/test_offline_store.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

franciscojavierarceo
franciscojavierarceo approved these changes Feb 24, 2025
View reviewed changes

@franciscojavierarceo franciscojavierarceo left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one last nit, otherwise lgtm! approving in advance

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@ntkathole
ntkathole force-pushed the fix_remote_uri branch from ac389ab to eef8511 Compare February 24, 2025 15:01
@ntkathole
fix: Identify s3/remote uri path correctly
e53dc53
Signed-off-by: ntkathole <[email protected]>
@ntkathole
ntkathole force-pushed the fix_remote_uri branch from eef8511 to e53dc53 Compare February 24, 2025 15:08
@franciscojavierarceo
franciscojavierarceo merged commit 93becff into feast-dev:master Feb 24, 2025
franciscojavierarceo pushed a commit that referenced this pull request Mar 10, 2025
@feast-ci-bot
chore(release): release 0.47.0
3e3afa9
# [0.47.0](v0.46.0...v0.47.0) (2025-03-10)

* feat!: Include PUBLIC_URL in defaultProjectListPromise URL in /ui ([2f0f7b3](2f0f7b3))

### Bug Fixes

* Add transformation_service_endpoit to support Go feature server. ([#5071](#5071)) ([5627d7c](5627d7c))
* Adding extra space on the VM to kind cluster to see if this solves the issue with memory not available with operator e2e tests. ([#5102](#5102)) ([e6e928c](e6e928c))
* Allow unencrypted Snowflake key ([#5097](#5097)) ([87a7c23](87a7c23))
* Cant add different type of list types ([#5118](#5118)) ([bebd7be](bebd7be))
* Fixing transformations on writes ([#5127](#5127)) ([95ac34a](95ac34a))
* Identify s3/remote uri path correctly ([#5076](#5076)) ([93becff](93becff))
* Increase available action VM storage and reduce dev feature-server image size ([#5112](#5112)) ([75f5a90](75f5a90))
* Move Feast to pyproject.toml instead of setup.py ([#5067](#5067)) ([4231274](4231274))
* Skip refresh if already in progress or if lock is already held ([#5068](#5068)) ([f3a24de](f3a24de))

### Features

* Add an OOTB Chat uI to the Feature Server to support RAG demo ([#5106](#5106)) ([40ea7a9](40ea7a9))
* Add Couchbase Columnar as an Offline Store ([#5025](#5025)) ([4373cbf](4373cbf))
* Add Feast Operator RBAC example with Kubernetes Authentication … ([#5077](#5077)) ([2179fbe](2179fbe))
* Added docling and pytorch as add on ([#5089](#5089)) ([135342b](135342b))
* Feast Operator example with Postgres in TLS mode. ([#5028](#5028)) ([2c46f6a](2c46f6a))
* Operator - Add feastProjectDir section to CR with git & init options ([#5079](#5079)) ([d64f01e](d64f01e))
* Override the udf name when provided as input to an on demand transformation ([#5094](#5094)) ([8a714bb](8a714bb))
* Set value_type of entity directly in from_proto ([#5092](#5092)) ([90e7498](90e7498))
* Updating retrieve online documents v2 to work for other fields for sq… ([#5082](#5082)) ([fc121c3](fc121c3))

### BREAKING CHANGES

* The PUBLIC_URL environment variable is now taken into account by default
when fetching the projects list. This is a breaking change only if all
these points apply:

1. You're using Feast UI as a module

2. You're serving the UI files from a non-root path via the PUBLIC_URL
   environment variable

3. You're serving the project list from the root path

4. You're not passing the `feastUIConfigs.projectListPromise` prop to
   the FeastUI component

In this case, you need to explicitly fetch the project list from the
root path via the `feastUIConfigs.projectListPromise` prop:

```diff
 const root = createRoot(document.getElementById("root")!);
 root.render(
   <React.StrictMode>
-    <FeastUI />
+    <FeastUI
+      feastUIConfigs={{
+        projectListPromise: fetch("/projects-list.json", {
+            headers: {
+              "Content-Type": "application/json",
+            },
+          }).then((res) => res.json())
+      }}
+    />
   </React.StrictMode>
 );
```

Signed-off-by: Harri Lehtola <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@franciscojavierarceo franciscojavierarceo franciscojavierarceo approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Incorrect path in file data source to s3 bucket

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@ntkathole @franciscojavierarceo
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.