GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — fix: Fix milvus online_read by ntkathole · Pull Request #5233 · feast-dev/feast

Conversation

ntkathole commented Apr 7, 2025

Copy link

Copy Markdown

Member

What this PR does / why we need it:

Fixes get_online_features for milvus:

"/Users/farceo/dev/feast/sdk/python/feast/infra/online_stores/online_store.py", line 199, in get_online_features
    read_rows = self.online_read(
  File "/Users/farceo/dev/feast/sdk/python/feast/infra/online_stores/milvus_online_store/milvus.py", line 421, in online_read
    type(getattr(val, proto_attr)).__args__[0],
AttributeError: __args__

After fix:

def run_entity_retrieval_demo():
    entity_retrieved_features = store.get_online_features(
        features=[
            "docling_transform_docs:vector",
            "docling_transform_docs:chunk_id",
            "docling_transform_docs:chunk_text",
            "docling_transform_docs:document_id",
        ],
        entity_rows=[{"document_id": "doc-1", "chunk_id": "chunk-1"}],
    )
    print("docling transformed features retrieved via entity =")
    print(entity_retrieved_features.to_df())

Connecting to Milvus in local mode using data/online_store.db
docling transformed features retrieved via entity =
  document_id chunk_id                                         chunk_text                                             vector
0       doc-1  chunk-1  a. Picture of a table:\nTables organize valuab...  [0.05077127367258072, -0.005573314614593983, -...

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

ntkathole requested a review from a team as a code owner

April 7, 2025 17:27

franciscojavierarceo added the ok-to-test label

Apr 7, 2025

franciscojavierarceo commented Apr 7, 2025

Copy link

Copy Markdown

Member

@ntkathole looks like tests are failing. DQM has been failing for a bit so surprised I'm seeing it here now.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ntkathole force-pushed the fix_milvus branch from e9d1705 to af48e86 Compare

April 7, 2025 18:44


          fix: Fix milvus online_read

a48a39e

Signed-off-by: ntkathole <[email protected]>

ntkathole force-pushed the fix_milvus branch from af48e86 to a48a39e Compare

April 8, 2025 03:31

franciscojavierarceo approved these changes

Apr 8, 2025

View reviewed changes

franciscojavierarceo merged commit 4b91f26 into feast-dev:master

Apr 8, 2025

franciscojavierarceo pushed a commit that referenced this pull request

Apr 8, 2025


          chore(release): release 0.48.1

eb050c4

## [0.48.1](v0.48.0...v0.48.1) (2025-04-08)

### Bug Fixes

* Fix milvus online_read ([#5233](#5233)) ([4b91f26](4b91f26))
* Resolve `no pq wrapper` import issue ([#5240](#5240)) ([d5906f1](d5906f1))

tchughesiv pushed a commit to tchughesiv/feast that referenced this pull request

Apr 8, 2025


          chore(release): release 0.48.1

0197b7b

## [0.48.1](feast-dev/feast@v0.48.0...v0.48.1) (2025-04-08)

### Bug Fixes

* Fix milvus online_read ([feast-dev#5233](feast-dev#5233)) ([4b91f26](feast-dev@4b91f26))
* Resolve `no pq wrapper` import issue ([feast-dev#5240](feast-dev#5240)) ([d5906f1](feast-dev@d5906f1))

tchughesiv mentioned this pull request

Apr 8, 2025

chore: Cherry-pick release 0.48.1 #5249

Merged

tchughesiv pushed a commit to tchughesiv/feast that referenced this pull request

Apr 8, 2025


          chore(release): release 0.48.1

2ac134b

## [0.48.1](feast-dev/feast@v0.48.0...v0.48.1) (2025-04-08)

### Bug Fixes

* Fix milvus online_read ([feast-dev#5233](feast-dev#5233)) ([4b91f26](feast-dev@4b91f26))
* Resolve `no pq wrapper` import issue ([feast-dev#5240](feast-dev#5240)) ([d5906f1](feast-dev@d5906f1))

Signed-off-by: Tommy Hughes <[email protected]>

tchughesiv added a commit that referenced this pull request

Apr 8, 2025


          chore: Cherry-pick release 0.48.1 (#5249)

a425a45

chore(release): release 0.48.1

## [0.48.1](v0.48.0...v0.48.1) (2025-04-08)

### Bug Fixes

* Fix milvus online_read ([#5233](#5233)) ([4b91f26](4b91f26))
* Resolve `no pq wrapper` import issue ([#5240](#5240)) ([d5906f1](d5906f1))

Signed-off-by: Tommy Hughes <[email protected]>
Co-authored-by: feast-ci-bot <[email protected]>

franciscojavierarceo pushed a commit that referenced this pull request

Apr 29, 2025


          chore(release): release 0.49.0

ad501cd

# [0.49.0](v0.48.0...v0.49.0) (2025-04-29)

### Bug Fixes

* Adding brackets to unit tests ([c46fea3](c46fea3))
* Adding logic back for a step ([2bb240b](2bb240b))
* Adjustment for unit test action ([a6f78ae](a6f78ae))
* Allow get_historical_features with only On Demand Feature View ([#5256](#5256)) ([0752795](0752795))
* CI adjustment ([3850643](3850643))
* Embed Query configuration breaks when switching between DataFrame and SQL ([#5257](#5257)) ([32375a5](32375a5))
* Fix for proto issue in utils ([1b291b2](1b291b2))
* Fix milvus online_read ([#5233](#5233)) ([4b91f26](4b91f26))
* Fix tests ([431d9b8](431d9b8))
* Fixed Permissions object parameter in example ([#5259](#5259)) ([045c100](045c100))
* Java CI [#12](#12) ([d7e44ac](d7e44ac))
* Java PR [#15](#15) ([a5da3bb](a5da3bb))
* Java PR [#16](#16) ([e0320fe](e0320fe))
* Java PR [#17](#17) ([49da810](49da810))
* Materialization logs ([#5243](#5243)) ([4aa2f49](4aa2f49))
* Moving to custom github action for checking skip tests ([caf312e](caf312e))
* Operator - remove default replicas setting from Feast Deployment ([#5294](#5294)) ([e416d01](e416d01))
* Patch java pr [#14](#14) ([592526c](592526c))
* Patch update for test ([a3e8967](a3e8967))
* Remove conditional from steps ([995307f](995307f))
* Remove misleading HTTP prefix from gRPC endpoints in logs and doc ([#5280](#5280)) ([0ee3a1e](0ee3a1e))
* removing id ([268ade2](268ade2))
* Renaming workflow file ([5f46279](5f46279))
* Resolve `no pq wrapper` import issue ([#5240](#5240)) ([d5906f1](d5906f1))
* Update actions to remove check skip tests ([#5275](#5275)) ([b976f27](b976f27))
* Update docling demo ([446efea](446efea))
* Update java pr [#13](#13) ([fda7db7](fda7db7))
* Update java_pr ([fa138f4](fa138f4))
* Update repo_config.py ([6a59815](6a59815))
* Update unit tests workflow ([06486a0](06486a0))
* Updated docs for docling demo ([768e6cc](768e6cc))
* Updating action for unit tests ([0996c28](0996c28))
* Updating github actions to filter at job level ([0a09622](0a09622))
* Updating Java CI ([c7c3a3c](c7c3a3c))
* Updating java pr to skip tests ([e997dd9](e997dd9))
* Updating workflows ([c66bcd2](c66bcd2))

### Features

* Add date_partition_column_format for spark source ([#5273](#5273)) ([7a61d6f](7a61d6f))
* Add Milvus tutorial with Feast integration ([#5292](#5292)) ([a1388a5](a1388a5))
* Add pgvector tutorial with PostgreSQL integration ([#5290](#5290)) ([bb1cbea](bb1cbea))
* Add ReactFlow visualization for Feast registry metadata ([#5297](#5297)) ([9768970](9768970))
* Add retrieve online documents v2 method into  pgvector  ([#5253](#5253)) ([6770ee6](6770ee6))
* Compute Engine Initial Implementation ([#5223](#5223)) ([64bdafd](64bdafd))
* Enable write node for compute engine ([#5287](#5287)) ([f9baf97](f9baf97))
* Local compute engine ([#5278](#5278)) ([8e06dfe](8e06dfe))
* Make transform on writes configurable for ingestion ([#5283](#5283)) ([ecad170](ecad170))
* Offline store update pull_all_from_table_or_query to make timestampfield optional ([#5281](#5281)) ([4b94608](4b94608))
* Serialization version 2 deprecation notice ([#5248](#5248)) ([327d99d](327d99d))
* Vector length definition moved to Feature View from Config  ([#5289](#5289)) ([d8f1c97](d8f1c97))

jfw-ppi pushed a commit to jfw-ppi/feast that referenced this pull request

Jun 7, 2025


          fix: Fix milvus online_read (feast-dev#5233)

6b93508

Signed-off-by: ntkathole <[email protected]>
Signed-off-by: Jacob Weinhold <[email protected]>

jfw-ppi pushed a commit to jfw-ppi/feast that referenced this pull request

Jun 7, 2025


          chore: Cherry-pick release 0.48.1 (feast-dev#5249)

29985ce

chore(release): release 0.48.1

## [0.48.1](feast-dev/feast@v0.48.0...v0.48.1) (2025-04-08)

### Bug Fixes

* Fix milvus online_read ([feast-dev#5233](feast-dev#5233)) ([4b91f26](feast-dev@4b91f26))
* Resolve `no pq wrapper` import issue ([feast-dev#5240](feast-dev#5240)) ([d5906f1](feast-dev@d5906f1))

Signed-off-by: Tommy Hughes <[email protected]>
Co-authored-by: feast-ci-bot <[email protected]>
Signed-off-by: Jacob Weinhold <[email protected]>

jfw-ppi pushed a commit to jfw-ppi/feast that referenced this pull request

Jun 7, 2025


          chore(release): release 0.49.0

0394e64

# [0.49.0](feast-dev/feast@v0.48.0...v0.49.0) (2025-04-29)

### Bug Fixes

* Adding brackets to unit tests ([c46fea3](feast-dev@c46fea3))
* Adding logic back for a step ([2bb240b](feast-dev@2bb240b))
* Adjustment for unit test action ([a6f78ae](feast-dev@a6f78ae))
* Allow get_historical_features with only On Demand Feature View ([feast-dev#5256](feast-dev#5256)) ([0752795](feast-dev@0752795))
* CI adjustment ([3850643](feast-dev@3850643))
* Embed Query configuration breaks when switching between DataFrame and SQL ([feast-dev#5257](feast-dev#5257)) ([32375a5](feast-dev@32375a5))
* Fix for proto issue in utils ([1b291b2](feast-dev@1b291b2))
* Fix milvus online_read ([feast-dev#5233](feast-dev#5233)) ([4b91f26](feast-dev@4b91f26))
* Fix tests ([431d9b8](feast-dev@431d9b8))
* Fixed Permissions object parameter in example ([feast-dev#5259](feast-dev#5259)) ([045c100](feast-dev@045c100))
* Java CI [feast-dev#12](feast-dev#12) ([d7e44ac](feast-dev@d7e44ac))
* Java PR [feast-dev#15](feast-dev#15) ([a5da3bb](feast-dev@a5da3bb))
* Java PR [feast-dev#16](feast-dev#16) ([e0320fe](feast-dev@e0320fe))
* Java PR [feast-dev#17](feast-dev#17) ([49da810](feast-dev@49da810))
* Materialization logs ([feast-dev#5243](feast-dev#5243)) ([4aa2f49](feast-dev@4aa2f49))
* Moving to custom github action for checking skip tests ([caf312e](feast-dev@caf312e))
* Operator - remove default replicas setting from Feast Deployment ([feast-dev#5294](feast-dev#5294)) ([e416d01](feast-dev@e416d01))
* Patch java pr [feast-dev#14](feast-dev#14) ([592526c](feast-dev@592526c))
* Patch update for test ([a3e8967](feast-dev@a3e8967))
* Remove conditional from steps ([995307f](feast-dev@995307f))
* Remove misleading HTTP prefix from gRPC endpoints in logs and doc ([feast-dev#5280](feast-dev#5280)) ([0ee3a1e](feast-dev@0ee3a1e))
* removing id ([268ade2](feast-dev@268ade2))
* Renaming workflow file ([5f46279](feast-dev@5f46279))
* Resolve `no pq wrapper` import issue ([feast-dev#5240](feast-dev#5240)) ([d5906f1](feast-dev@d5906f1))
* Update actions to remove check skip tests ([feast-dev#5275](feast-dev#5275)) ([b976f27](feast-dev@b976f27))
* Update docling demo ([446efea](feast-dev@446efea))
* Update java pr [feast-dev#13](feast-dev#13) ([fda7db7](feast-dev@fda7db7))
* Update java_pr ([fa138f4](feast-dev@fa138f4))
* Update repo_config.py ([6a59815](feast-dev@6a59815))
* Update unit tests workflow ([06486a0](feast-dev@06486a0))
* Updated docs for docling demo ([768e6cc](feast-dev@768e6cc))
* Updating action for unit tests ([0996c28](feast-dev@0996c28))
* Updating github actions to filter at job level ([0a09622](feast-dev@0a09622))
* Updating Java CI ([c7c3a3c](feast-dev@c7c3a3c))
* Updating java pr to skip tests ([e997dd9](feast-dev@e997dd9))
* Updating workflows ([c66bcd2](feast-dev@c66bcd2))

### Features

* Add date_partition_column_format for spark source ([feast-dev#5273](feast-dev#5273)) ([7a61d6f](feast-dev@7a61d6f))
* Add Milvus tutorial with Feast integration ([feast-dev#5292](feast-dev#5292)) ([a1388a5](feast-dev@a1388a5))
* Add pgvector tutorial with PostgreSQL integration ([feast-dev#5290](feast-dev#5290)) ([bb1cbea](feast-dev@bb1cbea))
* Add ReactFlow visualization for Feast registry metadata ([feast-dev#5297](feast-dev#5297)) ([9768970](feast-dev@9768970))
* Add retrieve online documents v2 method into  pgvector  ([feast-dev#5253](feast-dev#5253)) ([6770ee6](feast-dev@6770ee6))
* Compute Engine Initial Implementation ([feast-dev#5223](feast-dev#5223)) ([64bdafd](feast-dev@64bdafd))
* Enable write node for compute engine ([feast-dev#5287](feast-dev#5287)) ([f9baf97](feast-dev@f9baf97))
* Local compute engine ([feast-dev#5278](feast-dev#5278)) ([8e06dfe](feast-dev@8e06dfe))
* Make transform on writes configurable for ingestion ([feast-dev#5283](feast-dev#5283)) ([ecad170](feast-dev@ecad170))
* Offline store update pull_all_from_table_or_query to make timestampfield optional ([feast-dev#5281](feast-dev#5281)) ([4b94608](feast-dev@4b94608))
* Serialization version 2 deprecation notice ([feast-dev#5248](feast-dev#5248)) ([327d99d](feast-dev@327d99d))
* Vector length definition moved to Feature View from Config  ([feast-dev#5289](feast-dev#5289)) ([d8f1c97](feast-dev@d8f1c97))

Signed-off-by: Jacob Weinhold <[email protected]>

Reviewers

franciscojavierarceo

franciscojavierarceo approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.