GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — chore: Refactor transform on write by franciscojavierarceo · Pull Request #5300 · feast-dev/feast

Conversation

@franciscojavierarceo

@franciscojavierarceo franciscojavierarceo commented Apr 28, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

What this PR does / why we need it:

Refactored code to make it easier toread.

Which issue(s) this PR fixes:

Misc

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
franciscojavierarceo added 2 commits April 27, 2025 22:08
@franciscojavierarceo
chore: Refactor transform on write
184f0ef 
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
linter
8f68ea2 
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo franciscojavierarceo added the ok-to-test label Apr 28, 2025
@franciscojavierarceo
franciscojavierarceo marked this pull request as ready for review April 28, 2025 02:16
@franciscojavierarceo
franciscojavierarceo requested a review from a team as a code owner April 28, 2025 02:16
haoxu0
haoxu0 approved these changes Apr 28, 2025
View reviewed changes

@haoxu0 haoxu0 left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me.
But long term I think it's better to refactor with a factory pattern or an abstraction to avoid so many conditions check.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@franciscojavierarceo
franciscojavierarceo merged commit f04872a into master Apr 28, 2025
franciscojavierarceo added a commit that referenced this pull request Apr 28, 2025
@franciscojavierarceo
chore: Refactor transform on write (#5300)
f4ee41f
jfw-ppi pushed a commit to jfw-ppi/feast that referenced this pull request Jun 7, 2025
@franciscojavierarceo @jfw-ppi
chore: Refactor transform on write (feast-dev#5300)
64fa13b 
Signed-off-by: Jacob Weinhold <[email protected]>
@haoxu0 haoxu0 mentioned this pull request Dec 25, 2025
feat: Unify Feature Transformations and Feature Views #5747
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@haoxu0 haoxu0 haoxu0 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@franciscojavierarceo @haoxu0
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.